Conditions | 2 |
Paths | 2 |
Total Lines | 123 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
37 | public function load(ObjectManager $manager) |
||
38 | { |
||
39 | // References of suppliers |
||
40 | $davigel = $this->getReference('supplier1'); |
||
41 | $davifrais = $this->getReference('supplier2'); |
||
42 | $davisec = $this->getReference('supplier3'); |
||
43 | $loireBoissons = $this->getReference('supplier4'); |
||
44 | // References of logistics families |
||
45 | $surgele = $this->getReference('family-log3'); |
||
|
|||
46 | $frais = $this->getReference('family-log4'); |
||
47 | $sec = $this->getReference('family-log5'); |
||
48 | $boissons = $this->getReference('family-log6'); |
||
49 | $fruitLegumesSurgele = $this->getReference('family-log7'); |
||
50 | $patisseriesSurgele = $this->getReference('family-log8'); |
||
51 | $viandeSurgele = $this->getReference('family-log9'); |
||
52 | $fruitLegumesFrais = $this->getReference('family-log10'); |
||
53 | $patisseriesFrais = $this->getReference('family-log11'); |
||
54 | $viandeFrais = $this->getReference('family-log12'); |
||
55 | $fruitLegumesSec = $this->getReference('family-log13'); |
||
56 | $patisseriesSec = $this->getReference('family-log14'); |
||
57 | $bieres = $this->getReference('family-log15'); |
||
58 | $vins = $this->getReference('family-log16'); |
||
59 | // Storage area references |
||
60 | $zoneSurgele = $this->getReference('zoneStorage1'); |
||
61 | $zoneFrais = $this->getReference('zoneStorage2'); |
||
62 | $zoneSec = $this->getReference('zoneStorage3'); |
||
63 | $zoneBoisson = $this->getReference('zoneStorage4'); |
||
64 | // Unit References |
||
65 | $boite = $this->getReference('unit1'); |
||
66 | $bouteille = $this->getReference('unit2'); |
||
67 | $carton = $this->getReference('unit3'); |
||
68 | $colis = $this->getReference('unit4'); |
||
69 | $kilogramme = $this->getReference('unit5'); |
||
70 | $litre = $this->getReference('unit6'); |
||
71 | $piece = $this->getReference('unit7'); |
||
72 | // VAT references |
||
73 | $tvaReduit = $this->getReference('tva1'); |
||
74 | $tvaMoyen = $this->getReference('tva2'); |
||
75 | $tvaLuxe = $this->getReference('tva3'); |
||
76 | |||
77 | // Articles datas |
||
78 | $datas = [ |
||
79 | ['name' => 'Salade', 'supplier' => $davifrais, |
||
80 | 'familyLog' => $fruitLegumesFrais, 'zoneStorage' => $zoneFrais, |
||
81 | 'unitStorage' => $piece, 'unitWorking' => $kilogramme, 'price' => 2.99, |
||
82 | 'packaging' => 12, 'tva' => $tvaReduit, 'minStock' => 2, ], |
||
83 | ['name' => 'Bavette 150gr', 'supplier' => $davigel, |
||
84 | 'familyLog' => $viandeSurgele, 'zoneStorage' => $zoneSurgele, |
||
85 | 'unitStorage' => $piece, 'unitWorking' => $piece, 'price' => 2.99, |
||
86 | 'packaging' => 28, 'tva' => $tvaReduit, 'minStock' => 2, ], |
||
87 | ['name' => 'Baguettine', 'supplier' => $davigel, |
||
88 | 'familyLog' => $viandeSurgele, 'zoneStorage' => $zoneSurgele, |
||
89 | 'unitStorage' => $piece, 'unitWorking' => $piece, 'price' => 15.2, |
||
90 | 'packaging' => 90, 'tva' => $tvaReduit, 'minStock' => 20, ], |
||
91 | ['name' => 'Steack haché 20%MG 120g', 'supplier' => $davigel, |
||
92 | 'familyLog' => $viandeSurgele, 'zoneStorage' => $zoneSurgele, |
||
93 | 'unitStorage' => $piece, 'unitWorking' => $piece, 'price' => 1.22, |
||
94 | 'packaging' => 50, 'tva' => $tvaReduit, 'minStock' => 12, ], |
||
95 | ['name' => 'Ananas poche 2.3 KG', 'supplier' => $davisec, |
||
96 | 'familyLog' => $sec, 'zoneStorage' => $zoneSec, |
||
97 | 'unitStorage' => $piece, 'unitWorking' => $kilogramme, 'price' => 4.05, |
||
98 | 'packaging' => 4, 'tva' => $tvaReduit, 'minStock' => 3, ], |
||
99 | ['name' => 'Appareil Champigons 2 KG', 'supplier' => $davifrais, |
||
100 | 'familyLog' => $frais, 'zoneStorage' => $zoneFrais, |
||
101 | 'unitStorage' => $piece, 'unitWorking' => $kilogramme, 'price' => 6.39, |
||
102 | 'packaging' => 4, 'tva' => $tvaReduit, 'minStock' => 2, ], |
||
103 | ['name' => 'Bacon tranche Barq 88G', 'supplier' => $davifrais, |
||
104 | 'familyLog' => $frais, 'zoneStorage' => $zoneFrais, |
||
105 | 'unitStorage' => $piece, 'unitWorking' => $kilogramme, 'price' => 0.75, |
||
106 | 'packaging' => 6, 'tva' => $tvaReduit, 'minStock' => 2, ], |
||
107 | ['name' => 'Beurre doux 8Gx125', 'supplier' => $davifrais, |
||
108 | 'familyLog' => $frais, 'zoneStorage' => $zoneFrais, |
||
109 | 'unitStorage' => $kilogramme, 'unitWorking' => $piece, 'price' => 6.83, |
||
110 | 'packaging' => 1, 'tva' => $tvaReduit, 'minStock' => 0.5, ], |
||
111 | ['name' => 'Boule pour oeuf neige', 'supplier' => $davifrais, |
||
112 | 'familyLog' => $frais, 'zoneStorage' => $zoneFrais, |
||
113 | 'unitStorage' => $piece, 'unitWorking' => $piece, 'price' => 1.75, |
||
114 | 'packaging' => 6, 'tva' => $tvaReduit, 'minStock' => 2, ], |
||
115 | ['name' => 'Champignons émincé 500G', 'supplier' => $davifrais, |
||
116 | 'familyLog' => $fruitLegumesFrais, 'zoneStorage' => $zoneFrais, |
||
117 | 'unitStorage' => $kilogramme, 'unitWorking' => $kilogramme, |
||
118 | 'price' => 3.17, 'packaging' => 3.5, 'tva' => $tvaReduit, |
||
119 | 'minStock' => 1, ], |
||
120 | ['name' => 'Chorizo prétr. 500G', 'supplier' => $davifrais, |
||
121 | 'familyLog' => $fruitLegumesFrais, 'zoneStorage' => $zoneFrais, |
||
122 | 'unitStorage' => $kilogramme, 'unitWorking' => $kilogramme, |
||
123 | 'price' => 5.11, 'packaging' => 6, 'tva' => $tvaReduit, 'minStock' => 1, ], |
||
124 | ['name' => 'V.RG Bourgueil 75cl', 'supplier' => $loireBoissons, |
||
125 | 'familyLog' => $vins, 'zoneStorage' => $zoneBoisson, |
||
126 | 'unitStorage' => $bouteille, 'unitWorking' => $bouteille, |
||
127 | 'price' => 5.11, 'packaging' => 6, 'tva' => $tvaReduit, 'minStock' => 3, ], |
||
128 | ]; |
||
129 | |||
130 | foreach ($datas as $key => $data) { |
||
131 | $article = new Article(); |
||
132 | $article->setName($data['name']) |
||
133 | ->setSupplier($data['supplier']) |
||
134 | ->setFamilyLog($data['familyLog']) |
||
135 | ->addZoneStorage($data['zoneStorage']) |
||
136 | ->setUnitStorage($data['unitStorage']) |
||
137 | ->setUnitWorking($data['unitWorking']) |
||
138 | ->setPrice($data['price']) |
||
139 | ->setPackaging($data['packaging']) |
||
140 | ->setTva($data['tva']) |
||
141 | ->setMinStock($data['minStock']); |
||
142 | |||
143 | $manager->persist($article); |
||
144 | $order = $key + 1; |
||
145 | $this->addReference('article'.$order, $article); |
||
146 | |||
147 | $material = new Material(); |
||
148 | $material->setName($data['name']) |
||
149 | ->setUnitWorking($data['unitWorking']) |
||
150 | ->addArticle($this->getReference('article'.$order)) |
||
151 | ->setMultiple(0) |
||
152 | ->setActive(1); |
||
153 | |||
154 | $manager->persist($material); |
||
155 | $this->addReference('material'.$order, $material); |
||
156 | } |
||
157 | |||
158 | $manager->flush(); |
||
159 | } |
||
160 | |||
174 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.