Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
32 | View Code Duplication | class TvaController extends AbstractController |
|
33 | { |
||
34 | /** |
||
35 | * Lists all Tva entities. |
||
36 | * |
||
37 | * @Route("/", name="tva") |
||
38 | * @Method("GET") |
||
39 | * @Template() |
||
40 | * |
||
41 | * @return array |
||
42 | */ |
||
43 | public function indexAction() |
||
49 | |||
50 | /** |
||
51 | * Finds and displays a Tva entity. |
||
52 | * |
||
53 | * @Route("/{id}/show", name="tva_show", requirements={"id"="\d+"}) |
||
54 | * @Method("GET") |
||
55 | * @Template() |
||
56 | * |
||
57 | * @param \App\Entity\Settings\Diverse\Tva $tva Tva item to display |
||
58 | * @return array |
||
59 | */ |
||
60 | public function showAction(Tva $tva) |
||
66 | |||
67 | /** |
||
68 | * Displays a form to create a new Tva entity. |
||
69 | * |
||
70 | * @Route("/new", name="tva_new") |
||
71 | * @Method("GET") |
||
72 | * @Template() |
||
73 | * |
||
74 | * @return array |
||
75 | */ |
||
76 | public function newAction() |
||
87 | |||
88 | /** |
||
89 | * Creates a new Tva entity. |
||
90 | * |
||
91 | * @Route("/create", name="tva_create") |
||
92 | * @Method("POST") |
||
93 | * @Template("settings/diverse/tva/new.html.twig") |
||
94 | * |
||
95 | * @param \Symfony\Component\HttpFoundation\Request $request Form request |
||
96 | * @return array |
||
97 | */ |
||
98 | public function createAction(Request $request) |
||
110 | |||
111 | /** |
||
112 | * Displays a form to edit an existing Tva entity. |
||
113 | * |
||
114 | * @Route("/{id}/edit", name="tva_edit", requirements={"id"="\d+"}) |
||
115 | * @Method("GET") |
||
116 | * @Template() |
||
117 | * |
||
118 | * @param \App\Entity\Settings\Diverse\Tva $tva Tva item to edit |
||
119 | * @return array |
||
120 | */ |
||
121 | public function editAction(Tva $tva) |
||
127 | |||
128 | /** |
||
129 | * Edits an existing Tva entity. |
||
130 | * |
||
131 | * @Route("/{id}/update", name="tva_update", requirements={"id"="\d+"}) |
||
132 | * @Method("PUT") |
||
133 | * @Template("settings/diverse/tva/edit.html.twig") |
||
134 | * |
||
135 | * @param \App\Entity\Settings\Diverse\Tva $tva Tva item to update |
||
136 | * @param \Symfony\Component\HttpFoundation\Request $request Form request |
||
137 | * @return array |
||
138 | */ |
||
139 | public function updateAction(Tva $tva, Request $request) |
||
145 | |||
146 | /** |
||
147 | * Deletes a Tva entity. |
||
148 | * |
||
149 | * @Route("/{id}/delete", name="tva_delete", requirements={"id"="\d+"}) |
||
150 | * @Method("DELETE") |
||
151 | * |
||
152 | * @param \App\Entity\Settings\Diverse\Tva $tva Tva item to delete |
||
153 | * @param \Symfony\Component\HttpFoundation\Request $request Form request |
||
154 | * @return type |
||
155 | */ |
||
156 | public function deleteAction(Tva $tva, Request $request) |
||
162 | } |
||
163 |