UserController::updateUserEntity() - Code Metrics - Inspection of "Adapt the render of the FamilyLog Select" - Dev-Int/glsr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — SF4 ( 2d2f19...1dd003 )

by Laurent

created 2018-06-21 21:19 UTC

UserController::updateUserEntity() A

↳ Parent: UserController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

/**
 * AdminController Controller d'administration.
 *
 * PHP Version 7
 *
 * @author    Quétier Laurent <[email protected]>
 * @copyright 2018 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version GIT: $Id$
 *
 * @link https://github.com/Dev-Int/glsr
 */

namespace App\Controller;

use EasyCorp\Bundle\EasyAdminBundle\Controller\AdminController as BaseAdminController;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;

/**
 * Admin Controller override EasyAdminBundle::AdminController
 *
 * @category Controller
 */
class UserController extends BaseAdminController
{
    public function createUserEntityFormBuilder($entity, $view)
    {
        $hierarchy = $this->container->getParameter('security.role_hierarchy.roles');

        // transform the role hierarchy in a single unique list
        $roles = array();
        array_walk_recursive($hierarchy, function ($role) use (&$roles) {
            $roles[$role] = $role;
        });

        $formBuilder = $this->createEntityFormBuilder($entity, $view);
        $formBuilder->
            add('roles', ChoiceType::class, [
                'expanded' => true,
                'multiple' => true,
                'placeholder' => 'Choice a role',
                'choices' => $roles,
            ]);

        return $formBuilder;
    }

    public function updateUserEntity($user)
    {
        $this->get('fos_user.user_manager')->updateUser($user, false);
        parent::updateEntity($user);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			/**
4			* AdminController Controller d'administration.
5			*
6			* PHP Version 7
7			*
8			* @author Quétier Laurent <[email protected]>
9			* @copyright 2018 Dev-Int GLSR
10			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
11			*
12			* @version GIT: $Id$
13			*
14			* @link https://github.com/Dev-Int/glsr
15			*/
16
17			namespace App\Controller;
18
19			use EasyCorp\Bundle\EasyAdminBundle\Controller\AdminController as BaseAdminController;
20			use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
21
22			/**
23			* Admin Controller override EasyAdminBundle::AdminController
24			*
25			* @category Controller
26			*/
27			class UserController extends BaseAdminController
28			{
29			public function createUserEntityFormBuilder($entity, $view)
30			{
31			$hierarchy = $this->container->getParameter('security.role_hierarchy.roles');
32
33			// transform the role hierarchy in a single unique list
34			$roles = array();
35			array_walk_recursive($hierarchy, function ($role) use (&$roles) {
36			$roles[$role] = $role;
37			});
38
39			$formBuilder = $this->createEntityFormBuilder($entity, $view);
40			$formBuilder->
41			add('roles', ChoiceType::class, [
42			'expanded' => true,
43			'multiple' => true,
44			'placeholder' => 'Choice a role',
45			'choices' => $roles,
46			]);
47
48			return $formBuilder;
49			}
50
51			public function updateUserEntity($user)
52			{
53			$this->get('fos_user.user_manager')->updateUser($user, false);
54			parent::updateEntity($user);
			1 ignored issue – show Comprehensibility Bug introduced 2018-06-21 21:22 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateEntity()` instead of `updateUserEntity()`). Are you sure this is correct? If so, you might want to change this to `$this->updateEntity()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
55			}
56			}
57

Dev-Int / glsr

Push — SF4 ( 2d2f19...1dd003 )

UserController::updateUserEntity() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like