GroupController::editAction() - Code Metrics - Inspection of "Add Listener to change submit button" - Dev-Int/glsr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — sf2.7 ( 18de34...b252b6 )

by Laurent

created 2016-03-27 21:42 UTC

GroupController::editAction() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	32
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	32
rs	8.8571
cc	1
eloc	23
nc	1
nop	1

<?php

namespace AppBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use AppBundle\Entity\Group;
use AppBundle\Form\Type\GroupType;

/**
 * Group controller.
 *
 * @Route("/admin/groups")
 */
class GroupController extends Controller
{
    /**
     * Lists all Group entities.
     *
     * @Route("/", name="admin_groups")
     * @Method("GET")
     * @Template()
     */
    public function indexAction()
    {
        $em = $this->getDoctrine()->getManager();
        $entities = $em->getRepository('AppBundle:Group')->findAll();
        
        return array(
            'entities'  => $entities,
        );
    }

    /**
     * Finds and displays a Group entity.
     *
     * @Route("/{id}/show", name="admin_groups_show", requirements={"id"="\d+"})
     * @Method("GET")
     * @Template()
     */
    public function showAction(Group $group)
    {
        $deleteForm = $this->createDeleteForm($group->getId(), 'admin_groups_delete');

        return array(
            'group' => $group,
            'delete_form' => $deleteForm->createView(),
        );
    }

    /**
     * Displays a form to create a new Group entity.
     *
     * @Route("/new", name="admin_groups_new")
     * @Method("GET")
     * @Template()
     */
    public function newAction()
    {
        $group = new Group();
        $form = $this->createForm(new GroupType(), $group);
        $form->add('roles', 'choice', array(
            'choices' => $this->getExistingRoles(),
            'data' => $group->getRoles(),
            'label' => 'Roles',
            'translation_domain' => 'admin',
            'expanded' => true,
            'multiple' => true,
            'mapped' => true,
        ));


        return array(
            'group' => $group,
            'form'   => $form->createView(),
        );
    }

    /**
     * Creates a new Group entity.
     *
     * @Route("/create", name="admin_groups_create")
     * @Method("POST")
     * @Template("AppBundle:Group:new.html.twig")
     */
    public function createAction(Request $request)
    {
        $group = new Group();
        $form = $this->createForm(new GroupType(), $group);
        $form->add('roles', 'choice', array(
            'choices' => $this->getExistingRoles(),
            'data' => $group->getRoles(),
            'label' => 'Roles',
            'expanded' => true,
            'multiple' => true,
            'mapped' => true,
        ));
        if ($form->handleRequest($request)->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->persist($group);
            $em->flush();

            return $this->redirect(
                $this->generateUrl(
                    'admin_groups_show',
                    array('id' => $group->getId())
                )
            );
        }

        return array(
            'group' => $group,
            'form'   => $form->createView(),
        );
    }

    /**
     * Displays a form to edit an existing Group entity.
     *
     * @Route("/{id}/edit", name="admin_groups_edit", requirements={"id"="\d+"})
     * @Method("GET")
     * @Template()
     */
    public function editAction(Group $group)
    {
        $editForm = $this->createForm(
            new GroupType(),
            $group,
            array(
                'action' => $this->generateUrl(
                    'admin_groups_update',
                    array('id' => $group->getId())
                ),
                'method' => 'PUT',
            )
        );
        $editForm->add('roles', 'choice', array(
            'choices' => $this->getExistingRoles(),
            'data' => $group->getRoles(),
            'label' => 'Roles',
            'expanded' => true,
            'multiple' => true,
            'mapped' => true,
        ));
        $deleteForm = $this->createDeleteForm(
            $group->getId(),
            'admin_groups_delete'
        );

        return array(
            'group' => $group,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        );
    }

    /**
     * Edits an existing Group entity.
     *
     * @Route("/{id}/update", name="admin_groups_update", requirements={"id"="\d+"})
     * @Method("PUT")
     * @Template("AppBundle:Group:edit.html.twig")
     */
    public function updateAction(Group $group, Request $request)
    {
        $editForm = $this->createForm(new GroupType(), $group, array(
            'action' => $this->generateUrl('admin_groups_update', array('id' => $group->getId())),
            'method' => 'PUT',
        ));
        $editForm->add('roles', 'choice', array(
            'choices' => $this->getExistingRoles(),
            'data' => $group->getRoles(),
            'label' => 'Roles',
            'expanded' => true,
            'multiple' => true,
            'mapped' => true,
        ));
        if ($editForm->handleRequest($request)->isValid()) {
            $this->getDoctrine()->getManager()->flush();

            return $this->redirect($this->generateUrl('admin_groups_edit', array('id' => $group->getId())));
        }
        $deleteForm = $this->createDeleteForm($group->getId(), 'admin_groups_delete');

        return array(
            'group' => $group,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        );
    }

    /**
     * Deletes a Group entity.
     *
     * @Route("/{id}/delete", name="admin_groups_delete", requirements={"id"="\d+"})
     * @Method("DELETE")
     */
    public function deleteAction(Group $group, Request $request)
    {
        $form = $this->createDeleteForm($group->getId(), 'admin_groups_delete');
        
        // @TODO refactoriser dans le modèle
        $em = $this->getDoctrine()->getManager();
        $users = $group->getUsers();
        foreach ($users as $user) {
            $user->getGroups()->removeElement($group);
        }
        $em->flush();

        $this->get('fos_user.group_manager')->deleteGroup($group);

        if ($form->handleRequest($request)->isValid()) {
            $em = $this->getDoctrine()->getManager();
            $em->remove($group);
            $em->flush();
        }

        return $this->redirect($this->generateUrl('admin_groups'));
    }

    /**
     * Create Delete form
     *
     * @param integer                       $id
     * @param string                        $route
     * @return \Symfony\Component\Form\Form
     */
    protected function createDeleteForm($id, $route)
    {
        return $this->createFormBuilder(null, array('attr' => array('id' => 'delete')))
            ->setAction($this->generateUrl($route, array('id' => $id)))
            ->setMethod('DELETE')
            ->getForm()
        ;
    }

    /**
     * Get the existing roles
     *
     * @return array Array of roles
     */
    private function getExistingRoles()
    {
        $roleHierarchy = $this->container->getParameter('security.role_hierarchy.roles');
        $roles = array_keys($roleHierarchy);

        foreach ($roles as $role) {
            $theRoles[$role] = $role;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        return $theRoles;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php
2
3			namespace AppBundle\Controller;
4
5			use Symfony\Component\HttpFoundation\Request;
6			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
8			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10			use AppBundle\Entity\Group;
11			use AppBundle\Form\Type\GroupType;
12
13			/**
14			* Group controller.
15			*
16			* @Route("/admin/groups")
17			*/
18			class GroupController extends Controller
19			{
20			/**
21			* Lists all Group entities.
22			*
23			* @Route("/", name="admin_groups")
24			* @Method("GET")
25			* @Template()
26			*/
27			public function indexAction()
28			{
29			$em = $this->getDoctrine()->getManager();
30			$entities = $em->getRepository('AppBundle:Group')->findAll();
31
32			return array(
33			'entities' => $entities,
34			);
35			}
36
37			/**
38			* Finds and displays a Group entity.
39			*
40			* @Route("/{id}/show", name="admin_groups_show", requirements={"id"="\d+"})
41			* @Method("GET")
42			* @Template()
43			*/
44			public function showAction(Group $group)
45			{
46			$deleteForm = $this->createDeleteForm($group->getId(), 'admin_groups_delete');
47
48			return array(
49			'group' => $group,
50			'delete_form' => $deleteForm->createView(),
51			);
52			}
53
54			/**
55			* Displays a form to create a new Group entity.
56			*
57			* @Route("/new", name="admin_groups_new")
58			* @Method("GET")
59			* @Template()
60			*/
61			public function newAction()
62			{
63			$group = new Group();
64			$form = $this->createForm(new GroupType(), $group);
65			$form->add('roles', 'choice', array(
66			'choices' => $this->getExistingRoles(),
67			'data' => $group->getRoles(),
68			'label' => 'Roles',
69			'translation_domain' => 'admin',
70			'expanded' => true,
71			'multiple' => true,
72			'mapped' => true,
73			));
74
75
76			return array(
77			'group' => $group,
78			'form' => $form->createView(),
79			);
80			}
81
82			/**
83			* Creates a new Group entity.
84			*
85			* @Route("/create", name="admin_groups_create")
86			* @Method("POST")
87			* @Template("AppBundle:Group:new.html.twig")
88			*/
89			public function createAction(Request $request)
90			{
91			$group = new Group();
92			$form = $this->createForm(new GroupType(), $group);
93			$form->add('roles', 'choice', array(
94			'choices' => $this->getExistingRoles(),
95			'data' => $group->getRoles(),
96			'label' => 'Roles',
97			'expanded' => true,
98			'multiple' => true,
99			'mapped' => true,
100			));
101			if ($form->handleRequest($request)->isValid()) {
102			$em = $this->getDoctrine()->getManager();
103			$em->persist($group);
104			$em->flush();
105
106			return $this->redirect(
107			$this->generateUrl(
108			'admin_groups_show',
109			array('id' => $group->getId())
110			)
111			);
112			}
113
114			return array(
115			'group' => $group,
116			'form' => $form->createView(),
117			);
118			}
119
120			/**
121			* Displays a form to edit an existing Group entity.
122			*
123			* @Route("/{id}/edit", name="admin_groups_edit", requirements={"id"="\d+"})
124			* @Method("GET")
125			* @Template()
126			*/
127			public function editAction(Group $group)
128			{
129			$editForm = $this->createForm(
130			new GroupType(),
131			$group,
132			array(
133			'action' => $this->generateUrl(
134			'admin_groups_update',
135			array('id' => $group->getId())
136			),
137			'method' => 'PUT',
138			)
139			);
140			$editForm->add('roles', 'choice', array(
141			'choices' => $this->getExistingRoles(),
142			'data' => $group->getRoles(),
143			'label' => 'Roles',
144			'expanded' => true,
145			'multiple' => true,
146			'mapped' => true,
147			));
148			$deleteForm = $this->createDeleteForm(
149			$group->getId(),
150			'admin_groups_delete'
151			);
152
153			return array(
154			'group' => $group,
155			'edit_form' => $editForm->createView(),
156			'delete_form' => $deleteForm->createView(),
157			);
158			}
159
160			/**
161			* Edits an existing Group entity.
162			*
163			* @Route("/{id}/update", name="admin_groups_update", requirements={"id"="\d+"})
164			* @Method("PUT")
165			* @Template("AppBundle:Group:edit.html.twig")
166			*/
167			public function updateAction(Group $group, Request $request)
168			{
169			$editForm = $this->createForm(new GroupType(), $group, array(
170			'action' => $this->generateUrl('admin_groups_update', array('id' => $group->getId())),
171			'method' => 'PUT',
172			));
173			$editForm->add('roles', 'choice', array(
174			'choices' => $this->getExistingRoles(),
175			'data' => $group->getRoles(),
176			'label' => 'Roles',
177			'expanded' => true,
178			'multiple' => true,
179			'mapped' => true,
180			));
181			if ($editForm->handleRequest($request)->isValid()) {
182			$this->getDoctrine()->getManager()->flush();
183
184			return $this->redirect($this->generateUrl('admin_groups_edit', array('id' => $group->getId())));
185			}
186			$deleteForm = $this->createDeleteForm($group->getId(), 'admin_groups_delete');
187
188			return array(
189			'group' => $group,
190			'edit_form' => $editForm->createView(),
191			'delete_form' => $deleteForm->createView(),
192			);
193			}
194
195			/**
196			* Deletes a Group entity.
197			*
198			* @Route("/{id}/delete", name="admin_groups_delete", requirements={"id"="\d+"})
199			* @Method("DELETE")
200			*/
201			public function deleteAction(Group $group, Request $request)
202			{
203			$form = $this->createDeleteForm($group->getId(), 'admin_groups_delete');
204
205			// @TODO refactoriser dans le modèle
206			$em = $this->getDoctrine()->getManager();
207			$users = $group->getUsers();
208			foreach ($users as $user) {
209			$user->getGroups()->removeElement($group);
210			}
211			$em->flush();
212
213			$this->get('fos_user.group_manager')->deleteGroup($group);
214
215			if ($form->handleRequest($request)->isValid()) {
216			$em = $this->getDoctrine()->getManager();
217			$em->remove($group);
218			$em->flush();
219			}
220
221			return $this->redirect($this->generateUrl('admin_groups'));
222			}
223
224			/**
225			* Create Delete form
226			*
227			* @param integer $id
228			* @param string $route
229			* @return \Symfony\Component\Form\Form
230			*/
231			protected function createDeleteForm($id, $route)
232			{
233			return $this->createFormBuilder(null, array('attr' => array('id' => 'delete')))
234			->setAction($this->generateUrl($route, array('id' => $id)))
235			->setMethod('DELETE')
236			->getForm()
237			;
238			}
239
240			/**
241			* Get the existing roles
242			*
243			* @return array Array of roles
244			*/
245			private function getExistingRoles()
246			{
247			$roleHierarchy = $this->container->getParameter('security.role_hierarchy.roles');
248			$roles = array_keys($roleHierarchy);
249
250			foreach ($roles as $role) {
251			$theRoles[$role] = $role;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-03-27 22:01 UTC by Report Bug Copy Issue Report `$theRoles` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$theRoles = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
252			}
253			return $theRoles;
			0 ignored issues – show Bug introduced 2016-03-27 22:01 UTC by Report Bug Copy Issue Report The variable `$theRoles` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
254			}
255			}
256

Dev-Int / glsr

Push — sf2.7 ( 18de34...b252b6 )

GroupController::editAction() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like