AppBundle\Controller\DefaultController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	8
Bugs	2	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	1
A	indexAction()	0	15	2
B	testEntities()	0	29	6
A	getFamilyLogAction()	0	21	3

<?php
/**
 * DefaultController controller de l'application GLSR.
 *
 * PHP Version 5
 *
 * @author    Quétier Laurent <lq@dev-int.net>
 * @copyright 2014 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version since 1.0.0
 *
 * @link      https://github.com/Dev-Int/glsr
 */
namespace AppBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Response;

/**
 * Default controller.
 *
 * @category Controller
 *
 * @Route("/")
 */
class DefaultController extends Controller
{
    private $entities;
    
    public function __construct()
    {
        // Tableau des entitées
        $this->entities = array(
            'AppBundle:User',
            'AppBundle:Company',
            'AppBundle:Settings',
            'AppBundle:FamilyLog',
            'AppBundle:SubFamilyLog',
            'AppBundle:ZoneStorage',
            'AppBundle:UnitStorage',
            'AppBundle:Tva',
            'AppBundle:Supplier',
            'AppBundle:Article',
            'AppBundle:Settings');

    }

    /**
     * @Route("/", name="_home")
     * @Method("GET")
     * @Template()
     */
    public function indexAction()
    {
        $url = "";
        /**
         * Test d'installation
         */
//        $url = $this->testEntities();

55% of this comment could be valid code. Did you maybe forget this after debugging?

        if (empty($url)) {
            $url = $this->render('default/index.html.twig');
        } else {
            $url = $this->redirectToRoute($url);
        }
        // replace this example code with whatever you need
        return $url;
    }

    /**
     * Test des entités
     *
     * @return array
     */
    private function testEntities()

This method is not used, and could be removed.

    {
        $url = null;
        $etm = $this->getDoctrine()->getManager();
        // vérifie que les Entitées ne sont pas vides
        $nbEntities = count($this->entities);
        for ($index = 0; $index < $nbEntities; $index++) {
            $entity = $etm->getRepository(
                $this->entities[$index]
            );
            $entityData = $entity->find(1);

            if (empty($entityData)) {
                $message = 'gestock.install.none';
//                $url = 'gs_install'; break;

50% of this comment could be valid code. Did you maybe forget this after debugging?

                $url = '_home';
                break;
            } elseif ($index === 10 && $entityData->getFirstInventory() === null) {
                $message = 'gestock.settings.application.first_inventory.none';
//                $url = 'gestock_inventory_prepare'; break;

50% of this comment could be valid code. Did you maybe forget this after debugging?

                $url = '_home';
                break;
            }
        }
        if (isset($message)) {
            $this->addFlash('warning', $message);
        }
        return $url;
    }

    /**
     * Récupère les FamilyLog de la requête post.
     *
     * @Route("/getfamilylog", name="getfamilylog")
     * @Method("POST")
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function getFamilyLogAction()
    {
        $id = '';

$id is not used, you could remove the assignment.

        $request = $this->getRequest();

The method Symfony\Bundle\FrameworkBundle\Controller\Controller::getRequest() has been deprecated with message: since version 2.4, to be removed in 3.0. Ask Symfony to inject the Request object into your controller method instead by type hinting it in the method's signature.

        $etm = $this->getDoctrine()->getManager();
        if ($request->isXmlHttpRequest()) {
            $id = $request->get('id');
            if ($id != '') {
                $supplier = $etm
                    ->getRepository('AppBundle:Supplier')
                    ->find($id);
                $familyLog['familylog'] = $supplier->getFamilyLog()->getId();

$familyLog was never initialized. Although not strictly required by PHP, it is generally a good practice to add $familyLog = array(); before regardless.

                $response = new Response();
                $data = json_encode($familyLog);
                $response->headers->set('Content-Type', 'application/json');
                $response->setContent($data);
                return $response;
            }
        }
        return new Response('Error');
    }
}