AppBundle\Controller\OrdersController

Complexity

Total Complexity

20

Size/Duplication

Total Lines	248
Duplicated Lines	4.84 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	7
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	showAction()	0	9	1
A	editAction()	0	14	1
B	updateAction()	0	24	2
A	deleteAction()	0	16	3
A	setDates()	0	16	3
A	newAction()	0	19	1
B	createAction()	0	30	4
A	saveOrdersArticles()	12	15	3
A	indexAction()	0	15	1
A	printAction()	0	6	1

<?php
/**
 * OrdersController controller des commandes.
 *
 * PHP Version 5
 *
 * @author    Quétier Laurent <lq@dev-int.net>
 * @copyright 2014 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version since 1.0.0
 *
 * @link      https://github.com/Dev-Int/glsr
 */
namespace AppBundle\Controller;

use Symfony\Component\HttpFoundation\Request;
use AppBundle\Controller\AbstractOrdersController;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;

use AppBundle\Entity\Orders;
use AppBundle\Entity\Supplier;
use AppBundle\Form\Type\OrdersType;
use AppBundle\Form\Type\OrdersEditType;
use AppBundle\Entity\OrdersArticles;

/**
 * Orders controller.
 *
 * @Route("/orders")
 */
class OrdersController extends AbstractOrdersController
{
    /**
     * Lists all Orders entities.
     *
     * @Route("/", name="orders")
     * @Method("GET")
     * @Template()
     */
    public function indexAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

Avoid variables with short names like $em. Configured minimum length is 3.

        $item = $this->container->getParameter('knp_paginator.page_range');
        $qb = $em->getRepository('AppBundle:Orders')->createQueryBuilder('o');

Avoid variables with short names like $qb. Configured minimum length is 3.

        $qb->where('o.orderdate < ' . date('Y-m-d'));
        
        $createForm = $this->createCreateForm('orders_create');

        $paginator = $this->get('knp_paginator')->paginate($qb, $request->query->get('page', 1), $item);
        return array(
            'create_form' => $createForm->createView(),
            'paginator' => $paginator,
        );
    }

    /**
     * Finds and displays a Orders entity.
     *
     * @Route("/{id}/show", name="orders_show", requirements={"id"="\d+"})
     * @Method("GET")
     * @Template()
     */
    public function showAction(Orders $orders)
    {
        $deleteForm = $this->createDeleteForm($orders->getId(), 'orders_delete');

        return array(
            'orders' => $orders,
            'delete_form' => $deleteForm->createView(),
        );
    }

    /**
     * Displays a form to create a new Orders entity.
     *
     * @Route("/new/{supplier}", name="orders_new")
     * @Method("GET")
     * @Template()
     */
    public function newAction(Supplier $supplier)
    {
        $etm = $this->getDoctrine()->getManager();

        $orders = new Orders();
        $orders->setSupplier($supplier);
        $articles = $etm->getRepository('AppBundle:Article')->getArticleFromSupplier($supplier->getId());

        // Set Orders dates (order and delivery)
        $orders = $this->setDates($orders, $supplier);

        $etm->persist($orders);
        // Saving articles of supplier in order
        $this->saveOrdersArticles($articles, $orders, $etm);

        $etm->flush();

        return $this->redirect($this->generateUrl('orders_edit', array('id' => $orders->getId())));
    }

    /**
     * Creates a new Orders entity.
     *
     * @Route("/admin/create", name="orders_create")
     * @Method("POST")
     * @Template("AppBundle:Orders:new.html.twig")
     */
    public function createAction(Request $request)
    {
        $etm = $this->getDoctrine()->getManager();

        $orders = new Orders();
        $form = $this->createForm(OrdersType::class, $orders);
        $return = ['orders' => $orders, 'form' => $form->createView(),];
        $form->handleRequest($request);
        $supplier = $orders->getSupplier();
        $articles = $etm->getRepository('AppBundle:Article')->getArticleFromSupplier($supplier->getId());
        // Tester la liste si un fournisseur à déjà une commande en cours
        $test = $this->get('app.helper.controller')->testSupplierHasArticle($articles);
        if ($test === false) {
            $return = $this->redirectToRoute('orders');
        } else {
            // Set Orders dates (order and delivery)
            $orders = $this->setDates($orders, $supplier);

            if ($form->isValid() && $return !== $this->redirectToRoute('orders')) {
                $etm->persist($orders);
                // Saving articles of supplier in order
                $this->saveOrdersArticles($articles, $orders, $etm);

                $etm->flush();

                $return = $this->redirect($this->generateUrl('orders_edit', array('id' => $orders->getId())));
            }
        }
        return $return;
    }

    /**
     * Displays a form to edit an existing Orders entity.
     *
     * @Route("/admin/{id}/edit", name="orders_edit", requirements={"id"="\d+"})
     * @Method("GET")
     * @Template()
     */
    public function editAction(Orders $orders)
    {
        $editForm = $this->createForm(OrdersEditType::class, $orders, array(
            'action' => $this->generateUrl('orders_update', array('id' => $orders->getId())),
            'method' => 'PUT',
        ));
        $deleteForm = $this->createDeleteForm($orders->getId(), 'orders_delete');

        return array(
            'orders' => $orders,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        );
    }

    /**
     * Edits an existing Orders entity.
     *
     * @Route("/admin/{id}/update", name="orders_update", requirements={"id"="\d+"})
     * @Method("PUT")
     * @Template("AppBundle:Orders:edit.html.twig")
     */
    public function updateAction(Orders $orders, Request $request)
    {
        $editForm = $this->createForm(OrdersEditType::class, $orders, array(
            'action' => $this->generateUrl('orders_update', array('id' => $orders->getId())),
            'method' => 'PUT',
        ));
        $deleteForm = $this->createDeleteForm($orders->getId(), 'orders_delete');
        $editForm->handleRequest($request);

        $return = array(
            'orders' => $orders,
            'edit_form'   => $editForm->createView(),
            'delete_form' => $deleteForm->createView(),
        );
        
        if ($editForm->isValid()) {
            $this->getDoctrine()->getManager()->flush();
            $this->addFlash('info', 'gestock.edit.ok');

            $return = $this->redirect($this->generateUrl('orders_edit', ['id' => $orders->getId()]));
        }

        return $return;
    }

    /**
     * Deletes a Orders entity.
     *
     * @Route("/admin/{id}/delete", name="orders_delete", requirements={"id"="\d+"})
     * @Method("DELETE")
     */
    public function deleteAction(Orders $orders, Request $request)
    {
        $etm = $this->getDoctrine()->getManager();
        $form = $this->createDeleteForm($orders->getId(), 'orders_delete');
        $ordersArticles = $etm->getRepository('AppBundle:OrdersArticles')->findByOrders($orders->getId());

The method findByOrders() does not exist on Doctrine\Common\Persistence\ObjectRepository. Did you maybe mean findBy()?

        if ($form->handleRequest($request)->isValid()) {
            foreach ($ordersArticles as $order) {
                $etm->remove($order);
            }
            $etm->remove($orders);
            $etm->flush();
        }

        return $this->redirect($this->generateUrl('orders'));
    }

    /**
     * Set order Dates.
     *
     * @param \AppBundle\Entity\Orders   $orders   La commande à traiter
     * @param \AppBundle\Entity\Supplier $supplier Le fournisseur concerné
     * @return \AppBundle\Entity\Orders            La commande modifiée
     */
    private function setDates(Orders $orders, Supplier $supplier)
    {
        $orderDate = $supplier->getOrderdate();
        foreach ($orderDate as $date) {
            if ($date >= date('w')) {
                $diffOrder = $date - date('w');
                $diffDeliv = $diffOrder + $supplier->getDelaydeliv();
                $dateOrder = date('Y-m-d H:i:s', mktime(0, 0, 0, date('n'), date('j')+$diffOrder, date('Y')));
                $delivDate = date('Y-m-d H:i:s', mktime(0, 0, 0, date('n'), date('j')+$diffDeliv, date('Y')));
                $orders->setOrderDate(\DateTime::createFromFormat('Y-m-d H:i:s', $dateOrder));

It seems like \DateTime::createFromFormat('Y-m-d H:i:s', $dateOrder) targeting DateTime::createFromFormat() can also be of type false; however, AppBundle\Entity\Orders::setOrderdate() does only seem to accept object<DateTime>, did you maybe forget to handle an error condition?

                $orders->setDelivDate(\DateTime::createFromFormat('Y-m-d H:i:s', $delivDate));

It seems like \DateTime::createFromFormat('Y-m-d H:i:s', $delivDate) targeting DateTime::createFromFormat() can also be of type false; however, AppBundle\Entity\Orders::setDelivdate() does only seem to accept object<DateTime>, did you maybe forget to handle an error condition?

                break;
            }
        }
        return $orders;
    }

    /**
     * Save OrdersArticles.
     *
     * @param array                      $articles Liste des articles
     * @param \AppBundle\Entity\Orders   $orders   La commande à traiter
     * @param \Doctrine\Common\Persistence\ObjectManager $etm Entity Manager
     */
    private function saveOrdersArticles($articles, $orders, $etm)
    {
        foreach ($articles as $article) {

This code seems to be duplicated across your project.

            $ordersArticles = new OrdersArticles();
            $ordersArticles->setOrders($orders);
            $ordersArticles->setArticle($article);
            $ordersArticles->setUnitStorage($article->getUnitStorage());
            if ($article->getMinstock() > $article->getQuantity()) {
                $ordersArticles->setQuantity($article->getMinstock() - $article->getQuantity());
            }
            $ordersArticles->setPrice($article->getPrice());
            $ordersArticles->setTva($article->getTva());
            $etm->persist($ordersArticles);
        }
    }

    /**
     * Print the current order.<br />Creating a `PDF` file for viewing on paper
     *
     * @Route("/{id}/print/", name="orders_print", requirements={"id"="\d+"})
     * @Method("GET")
     * @Template()
     *
     * @param \AppBundle\Entity\Orders $orders Order item to print
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function printAction(Orders $orders)
    {
        $return = $this->abstractPrintAction($orders, 'Orders');
        
        return $return;
    }
}