LoadSupplierData::getOrder() - Code Metrics - Inspection of "Fix SQL error" - Dev-Int/glsr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Recipes ( c1a0bd...9ec83f )

by Laurent

created 2018-09-27 12:41 UTC

LoadSupplierData::getOrder() A

↳ Parent: LoadSupplierData

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
/**
 * LoadSupplierData Données de l'application GLSR.
 *
 * PHP Version 5
 *
 * @author    Quétier Laurent <[email protected]>
 * @copyright 2014 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version GIT: <git_id>
 *
 * @link https://github.com/Dev-Int/glsr
 */
namespace AppBundle\DataFixtures\ORM;

use Doctrine\Common\DataFixtures\AbstractFixture;
use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
use Doctrine\Common\Persistence\ObjectManager;

use libphonenumber\PhoneNumber;
use AppBundle\Entity\Settings\Supplier;

/**
 * Load Supplier Data.
 *
 * @category DataFixtures
 */
class LoadSupplierData extends AbstractFixture implements OrderedFixtureInterface
{
    /**
     * Load data fixtures with the passed EntityManager
     *
     * @param ObjectManager $manager
     */
    public function load(ObjectManager $manager)
    {
        // Serialisation des numéros de téléphone
        $phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
        // Références des catégories
        $surgele = $this->getReference('family-log3');
        $frais = $this->getReference('family-log4');
        $sec = $this->getReference('family-log5');
        $boissons = $this->getReference('family-log6');
        // Datas des suppliers
        $datas =[
            ['name' => 'Davigel', 'address' => '12, rue du gel', 'zipCode' => 75001,
            'town' => 'Paris', 'phone' => $phoneUtil->parse('0140000001', "FR"),
            'fax' => $phoneUtil->parse('0140000001', "FR"),
            'mail' => '[email protected]', 'contact' => 'David Gel',
            'gsm' => $phoneUtil->parse('0160000001', "FR"), 'family' => $surgele,
            'delayDeliv' => 2, 'orderDate' => [2, 5], ],
            ['name' => 'Davifrais', 'address' => '12, rue du frais',
            'zipCode' => 75001, 'town' => 'Paris',
            'phone' => $phoneUtil->parse('0140000002', "FR"),
            'fax' => $phoneUtil->parse('0140000002', "FR"),
            'mail' => '[email protected]', 'contact' => 'David Frais',
            'gsm' => $phoneUtil->parse('0160000002', "FR"), 'family' => $frais,
            'delayDeliv' => 2, 'orderDate' => [2, 5], ],
            ['name' => 'Davisec', 'address' => '12, rue du sec', 'zipCode' => 75001,
            'town' => 'Paris', 'phone' => $phoneUtil->parse('0140000003', "FR"),
            'fax' => $phoneUtil->parse('0140000003', "FR"),
            'mail' => '[email protected]', 'contact' => 'David Sec',
            'gsm' => $phoneUtil->parse('0160000003', "FR"), 'family' => $sec,
            'delayDeliv' => 3, 'orderDate' => [3], ],
            ['name' => 'Loire Boissons', 'address' => '12, rue de la soif',
            'zipCode' => 75001, 'town' => 'Paris',
            'phone' => $phoneUtil->parse('0140000004', "FR"),
            'fax' => $phoneUtil->parse('0140000004', "FR"),
            'mail' => '[email protected]', 'contact' => 'David Sec',
            'gsm' => $phoneUtil->parse('0160000004', "FR"), 'family' => $boissons,
            'delayDeliv' => 3, 'orderDate' => [5], ],
        ];

        foreach ($datas as $key => $data) {
            $supplier = new Supplier();
            $supplier->setName($data['name'])
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setAddress($data['address'])
                ->setZipCode($data['zipCode'])
                ->setTown($data['town'])
                ->setPhone($data['phone'])
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ->setFax($data['fax'])
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ->setMail($data['mail'])
                ->setContact($data['contact'])
                ->setGsm($data['gsm'])
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                ->setFamilyLog($data['family'])
                ->setDelaydeliv($data['delayDeliv'])
                ->setOrderdate($data['orderDate']);

                $manager->persist($supplier);
                $order = $key + 1;
                $this->addReference('supplier' . $order, $supplier);
        }

        $manager->flush();
    }

    /**
     * Get the order of this fixture
     *
     * @return integer
     */
    public function getOrder()
    {
        return 5;
    }
}


1			<?php
2			/**
3			* LoadSupplierData Données de l'application GLSR.
4			*
5			* PHP Version 5
6			*
7			* @author Quétier Laurent <[email protected]>
8			* @copyright 2014 Dev-Int GLSR
9			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
10			*
11			* @version GIT: <git_id>
12			*
13			* @link https://github.com/Dev-Int/glsr
14			*/
15			namespace AppBundle\DataFixtures\ORM;
16
17			use Doctrine\Common\DataFixtures\AbstractFixture;
18			use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
19			use Doctrine\Common\Persistence\ObjectManager;
20
21			use libphonenumber\PhoneNumber;
22			use AppBundle\Entity\Settings\Supplier;
23
24			/**
25			* Load Supplier Data.
26			*
27			* @category DataFixtures
28			*/
29			class LoadSupplierData extends AbstractFixture implements OrderedFixtureInterface
30			{
31			/**
32			* Load data fixtures with the passed EntityManager
33			*
34			* @param ObjectManager $manager
35			*/
36			public function load(ObjectManager $manager)
37			{
38			// Serialisation des numéros de téléphone
39			$phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
40			// Références des catégories
41			$surgele = $this->getReference('family-log3');
42			$frais = $this->getReference('family-log4');
43			$sec = $this->getReference('family-log5');
44			$boissons = $this->getReference('family-log6');
45			// Datas des suppliers
46			$datas =[
47			['name' => 'Davigel', 'address' => '12, rue du gel', 'zipCode' => 75001,
48			'town' => 'Paris', 'phone' => $phoneUtil->parse('0140000001', "FR"),
49			'fax' => $phoneUtil->parse('0140000001', "FR"),
50			'mail' => '[email protected]', 'contact' => 'David Gel',
51			'gsm' => $phoneUtil->parse('0160000001', "FR"), 'family' => $surgele,
52			'delayDeliv' => 2, 'orderDate' => [2, 5], ],
53			['name' => 'Davifrais', 'address' => '12, rue du frais',
54			'zipCode' => 75001, 'town' => 'Paris',
55			'phone' => $phoneUtil->parse('0140000002', "FR"),
56			'fax' => $phoneUtil->parse('0140000002', "FR"),
57			'mail' => '[email protected]', 'contact' => 'David Frais',
58			'gsm' => $phoneUtil->parse('0160000002', "FR"), 'family' => $frais,
59			'delayDeliv' => 2, 'orderDate' => [2, 5], ],
60			['name' => 'Davisec', 'address' => '12, rue du sec', 'zipCode' => 75001,
61			'town' => 'Paris', 'phone' => $phoneUtil->parse('0140000003', "FR"),
62			'fax' => $phoneUtil->parse('0140000003', "FR"),
63			'mail' => '[email protected]', 'contact' => 'David Sec',
64			'gsm' => $phoneUtil->parse('0160000003', "FR"), 'family' => $sec,
65			'delayDeliv' => 3, 'orderDate' => [3], ],
66			['name' => 'Loire Boissons', 'address' => '12, rue de la soif',
67			'zipCode' => 75001, 'town' => 'Paris',
68			'phone' => $phoneUtil->parse('0140000004', "FR"),
69			'fax' => $phoneUtil->parse('0140000004', "FR"),
70			'mail' => '[email protected]', 'contact' => 'David Sec',
71			'gsm' => $phoneUtil->parse('0160000004', "FR"), 'family' => $boissons,
72			'delayDeliv' => 3, 'orderDate' => [5], ],
73			];
74
75			foreach ($datas as $key => $data) {
76			$supplier = new Supplier();
77			$supplier->setName($data['name'])
			0 ignored issues – show Bug introduced 2018-09-27 13:06 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `AppBundle\Entity\Contact` as the method `setFamilyLog()` does only exist in the following sub-classes of `AppBundle\Entity\Contact`: `AppBundle\Entity\Settings\Supplier`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
78			->setAddress($data['address'])
79			->setZipCode($data['zipCode'])
80			->setTown($data['town'])
81			->setPhone($data['phone'])
			0 ignored issues – show Documentation introduced 2018-09-27 13:06 UTC by Report Bug Copy Issue Report `$data['phone']` is of type `object<libphonenumber\PhoneNumber>`, but the function expects a `object<AppBundle\Entity\phone_number>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
82			->setFax($data['fax'])
			0 ignored issues – show Documentation introduced 2018-09-27 13:06 UTC by Report Bug Copy Issue Report `$data['fax']` is of type `object<libphonenumber\PhoneNumber>`, but the function expects a `object<AppBundle\Entity\phone_number>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
83			->setMail($data['mail'])
84			->setContact($data['contact'])
85			->setGsm($data['gsm'])
			0 ignored issues – show Documentation introduced 2018-09-27 13:06 UTC by Report Bug Copy Issue Report `$data['gsm']` is of type `object<libphonenumber\PhoneNumber>`, but the function expects a `object<AppBundle\Entity\phone_number>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86			->setFamilyLog($data['family'])
87			->setDelaydeliv($data['delayDeliv'])
88			->setOrderdate($data['orderDate']);
89
90			$manager->persist($supplier);
91			$order = $key + 1;
92			$this->addReference('supplier' . $order, $supplier);
93			}
94
95			$manager->flush();
96			}
97
98			/**
99			* Get the order of this fixture
100			*
101			* @return integer
102			*/
103			public function getOrder()
104			{
105			return 5;
106			}
107			}
108

Dev-Int / glsr

Push — Recipes ( c1a0bd...9ec83f )

LoadSupplierData::getOrder() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like