LoadDiverseData::load() - Code Metrics - Inspection of "Fix SQL error" - Dev-Int/glsr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Recipes ( c1a0bd...9ec83f )

by Laurent

created 2018-09-27 12:41 UTC

LoadDiverseData::load() B

↳ Parent: LoadDiverseData

Complexity

Conditions	6
Paths	24

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	94
rs	7.5086
c	0
b	0
f	0
cc	6
nc	24
nop	1

How to fix Long Method

<?php
/**
 * LoadDiverseData Données de configuration de l'application GLSR.
 *
 * PHP Version 5
 *
 * @author    Quétier Laurent <[email protected]>
 * @copyright 2014 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version GIT: <git_id>
 *
 * @link https://github.com/Dev-Int/glsr
 */
namespace AppBundle\DataFixtures\ORM;

use Doctrine\Common\DataFixtures\AbstractFixture;
use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
use Doctrine\Common\Persistence\ObjectManager;
use AppBundle\Entity\Settings\Diverse\FamilyLog;
use AppBundle\Entity\Settings\Diverse\ZoneStorage;
use AppBundle\Entity\Settings\Diverse\Unit;
use AppBundle\Entity\Settings\Diverse\Tva;

/**
 * LoadDiverse Data.
 *
 * @category DataFixtures
 */
class LoadDiverseData extends AbstractFixture implements OrderedFixtureInterface
{
    /**
     * Load data fixtures with the passed EntityManager
     *
     * @param ObjectManager $manager
     */
    public function load(ObjectManager $manager)
    {
        // Load FamilyLog
        $familyArray = [
            ['name' => "Alimentaire"],
            ['name' => "Non alimentaire"],
            ['name' => "Surgelé", 'parent' => 1],
            ['name' => "Frais", 'parent' => 1],
            ['name' => "Sec", 'parent' => 1],
            ['name' => "Boissons", 'parent' => 1],
            ['name' => "Fruits&Légumes", 'parent' => 3],
            ['name' => "Patisseries", 'parent' => 3],
            ['name' => "Viandes", 'parent' => 3],
            ['name' => "Fruits&Légumes", 'parent' => 4],
            ['name' => "Patisseries", 'parent' => 4],
            ['name' => "Viandes", 'parent' => 4],
            ['name' => "Fruits&Légumes", 'parent' => 5],
            ['name' => "Patisseries", 'parent' => 5],
            ['name' => "Bières", 'parent' => 6],
            ['name' => "Vins", 'parent' => 6],
        ];
        foreach ($familyArray as $key => $family) {
            $familyLog = new FamilyLog();
            $familyLog->setName($family['name']);
            if (isset($family['parent'])) {
                $parent = $familyLogs[$family['parent'] - 1];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $familyLog->setParent($parent);
            }
            $familyLogs[$key] = $familyLog;

            $manager->persist($familyLog);

            $order = $key + 1;
            $this->addReference('family-log'.$order, $familyLog);
        }

        // Load ZoneStorage
        $zoneArray = [
            ['name' => 'Chambre négative'],
            ['name' => 'Chambre posistive'],
            ['name' => 'Réserve sèche'],
            ['name' => 'Réserve boissons'],
            ['name' => 'Armoire à boissons'],
            ['name' => 'Caisse'],
        ];
        foreach ($zoneArray as $key => $zone) {
            $zoneStorage = new ZoneStorage();
            $zoneStorage->setName($zone['name']);

            $manager->persist($zoneStorage);

            $order = $key + 1;
            $this->addReference('zoneStorage'.$order, $zoneStorage);
        }

        // Load Unit
        $unitArray = [
            ['name' => 'Boite', 'abbr' => 'BOI'],
            ['name' => 'Bouteille', 'abbr' => 'BTE'],
            ['name' => 'Carton', 'abbr' => 'CAR'],
            ['name' => 'Colis', 'abbr' => 'CLS'],
            ['name' => 'Kilogramme', 'abbr' => 'KG'],
            ['name' => 'Litre', 'abbr' => 'L'],
            ['name' => 'Pièce', 'abbr' => 'PIE'],
        ];
        foreach ($unitArray as $key => $unit) {
            $unitStorage = new Unit();
            $unitStorage->setName($unit['name'])
                ->setAbbr($unit['abbr']);

            $manager->persist($unitStorage);

            $order = $key + 1;
            $this->addReference('unit'.$order, $unitStorage);
        }

        // Load Tva
        $tvaArray = [
            ['rate' => '0.055'],
            ['rate' => '0.1'],
            ['rate' => '0.2'],
        ];
        foreach ($tvaArray as $key => $tvaRate) {
            $tva = new Tva();
            $tva->setRate($tvaRate['rate']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $manager->persist($tva);

            $order = $key + 1;
            $this->addReference('tva'.$order, $tva);
        }

        $manager->flush();
    }

    /**
     * Get the order of this fixture
     *
     * @return integer
     */
    public function getOrder()
    {
        return 4;
    }
}


1			<?php
2			/**
3			* LoadDiverseData Données de configuration de l'application GLSR.
4			*
5			* PHP Version 5
6			*
7			* @author Quétier Laurent <[email protected]>
8			* @copyright 2014 Dev-Int GLSR
9			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
10			*
11			* @version GIT: <git_id>
12			*
13			* @link https://github.com/Dev-Int/glsr
14			*/
15			namespace AppBundle\DataFixtures\ORM;
16
17			use Doctrine\Common\DataFixtures\AbstractFixture;
18			use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
19			use Doctrine\Common\Persistence\ObjectManager;
20			use AppBundle\Entity\Settings\Diverse\FamilyLog;
21			use AppBundle\Entity\Settings\Diverse\ZoneStorage;
22			use AppBundle\Entity\Settings\Diverse\Unit;
23			use AppBundle\Entity\Settings\Diverse\Tva;
24
25			/**
26			* LoadDiverse Data.
27			*
28			* @category DataFixtures
29			*/
30			class LoadDiverseData extends AbstractFixture implements OrderedFixtureInterface
31			{
32			/**
33			* Load data fixtures with the passed EntityManager
34			*
35			* @param ObjectManager $manager
36			*/
37			public function load(ObjectManager $manager)
38			{
39			// Load FamilyLog
40			$familyArray = [
41			['name' => "Alimentaire"],
42			['name' => "Non alimentaire"],
43			['name' => "Surgelé", 'parent' => 1],
44			['name' => "Frais", 'parent' => 1],
45			['name' => "Sec", 'parent' => 1],
46			['name' => "Boissons", 'parent' => 1],
47			['name' => "Fruits&Légumes", 'parent' => 3],
48			['name' => "Patisseries", 'parent' => 3],
49			['name' => "Viandes", 'parent' => 3],
50			['name' => "Fruits&Légumes", 'parent' => 4],
51			['name' => "Patisseries", 'parent' => 4],
52			['name' => "Viandes", 'parent' => 4],
53			['name' => "Fruits&Légumes", 'parent' => 5],
54			['name' => "Patisseries", 'parent' => 5],
55			['name' => "Bières", 'parent' => 6],
56			['name' => "Vins", 'parent' => 6],
57			];
58			foreach ($familyArray as $key => $family) {
59			$familyLog = new FamilyLog();
60			$familyLog->setName($family['name']);
61			if (isset($family['parent'])) {
62			$parent = $familyLogs[$family['parent'] - 1];
			0 ignored issues – show Bug introduced 2018-09-27 13:06 UTC by Report Bug Copy Issue Report The variable `$familyLogs` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
63			$familyLog->setParent($parent);
64			}
65			$familyLogs[$key] = $familyLog;
66
67			$manager->persist($familyLog);
68
69			$order = $key + 1;
70			$this->addReference('family-log'.$order, $familyLog);
71			}
72
73			// Load ZoneStorage
74			$zoneArray = [
75			['name' => 'Chambre négative'],
76			['name' => 'Chambre posistive'],
77			['name' => 'Réserve sèche'],
78			['name' => 'Réserve boissons'],
79			['name' => 'Armoire à boissons'],
80			['name' => 'Caisse'],
81			];
82			foreach ($zoneArray as $key => $zone) {
83			$zoneStorage = new ZoneStorage();
84			$zoneStorage->setName($zone['name']);
85
86			$manager->persist($zoneStorage);
87
88			$order = $key + 1;
89			$this->addReference('zoneStorage'.$order, $zoneStorage);
90			}
91
92			// Load Unit
93			$unitArray = [
94			['name' => 'Boite', 'abbr' => 'BOI'],
95			['name' => 'Bouteille', 'abbr' => 'BTE'],
96			['name' => 'Carton', 'abbr' => 'CAR'],
97			['name' => 'Colis', 'abbr' => 'CLS'],
98			['name' => 'Kilogramme', 'abbr' => 'KG'],
99			['name' => 'Litre', 'abbr' => 'L'],
100			['name' => 'Pièce', 'abbr' => 'PIE'],
101			];
102			foreach ($unitArray as $key => $unit) {
103			$unitStorage = new Unit();
104			$unitStorage->setName($unit['name'])
105			->setAbbr($unit['abbr']);
106
107			$manager->persist($unitStorage);
108
109			$order = $key + 1;
110			$this->addReference('unit'.$order, $unitStorage);
111			}
112
113			// Load Tva
114			$tvaArray = [
115			['rate' => '0.055'],
116			['rate' => '0.1'],
117			['rate' => '0.2'],
118			];
119			foreach ($tvaArray as $key => $tvaRate) {
120			$tva = new Tva();
121			$tva->setRate($tvaRate['rate']);
			0 ignored issues – show Documentation introduced 2018-09-27 13:06 UTC by Report Bug Copy Issue Report `$tvaRate['rate']` is of type `string`, but the function expects a `object<AppBundle\Entity\Settings\Diverse\decimal>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
122
123			$manager->persist($tva);
124
125			$order = $key + 1;
126			$this->addReference('tva'.$order, $tva);
127			}
128
129			$manager->flush();
130			}
131
132			/**
133			* Get the order of this fixture
134			*
135			* @return integer
136			*/
137			public function getOrder()
138			{
139			return 4;
140			}
141			}
142

Dev-Int / glsr

Push — Recipes ( c1a0bd...9ec83f )

LoadDiverseData::load() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like