LoadAppData::getOrder() - Code Metrics - Inspection of "Fix SQL error" - Dev-Int/glsr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Recipes ( c1a0bd...9ec83f )

by Laurent

created 2018-09-27 12:41 UTC

LoadAppData::getOrder() A

↳ Parent: LoadAppData

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
/**
 * LoadAppData Données de l'application GLSR.
 *
 * PHP Version 5
 *
 * @author    Quétier Laurent <[email protected]>
 * @copyright 2014 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version GIT: <git_id>
 *
 * @link https://github.com/Dev-Int/glsr
 */
namespace AppBundle\DataFixtures\ORM;

use Doctrine\Common\DataFixtures\AbstractFixture;
use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
use Doctrine\Common\Persistence\ObjectManager;

use libphonenumber\PhoneNumber;
use AppBundle\Entity\Settings\Company;
use AppBundle\Entity\Settings\Settings;

/**
 * LoadApp Data.
 *
 * @category DataFixtures
 */
class LoadAppData extends AbstractFixture implements OrderedFixtureInterface
{
    /**
     * Load data fixtures with the passed EntityManager
     *
     * @param ObjectManager $manager
     */
    public function load(ObjectManager $manager)
    {
        $phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();

        // Load Company
        $app = new Company();
        $app->setName('Dev-Int')
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->setStatus('S.A.R.L.')
            ->setAddress('2, rue de la chèvre')
            ->setZipCode('75000')
            ->setTown('Paris')
            ->setPhone($phoneUtil->parse('0140000000', "FR"))
            ->setFax($phoneUtil->parse('0140000000', "FR"))
            ->setMail('[email protected]')
            ->setContact('Ursule')
            ->setGsm($phoneUtil->parse('0640000000', "FR"));

        $manager->persist($app);

        // Load Settings
        $settings = new Settings();
        $settings->setInventoryStyle("zonestorage")
            ->setCalculation("weighted")
            ->setCurrency("EUR");

        $manager->persist($settings);

        $manager->flush();
    }

    /**
     * Get the order of this fixture
     *
     * @return integer
     */
    public function getOrder()
    {
        return 3;
    }
}

1			<?php
2			/**
3			* LoadAppData Données de l'application GLSR.
4			*
5			* PHP Version 5
6			*
7			* @author Quétier Laurent <[email protected]>
8			* @copyright 2014 Dev-Int GLSR
9			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
10			*
11			* @version GIT: <git_id>
12			*
13			* @link https://github.com/Dev-Int/glsr
14			*/
15			namespace AppBundle\DataFixtures\ORM;
16
17			use Doctrine\Common\DataFixtures\AbstractFixture;
18			use Doctrine\Common\DataFixtures\OrderedFixtureInterface;
19			use Doctrine\Common\Persistence\ObjectManager;
20
21			use libphonenumber\PhoneNumber;
22			use AppBundle\Entity\Settings\Company;
23			use AppBundle\Entity\Settings\Settings;
24
25			/**
26			* LoadApp Data.
27			*
28			* @category DataFixtures
29			*/
30			class LoadAppData extends AbstractFixture implements OrderedFixtureInterface
31			{
32			/**
33			* Load data fixtures with the passed EntityManager
34			*
35			* @param ObjectManager $manager
36			*/
37			public function load(ObjectManager $manager)
38			{
39			$phoneUtil = \libphonenumber\PhoneNumberUtil::getInstance();
40
41			// Load Company
42			$app = new Company();
43			$app->setName('Dev-Int')
			0 ignored issues – show Bug introduced 2018-09-27 13:06 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `AppBundle\Entity\Contact` as the method `setStatus()` does only exist in the following sub-classes of `AppBundle\Entity\Contact`: `AppBundle\Entity\Settings\Company`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
44			->setStatus('S.A.R.L.')
45			->setAddress('2, rue de la chèvre')
46			->setZipCode('75000')
47			->setTown('Paris')
48			->setPhone($phoneUtil->parse('0140000000', "FR"))
49			->setFax($phoneUtil->parse('0140000000', "FR"))
50			->setMail('[email protected]')
51			->setContact('Ursule')
52			->setGsm($phoneUtil->parse('0640000000', "FR"));
53
54			$manager->persist($app);
55
56			// Load Settings
57			$settings = new Settings();
58			$settings->setInventoryStyle("zonestorage")
59			->setCalculation("weighted")
60			->setCurrency("EUR");
61
62			$manager->persist($settings);
63
64			$manager->flush();
65			}
66
67			/**
68			* Get the order of this fixture
69			*
70			* @return integer
71			*/
72			public function getOrder()
73			{
74			return 3;
75			}
76			}

Dev-Int / glsr

Push — Recipes ( c1a0bd...9ec83f )

LoadAppData::getOrder() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like