AppBundle\Helper\ControllerHelper

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	4
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testSupplierHasArticle()	0	13	2
A	testOrderInProgress()	0	12	3

<?php
/**
 * ControllerHelper Helpers de l'application GLSR.
 *
 * PHP Version 5
 *
 * @author    Quétier Laurent <lq@dev-int.net>
 * @copyright 2014 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version since 1.0.0
 *
 * @link      https://github.com/Dev-Int/glsr
 */
namespace AppBundle\Helper;

use AppBundle\Entity\Article;
use Doctrine\Common\Persistence\ObjectManager;

/**
 * Controller helper.
 *
 * @category Helper
 */
class ControllerHelper
{
    /**
     * Tests of creation conditions.
     *
     * @param array Articles à tester
     * @return boolean
     */
    public function testSupplierHasArticle(array $articles)

function testSupplierHasArticle() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        $return = true;

        // This supplier has no articles!
        if (count($articles) < 1) {
            $message = $this->get('translator')->trans('settings.no_articles', array(), 'gs_suppliers');

The method get() does not seem to exist on object<AppBundle\Helper\ControllerHelper>.

            $this->addFlash('danger', $message);

The method addFlash() does not seem to exist on object<AppBundle\Helper\ControllerHelper>.

            $return = false;
        }

        return $return;
    }

    /**
     * Tests Order in progress for a supplier.
     *
     * @param \AppBundle\Entity\Article $articles Articles to test
     * @param \Doctrine\Common\Persistence\ObjectManager $etm Named object manager
     * @return boolean
     */
    public function testOrderInProgress(Article $articles, ObjectManager $etm)

function testOrderInProgress() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        $return = false;
        $orders = $etm->getRepository('AppBundle:Orders')->findAll();
        // This provider already has an order in progress!
        foreach ($orders as $order) {
            if ($order->getSupplier() === $articles->getSupplier()) {
                $return = true;
            }
        }
        return $return;
    }
}