GlsrDefinition::define() - Code Metrics - Inspection of "Refactor delete doctrine ORM" - Dev-Int/glsr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#151)

by Laurent

created 2021-02-19 16:55 UTC

GlsrDefinition::define() B

↳ Parent: GlsrDefinition

Complexity

Conditions	1
Paths	1

Size

Total Lines	69
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	58
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	69
rs	8.9163

How to fix Long Method

<?php

declare(strict_types=1);

/*
 * This file is part of the G.L.S.R. Apps package.
 *
 * (c) Dev-Int Création <[email protected]>.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Administration\Infrastructure\Resources\doctrine;

use DbalSchema\SchemaDefinition;
filter:
    dependency_paths: ["lib/*"]
use Doctrine\DBAL\Schema\Schema;
filter:
    dependency_paths: ["lib/*"]

class GlsrDefinition implements SchemaDefinition
{
    public function define(Schema $schema): void
    {
        // Messenger definition
        $messengerTable = $schema->createTable('messenger_messages');
        $messengerTable->addColumn('id', 'bigint', ['autoincrement' => true]);
        $messengerTable->addColumn('body', 'text');
        $messengerTable->addColumn('headers', 'text');
        $messengerTable->addColumn('queue_name', 'string', ['length' => 190]);
        $messengerTable->addColumn('created_at', 'datetime');
        $messengerTable->addColumn('available_at', 'datetime');
        $messengerTable->addColumn('delivered_at', 'datetime', ['notnull' => false]);
        $messengerTable->addIndex(['queue_name']);
        $messengerTable->addIndex(['available_at']);
        $messengerTable->addIndex(['delivered_at']);
        $messengerTable->setPrimaryKey(['id']);

        // Company definition
        $companyTable = $schema->createTable('company');
        $companyTable->addColumn('uuid', 'string', ['length' => 36]);
        $companyTable->addColumn('name', 'string', ['length' => 150]);
        $companyTable->addColumn('address', 'string');
        $companyTable->addColumn('zip_code', 'string', ['length' => 5]);
        $companyTable->addColumn('town', 'string');
        $companyTable->addColumn('country', 'string');
        $companyTable->addColumn('phone', 'string', ['length' => 12]);
        $companyTable->addColumn('facsimile', 'string', ['notnull' => false, 'length' => 12]);
        $companyTable->addColumn('email', 'string');
        $companyTable->addColumn('contact_name', 'string');
        $companyTable->addColumn('cellphone', 'string', ['length' => 12]);
        $companyTable->addColumn('slug', 'string');
        $companyTable->setPrimaryKey(['uuid']);

        // Settings definition
        $settingsTable = $schema->createTable('settings');
        $settingsTable->addColumn('uuid', 'string', ['length' => 36]);
        $settingsTable->addColumn('currency', 'string', ['length' => 20]);
        $settingsTable->addColumn('locale', 'string', ['length' => 10]);
        $settingsTable->setPrimaryKey(['uuid']);

        // User definition
        $userTable = $schema->createTable('user');
        $userTable->addColumn('uuid', 'string', ['length' => 36]);
        $userTable->addColumn('username', 'string', ['length' => 150]);
        $userTable->addColumn('email', 'string');
        $userTable->addColumn('password', 'string', ['length' => 120]);
        $userTable->addColumn('roles', 'simple_array');
        $userTable->setPrimaryKey(['uuid']);

        // Supplier definition
        $supplierTable = $schema->createTable('supplier');
        $supplierTable->addColumn('uuid', 'string', ['length' => 36]);
        $supplierTable->addColumn('name', 'string', ['length' => 150]);
        $supplierTable->addColumn('address', 'string');
        $supplierTable->addColumn('zip_code', 'string', ['length' => 5]);
        $supplierTable->addColumn('town', 'string');
        $supplierTable->addColumn('country', 'string');
        $supplierTable->addColumn('phone', 'string', ['length' => 12]);
        $supplierTable->addColumn('facsimile', 'string', ['notnull' => false, 'length' => 12]);
        $supplierTable->addColumn('email', 'string');
        $supplierTable->addColumn('contact_name', 'string');
        $supplierTable->addColumn('cellphone', 'string', ['length' => 12]);
        $supplierTable->addColumn('family_log', 'string');
        $supplierTable->addColumn('delay_delivery', 'integer');
        $supplierTable->addColumn('order_days', 'simple_array');
        $supplierTable->addColumn('slug', 'string');
        $supplierTable->addColumn('active', 'smallint', ['length' => 1]);
        $supplierTable->setPrimaryKey(['uuid']);
        $supplierTable->addUniqueIndex(['name']);
        $supplierTable->addUniqueIndex(['slug']);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the G.L.S.R. Apps package.
7			*
8			* (c) Dev-Int Création <[email protected]>.
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Administration\Infrastructure\Resources\doctrine;
15
16			use DbalSchema\SchemaDefinition;
			0 ignored issues – show Bug introduced 2021-02-19 16:54 UTC by Report Bug Copy Issue Report The type `DbalSchema\SchemaDefinition` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
17			use Doctrine\DBAL\Schema\Schema;
			0 ignored issues – show Bug introduced 2021-02-19 16:54 UTC by Report Bug Copy Issue Report The type `Doctrine\DBAL\Schema\Schema` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
18
19			class GlsrDefinition implements SchemaDefinition
20			{
21			public function define(Schema $schema): void
22			{
23			// Messenger definition
24			$messengerTable = $schema->createTable('messenger_messages');
25			$messengerTable->addColumn('id', 'bigint', ['autoincrement' => true]);
26			$messengerTable->addColumn('body', 'text');
27			$messengerTable->addColumn('headers', 'text');
28			$messengerTable->addColumn('queue_name', 'string', ['length' => 190]);
29			$messengerTable->addColumn('created_at', 'datetime');
30			$messengerTable->addColumn('available_at', 'datetime');
31			$messengerTable->addColumn('delivered_at', 'datetime', ['notnull' => false]);
32			$messengerTable->addIndex(['queue_name']);
33			$messengerTable->addIndex(['available_at']);
34			$messengerTable->addIndex(['delivered_at']);
35			$messengerTable->setPrimaryKey(['id']);
36
37			// Company definition
38			$companyTable = $schema->createTable('company');
39			$companyTable->addColumn('uuid', 'string', ['length' => 36]);
40			$companyTable->addColumn('name', 'string', ['length' => 150]);
41			$companyTable->addColumn('address', 'string');
42			$companyTable->addColumn('zip_code', 'string', ['length' => 5]);
43			$companyTable->addColumn('town', 'string');
44			$companyTable->addColumn('country', 'string');
45			$companyTable->addColumn('phone', 'string', ['length' => 12]);
46			$companyTable->addColumn('facsimile', 'string', ['notnull' => false, 'length' => 12]);
47			$companyTable->addColumn('email', 'string');
48			$companyTable->addColumn('contact_name', 'string');
49			$companyTable->addColumn('cellphone', 'string', ['length' => 12]);
50			$companyTable->addColumn('slug', 'string');
51			$companyTable->setPrimaryKey(['uuid']);
52
53			// Settings definition
54			$settingsTable = $schema->createTable('settings');
55			$settingsTable->addColumn('uuid', 'string', ['length' => 36]);
56			$settingsTable->addColumn('currency', 'string', ['length' => 20]);
57			$settingsTable->addColumn('locale', 'string', ['length' => 10]);
58			$settingsTable->setPrimaryKey(['uuid']);
59
60			// User definition
61			$userTable = $schema->createTable('user');
62			$userTable->addColumn('uuid', 'string', ['length' => 36]);
63			$userTable->addColumn('username', 'string', ['length' => 150]);
64			$userTable->addColumn('email', 'string');
65			$userTable->addColumn('password', 'string', ['length' => 120]);
66			$userTable->addColumn('roles', 'simple_array');
67			$userTable->setPrimaryKey(['uuid']);
68
69			// Supplier definition
70			$supplierTable = $schema->createTable('supplier');
71			$supplierTable->addColumn('uuid', 'string', ['length' => 36]);
72			$supplierTable->addColumn('name', 'string', ['length' => 150]);
73			$supplierTable->addColumn('address', 'string');
74			$supplierTable->addColumn('zip_code', 'string', ['length' => 5]);
75			$supplierTable->addColumn('town', 'string');
76			$supplierTable->addColumn('country', 'string');
77			$supplierTable->addColumn('phone', 'string', ['length' => 12]);
78			$supplierTable->addColumn('facsimile', 'string', ['notnull' => false, 'length' => 12]);
79			$supplierTable->addColumn('email', 'string');
80			$supplierTable->addColumn('contact_name', 'string');
81			$supplierTable->addColumn('cellphone', 'string', ['length' => 12]);
82			$supplierTable->addColumn('family_log', 'string');
83			$supplierTable->addColumn('delay_delivery', 'integer');
84			$supplierTable->addColumn('order_days', 'simple_array');
85			$supplierTable->addColumn('slug', 'string');
86			$supplierTable->addColumn('active', 'smallint', ['length' => 1]);
87			$supplierTable->setPrimaryKey(['uuid']);
88			$supplierTable->addUniqueIndex(['name']);
89			$supplierTable->addUniqueIndex(['slug']);
90			}
91			}
92

Dev-Int / glsr

Pull Request — develop (#151)

GlsrDefinition::define() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like