Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 40 | class InstallController extends Controller |
||
| 41 | { |
||
| 42 | /** |
||
| 43 | * Page d'accueil de l'installation. |
||
| 44 | * |
||
| 45 | * @Route("/", name="gs_install") |
||
| 46 | * |
||
| 47 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
|
|
|||
| 48 | */ |
||
| 49 | public function indexAction() |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Etape 1 de l'installation. |
||
| 56 | * Création des utilisateurs. |
||
| 57 | * |
||
| 58 | * @Route("/step1", name="gs_install_st1") |
||
| 59 | * @Method({"POST","GET"}) |
||
| 60 | * @Template("AppBundle:install:step1.html.twig") |
||
| 61 | * |
||
| 62 | * @param Symfony\Component\HttpFoundation\Request $request Requète du formulaire |
||
| 63 | * |
||
| 64 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
| 65 | */ |
||
| 66 | public function step1Action(Request $request) |
||
| 92 | |||
| 93 | /** |
||
| 94 | * Etape 2 de l'installation. |
||
| 95 | * Création de l'entreprise. |
||
| 96 | * |
||
| 97 | * @Route("/step2", name="gs_install_st2") |
||
| 98 | * @Method({"POST","GET"}) |
||
| 99 | * @Template("AppBundle:install:step2.html.twig") |
||
| 100 | * |
||
| 101 | * @param Symfony\Component\HttpFoundation\Request $request Requète du formulaire |
||
| 102 | * |
||
| 103 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
| 104 | */ |
||
| 105 | View Code Duplication | public function step2Action(Request $request) |
|
| 128 | |||
| 129 | /** |
||
| 130 | * Etape 3 de l'installation. |
||
| 131 | * Création de la configuration. |
||
| 132 | * |
||
| 133 | * @Route("/step3", name="gs_install_st3") |
||
| 134 | * @Method({"POST","GET"}) |
||
| 135 | * @Template("AppBundle:install:step3.html.twig") |
||
| 136 | * |
||
| 137 | * @param Symfony\Component\HttpFoundation\Request $request Requète du formulaire |
||
| 138 | * |
||
| 139 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
| 140 | */ |
||
| 141 | View Code Duplication | public function step3Action(Request $request) |
|
| 164 | |||
| 165 | /** |
||
| 166 | * Etape 4 de l'installation. |
||
| 167 | * Cronfiguration de l'application. |
||
| 168 | * |
||
| 169 | * @Route("/step4", name="gs_install_st4") |
||
| 170 | * @Method({"GET"}) |
||
| 171 | * @Template("AppBundle:install:step4.html.twig") |
||
| 172 | * |
||
| 173 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
| 174 | */ |
||
| 175 | public function step4Action() |
||
| 179 | |||
| 180 | /** |
||
| 181 | * Etape 5 de l'installation. |
||
| 182 | * Création des fournisseurs. |
||
| 183 | * |
||
| 184 | * @Route("/step5", name="gs_install_st5") |
||
| 185 | * @Method({"POST","GET"}) |
||
| 186 | * @Template("AppBundle:install:step5.html.twig") |
||
| 187 | * |
||
| 188 | * @param Symfony\Component\HttpFoundation\Request $request Requète du formulaire |
||
| 189 | * |
||
| 190 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
| 191 | */ |
||
| 192 | View Code Duplication | public function step5Action(Request $request) |
|
| 215 | |||
| 216 | /** |
||
| 217 | * Etape 6 de l'installation. |
||
| 218 | * Création des articles. |
||
| 219 | * |
||
| 220 | * @Route("/step6", name="gs_install_st6") |
||
| 221 | * @Method({"POST","GET"}) |
||
| 222 | * @Template("AppBundle:install:step6.html.twig") |
||
| 223 | * |
||
| 224 | * @param Symfony\Component\HttpFoundation\Request $request Requète du formulaire |
||
| 225 | * |
||
| 226 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
| 227 | */ |
||
| 228 | View Code Duplication | public function step6Action(Request $request) |
|
| 251 | |||
| 252 | /** |
||
| 253 | * Etape 7 de l'installation. |
||
| 254 | * Inventaire d'installation. |
||
| 255 | * |
||
| 256 | * @Route("/step7", name="gs_install_st7") |
||
| 257 | * @Method({"GET"}) |
||
| 258 | * @Template("AppBundle:install:step7.html.twig") |
||
| 259 | * |
||
| 260 | * @return Symfony\Component\HttpFoundation\Response Rendue de la page |
||
| 261 | */ |
||
| 262 | public function step7Action() |
||
| 274 | } |
||
| 275 |
This check compares the return type specified in the
@returnannotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.