Passed
Push — feat/manage-settings ( 66d990...95214d )
by
unknown
01:35
created

GetUsers   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 25
Duplicated Lines 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 3
eloc 10
c 1
b 0
f 0
dl 0
loc 25
rs 10

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 9 1
A __invoke() 0 9 2
1
<?php
2
3
declare(strict_types=1);
4
5
/*
6
 * This file is part of the G.L.S.R. Apps package.
7
 *
8
 * (c) Dev-Int Création <[email protected]>.
9
 *
10
 * For the full copyright and license information, please view the LICENSE
11
 * file that was distributed with this source code.
12
 */
13
14
namespace User\UI\Controller;
15
16
use Core\Controller\AbstractController;
17
use Core\Infrastructure\Response\JsonResponse;
18
use Symfony\Component\HttpFoundation\Response;
0 ignored issues
show
Bug introduced by
The type Symfony\Component\HttpFoundation\Response was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
19
use Symfony\Component\Serializer\SerializerInterface;
0 ignored issues
show
Bug introduced by
The type Symfony\Component\Serializer\SerializerInterface was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
20
use User\Infrastructure\Storage\ReadUser;
21
22
class GetUsers extends AbstractController
23
{
24
    private JsonResponse $jsonResponse;
25
    private ReadUser $readUser;
26
27
    public function __construct(
28
        ReadUser $readUser,
29
        SerializerInterface $serializer,
30
        JsonResponse $jsonResponse
31
    ) {
32
        parent::__construct($serializer);
0 ignored issues
show
Bug introduced by
The call to Core\Controller\AbstractController::__construct() has too few arguments starting with jsonResponse. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

32
        parent::/** @scrutinizer ignore-call */ 
33
                __construct($serializer);

This check compares calls to functions or methods with their respective definitions. If the call has less arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
33
34
        $this->jsonResponse = $jsonResponse;
35
        $this->readUser = $readUser;
36
    }
37
38
    public function __invoke(): Response
39
    {
40
        $users = $this->readUser->findAll();
41
42
        if (empty($users)) {
43
            return $this->jsonResponse->response('No data found', Response::HTTP_ACCEPTED);
44
        }
45
46
        return $this->jsonResponse->response($this->serialize($users));
0 ignored issues
show
Bug introduced by
$users of type User\Infrastructure\Doctrine\Entity\User[] is incompatible with the type object expected by parameter $object of Core\Controller\AbstractController::serialize(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

46
        return $this->jsonResponse->response($this->serialize(/** @scrutinizer ignore-type */ $users));
Loading history...
47
    }
48
}
49