AppBundle\Helper\TimeHelper

Complexity

Total Complexity

8

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getEaster()	0	19	3
B	getNextOpenDay()	0	22	5

<?php
/**
 * TimeHelper Helpers pour les dates de l'application GLSR.
 *
 * PHP Version 5
 *
 * @author    Quétier Laurent <lq@dev-int.net>
 * @copyright 2014 Dev-Int GLSR
 * @license   http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 * @version since 1.0.0
 *
 * @link      https://github.com/Dev-Int/glsr
 */
namespace AppBundle\Helper;

/**
 * Time helper.
 *
 * @category Helper
 */
class TimeHelper
{
    /**
     * get Easter date.
     *
     * @param integer $pYear
     * @return timestamp
     */
    private function getEaster ($pYear = null)
    {
	if (is_null ($pYear)) {
            $pYear = (int)date ('Y');
	}
	$nDate = $pYear - 1900;
	$pAa = $nDate%19;
	$pBb = floor (((7*$pAa)+1)/19);
	$pCc = ((11*$pAa)-$pBb+4)%29;
	$pDd = floor ($nDate/4);
	$pEe = ($nDate-$pCc+$pDd+31)%7;
	$pResult = 25-$pCc-$pEe;
	if ($pResult > 0) {
            $pEaster = strtotime ($pYear.'/04/'.$pResult);
	} else {
            $pEaster = strtotime ($pYear.'/03/'.(31+$pResult));
	}
	return $pEaster;
    }

    /**
     * get the next open day.
     *
     * @link http://codes-sources.commentcamarche.net/source/38705-jours-ouvres Jours ouvrés
     * @author Malalam
     *
     * @param timestamp $pDate Order date
     * @param integer   $pDays Delta for the day of delivery
     * @return integer  Delta next business day
     */
    function getNextOpenDay ($pDate, $pDays) {

It is generally recommended to explicitly declare the visibility for methods.

	$aBankHolidays = ['1_1', '1_5', '8_5', '14_7', '15_8', '1_11', '11_11', '25_12', ];
	if (function_exists ('easter_date')) {
            $pEaster = easter_date ((int)date('Y'), $pDate);
	} else {
            $pEaster = $this->getEaster ((int)date('Y'), $pDate);

The call to TimeHelper::getEaster() has too many arguments starting with $pDate.

	}
	$aBankHolidays[] = date ('j_n',$pEaster);
	$aBankHolidays[] = date ('j_n', $pEaster + (86400*39));
	$aBankHolidays[] = date ('j_n', $pEaster + (86400*49));

        $pEnd = $pDays * 86400;
	$idn = 0;
	while ($idn < $pEnd) {
		$idn = strtotime ('+1 day', $idn);
		if (in_array (date ('w', $pDate+$idn),array (0,6) ) || in_array (date ('j_n', $pDate+$idn), $aBankHolidays)) {
			$pEnd = strtotime ('+1 day', $pEnd);
			$pDays ++;
		}
	}
	return $pDays;
}
}