JMS\JobQueueBundle\Console\Application

Complexity

Total Complexity

14

Size/Duplication

Total Lines	86
Duplicated Lines	6.98 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	2
A	doRun()	0	15	2
A	onTick()	3	23	5
A	saveDebugInformation()	3	22	4
A	getConnection()	0	4	1

<?php

namespace JMS\JobQueueBundle\Console;

declare(ticks=10000000);

use Doctrine\DBAL\Statement;
use Doctrine\DBAL\Types\Type;

use Symfony\Bundle\FrameworkBundle\Console\Application as BaseApplication;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\ErrorHandler\Exception\FlattenException;
use Symfony\Component\HttpKernel\KernelInterface;

/**
 * Records debugging information for executed commands.
 *
 * @author Johannes M. Schmitt <schmittjoh@gmail.com>
 */
class Application extends BaseApplication
{
    private $insertStatStmt;
    private $input;

    public function __construct(KernelInterface $kernel)
    {
        parent::__construct($kernel);

        $this->getDefinition()->addOption(new InputOption('--jms-job-id', null, InputOption::VALUE_REQUIRED, 'The ID of the Job.'));

        $kernel->boot();
        if ($kernel->getContainer()->getParameter('jms_job_queue.statistics')) {
            $this->insertStatStmt = "INSERT INTO jms_job_statistics (job_id, characteristic, createdAt, charValue) VALUES (:jobId, :name, :createdAt, :value)";
            register_tick_function(array($this, 'onTick'));
        }
    }

    public function doRun(InputInterface $input, OutputInterface $output)
    {
        $this->input = $input;

        try {
            $rs = parent::doRun($input, $output);
            $this->saveDebugInformation();

            return $rs;
        } catch (\Exception $ex) {
            $this->saveDebugInformation($ex);

            throw $ex;
        }
    }

    public function onTick()
    {
        if (!$this->input->hasOption('jms-job-id') || null === $jobId = $this->input->getOption('jms-job-id')) {

This code seems to be duplicated across your project.

            return;
        }

        $characteristics = array(
            'memory' => memory_get_usage(),
        );

        if (!$this->insertStatStmt instanceof Statement) {
            $this->insertStatStmt = $this->getConnection()->prepare($this->insertStatStmt);
        }

        $this->insertStatStmt->bindValue('jobId', $jobId, \PDO::PARAM_INT);
        $this->insertStatStmt->bindValue('createdAt', new \DateTime(), Type::getType('datetime'));

        foreach ($characteristics as $name => $value) {
            $this->insertStatStmt->bindValue('name', $name);
            $this->insertStatStmt->bindValue('value', $value);
            $this->insertStatStmt->execute();
        }
    }

    private function saveDebugInformation(\Throwable $ex = null)
    {
        if (!$this->input->hasOption('jms-job-id') || null === $jobId = $this->input->getOption('jms-job-id')) {

This code seems to be duplicated across your project.

            return;
        }

        $this->getConnection()->executeUpdate(
            "UPDATE jms_jobs SET stackTrace = :trace, memoryUsage = :memoryUsage, memoryUsageReal = :memoryUsageReal WHERE id = :id",
            array(
                'id' => $jobId,
                'memoryUsage' => memory_get_peak_usage(),
                'memoryUsageReal' => memory_get_peak_usage(true),
                'trace' => serialize($ex ? FlattenException::create($ex) : null),

$ex of type object<Throwable> is not a sub-type of object<Exception>. It seems like you assume a concrete implementation of the interface Throwable to be always present.

            ),
            array(
                'id' => \PDO::PARAM_INT,
                'memoryUsage' => \PDO::PARAM_INT,
                'memoryUsageReal' => \PDO::PARAM_INT,
                'trace' => \PDO::PARAM_LOB,
            )
        );
    }

    private function getConnection()
    {
        return $this->getKernel()->getContainer()->get('doctrine')->getManagerForClass('JMSJobQueueBundle:Job')->getConnection();
    }
}