Conditions | 1 |
Total Lines | 115 |
Code Lines | 89 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | """ |
||
55 | @pytest.mark.parametrize( |
||
56 | "name,expected", |
||
57 | [ |
||
58 | ( |
||
59 | "paired", |
||
60 | [ |
||
61 | [ |
||
62 | ("./data/test/nifti/paired/test", "case000025", "nii.gz"), |
||
63 | ("./data/test/nifti/paired/test", "case000026", "nii.gz"), |
||
64 | ], |
||
65 | None, |
||
66 | ], |
||
67 | ), |
||
68 | ( |
||
69 | "unpaired", |
||
70 | [ |
||
71 | [ |
||
72 | ("./data/test/nifti/unpaired/test", "case000025", "nii.gz"), |
||
73 | ("./data/test/nifti/unpaired/test", "case000026", "nii"), |
||
74 | ], |
||
75 | None, |
||
76 | ], |
||
77 | ), |
||
78 | ( |
||
79 | "grouped", |
||
80 | [ |
||
81 | [ |
||
82 | ( |
||
83 | "./data/test/nifti/grouped/test", |
||
84 | "group1", |
||
85 | "case000025", |
||
86 | "nii.gz", |
||
87 | ), |
||
88 | ( |
||
89 | "./data/test/nifti/grouped/test", |
||
90 | "group1", |
||
91 | "case000026", |
||
92 | "nii.gz", |
||
93 | ), |
||
94 | ], |
||
95 | [[0, 1]], |
||
96 | ], |
||
97 | ), |
||
98 | ( |
||
99 | "multi_dirs_grouped", |
||
100 | [ |
||
101 | [ |
||
102 | ( |
||
103 | "./data/test/nifti/grouped/test", |
||
104 | "group1", |
||
105 | "case000025", |
||
106 | "nii.gz", |
||
107 | ), |
||
108 | ( |
||
109 | "./data/test/nifti/grouped/test", |
||
110 | "group1", |
||
111 | "case000026", |
||
112 | "nii.gz", |
||
113 | ), |
||
114 | ( |
||
115 | "./data/test/nifti/grouped/train", |
||
116 | "group1", |
||
117 | "case000000", |
||
118 | "nii.gz", |
||
119 | ), |
||
120 | ( |
||
121 | "./data/test/nifti/grouped/train", |
||
122 | "group1", |
||
123 | "case000001", |
||
124 | "nii.gz", |
||
125 | ), |
||
126 | ( |
||
127 | "./data/test/nifti/grouped/train", |
||
128 | "group1", |
||
129 | "case000003", |
||
130 | "nii.gz", |
||
131 | ), |
||
132 | ( |
||
133 | "./data/test/nifti/grouped/train", |
||
134 | "group1", |
||
135 | "case000008", |
||
136 | "nii.gz", |
||
137 | ), |
||
138 | ( |
||
139 | "./data/test/nifti/grouped/train", |
||
140 | "group2", |
||
141 | "case000009", |
||
142 | "nii.gz", |
||
143 | ), |
||
144 | ( |
||
145 | "./data/test/nifti/grouped/train", |
||
146 | "group2", |
||
147 | "case000011", |
||
148 | "nii.gz", |
||
149 | ), |
||
150 | ( |
||
151 | "./data/test/nifti/grouped/train", |
||
152 | "group2", |
||
153 | "case000012", |
||
154 | "nii.gz", |
||
155 | ), |
||
156 | ], |
||
157 | [[0, 1], [2, 3, 4, 5], [6, 7, 8]], |
||
158 | ], |
||
159 | ), |
||
160 | ], |
||
161 | ) |
||
162 | def test_init(self, name, expected): |
||
163 | loader = get_loader(name) |
||
164 | got = [ |
||
165 | loader.data_path_splits, |
||
166 | loader.group_struct, |
||
167 | ] |
||
168 | assert got == expected |
||
169 | loader.close() |
||
170 | |||
330 |