Deel18 / weather-module

src/Curl/Curl.php

<?php
/**
 * Curl, a class supporting the darkssky API.
 */

namespace Anax\Curl;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

class Curl
{

    use ContainerInjectableTrait;

    public function weather($latitude, $longitude)
    {
        $apiKey = require ANAX_INSTALL_PATH . "/config/apikey.php";
        $apiKey = $apiKey["darksky"];
        $curl = curl_init();

        curl_setopt($curl, CURLOPT_URL, "https://api.darksky.net/forecast/$apiKey/$latitude,$longitude?exclude=minutely,hourly,alerts,flags");

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);

        $result = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        $decode = json_decode($result);

        return $decode;
    }

    public function pastWeather($latitude, $longitude)
    {
        $apiKey = require ANAX_INSTALL_PATH . "/config/apikey.php";
        $apiKey = $apiKey["darksky"];

        $url = "https://api.darksky.net/forecast/$apiKey/$latitude,$longitude";


        $month = [];
        for ($i = 0; $i > -30; $i--) {
            $month[] = strtotime("$i day");
        }

        $options = [
            CURLOPT_RETURNTRANSFER => true,
        ];

        $mhd = curl_multi_init();

        $chAll = [];
        foreach ($month as $day) {
            $chd = curl_init("$url, $day");
            curl_setopt_array($chd, $options);

It seems like $chd can also be of type false; however, parameter $ch of curl_setopt_array() does only seem to accept resource, maybe add an additional type check?

            curl_multi_add_handle($mhd, $chd);

It seems like $chd can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

            $chAll[] = $chd;
        }

        $running = null;

        do {
            curl_multi_exec($mhd, $running);
        } while ($running);

        foreach ($chAll as $chd) {
            curl_multi_remove_handle($mhd, $chd);
        }
        curl_multi_close($mhd);



        $response = [];

        foreach ($chAll as $chd) {
            $data = curl_multi_getcontent($chd);
            $response[] = json_decode($data, true);
        }

        return $response;
    }



    public function getApiKey()
    {
        //For rendering openstreetmaps
        $apiKey = require ANAX_INSTALL_PATH . "/config/apikey.php";
        $apiKey = $apiKey["openstreetmap"];
        return $apiKey;
    }
}