WeatherController::indexActionPost() - Code Metrics - Deel18/weather-module - Measure and Improve Code Quality continuously with Scrutinizer

WeatherController::indexActionPost() B
last analyzed 2020-01-22 19:19 UTC

↳ Parent: WeatherController

Complexity

Conditions	6
Paths	6

Size

Total Lines	61
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	39
CRAP Score	6.0005

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	40
c	1
b	0
f	0
nc	6
nop	0
dl	0
loc	61
ccs	39
cts	40
cp	0.975
crap	6.0005
rs	8.6577

How to fix Long Method

<?php

namespace Anax\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Anax\Curl\Curl as Curl;

// use Anax\Route\Exception\ForbiddenException;
// use Anax\Route\Exception\NotFoundException;
// use Anax\Route\Exception\InternalErrorException;

/**
 * A sample controller to show how a controller class can be implemented.
 * The controller will be injected with $di if implementing the interface
 * ContainerInjectableInterface, like this sample class does.
 * The controller is mounted on a particular route and can then handle all
 * requests for that mount point.
 *
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
class WeatherController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;


    public function indexAction() : object
    {

        $title = "Weather";

        $address = $_SERVER["REMOTE_ADDR"] ?? "No IP detected.";



        $page = $this->di->get("page");
        $session = $this->di->session;


        $res = $session->get("res", null);
        $ipv = $session->get("ip", null);
        $geo = $session->get("geo", null);
        $apikey = $session->get("apikey", null);
        $weatherWeek = $session->get("weatherWeek", null);
        $weatherPast = $session->get("weatherPast", null);
        $latitude = $session->get("latitude", null);
        $longitude = $session->get("longitude", null);

        $session->set("res", null);
        $session->set("ip", null);
        $session->set("weatherWeek", null);
        $session->set("weatherPast", null);
        $session->set("geo", null);
        $session->set("latitude", null);
        $session->set("longitude", null);
        $session->set("apikey", null);



        $data = [
            "res" => $res,
            "ip" => $ipv,
            "address" => $address,
            "weatherWeek" => $weatherWeek,
            "weatherPast" => $weatherPast,
            "geo" => $geo,
            "latitude" => $latitude,
            "longitude" => $longitude,
            "apikey" => $apikey,
        ];

        $page->add("weather/verify", $data);

        return $page->render([
            "title" => $title,
        ]);
    }

    public function indexActionPost()
    {
        $request = $this->di->request;

        $response = $this->di->response;

        $session = $this->di->session;


        $doVerify = $request->getPost("verify", null);
        $address = $request->getPost("ip", null);
        $latitude = $request->getPost("latitude", null);
        $longitude = $request->getPost("longitude", null);

        $check = $this->di->get("validator");

        $weather = new Curl();


        if ($doVerify && $address) {
            $result = $check->checkIpv($address);

            $geotag = $check->geoTag($address);


            $fetchWeather = $weather->weather($geotag->latitude, $geotag->longitude);
            $fetchPastWeather = $weather->pastWeather($geotag->latitude, $geotag->longitude);

            $data = $fetchWeather->daily;

            $pastData = $fetchPastWeather;

            $session->set("res", $result);
            $session->set("ip", $address);
            $session->set("weatherWeek", $data);
            $session->set("weatherPast", $pastData);
            $session->set("latitude", $geotag->latitude);
            $session->set("longitude", $geotag->longitude);
            $session->set("apikey", $weather->getApiKey());
        }

        if ($doVerify && $latitude) {
            $verifyCoord = $check->verifyGeo($latitude, $longitude);

            if ($verifyCoord) {
                $fetchWeather = $weather->weather($latitude, $longitude);
                $fetchPastWeather = $weather->pastWeather($latitude, $longitude);

                $data = $fetchWeather->daily;
                $pastData = $fetchPastWeather;

                $valid = "The coordinates $latitude, $longitude are valid.";

                $session->set("geo", $valid);
                $session->set("weatherWeek", $data);
                $session->set("weatherPast", $pastData);
                $session->set("latitude", $latitude);
                $session->set("longitude", $longitude);
                $session->set("apikey", $weather->getApiKey());
            } else {
                $session->set("geo", "The coordinates are invalid. Try again.");
            }
        }
        return $response->redirect("weather");
    }
}


1		<?php
2
3		namespace Anax\Weather;
4
5		use Anax\Commons\ContainerInjectableInterface;
6		use Anax\Commons\ContainerInjectableTrait;
7		use Anax\Curl\Curl as Curl;
8
9		// use Anax\Route\Exception\ForbiddenException;
10		// use Anax\Route\Exception\NotFoundException;
11		// use Anax\Route\Exception\InternalErrorException;
12
13		/**
14		* A sample controller to show how a controller class can be implemented.
15		* The controller will be injected with $di if implementing the interface
16		* ContainerInjectableInterface, like this sample class does.
17		* The controller is mounted on a particular route and can then handle all
18		* requests for that mount point.
19		*
20		* @SuppressWarnings(PHPMD.TooManyPublicMethods)
21		*/
22		class WeatherController implements ContainerInjectableInterface
23		{
24		use ContainerInjectableTrait;
25
26
27	1	public function indexAction() : object
28		{
29
30	1	$title = "Weather";
31
32	1	$address = $_SERVER["REMOTE_ADDR"] ?? "No IP detected.";
33
34
35
36	1	$page = $this->di->get("page");
37	1	$session = $this->di->session;
		0 ignored issues – show Bug introduced 2020-01-19 02:04 UTC by Report Bug Copy Issue Report Accessing `session` on the interface `Psr\Container\ContainerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
38
39	1	$res = $session->get("res", null);
40	1	$ipv = $session->get("ip", null);
41	1	$geo = $session->get("geo", null);
42	1	$apikey = $session->get("apikey", null);
43	1	$weatherWeek = $session->get("weatherWeek", null);
44	1	$weatherPast = $session->get("weatherPast", null);
45	1	$latitude = $session->get("latitude", null);
46	1	$longitude = $session->get("longitude", null);
47
48	1	$session->set("res", null);
49	1	$session->set("ip", null);
50	1	$session->set("weatherWeek", null);
51	1	$session->set("weatherPast", null);
52	1	$session->set("geo", null);
53	1	$session->set("latitude", null);
54	1	$session->set("longitude", null);
55	1	$session->set("apikey", null);
56
57
58
59		$data = [
60	1	"res" => $res,
61	1	"ip" => $ipv,
62	1	"address" => $address,
63	1	"weatherWeek" => $weatherWeek,
64	1	"weatherPast" => $weatherPast,
65	1	"geo" => $geo,
66	1	"latitude" => $latitude,
67	1	"longitude" => $longitude,
68	1	"apikey" => $apikey,
69		];
70
71	1	$page->add("weather/verify", $data);
72
73	1	return $page->render([
74	1	"title" => $title,
75		]);
76		}
77
78	1	public function indexActionPost()
79		{
80	1	$request = $this->di->request;
		0 ignored issues – show Bug introduced 2020-01-19 02:04 UTC by Report Bug Copy Issue Report Accessing `request` on the interface `Psr\Container\ContainerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
81	1	$response = $this->di->response;
		0 ignored issues – show Bug introduced 2020-01-19 02:04 UTC by Report Bug Copy Issue Report Accessing `response` on the interface `Psr\Container\ContainerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
82	1	$session = $this->di->session;
		0 ignored issues – show Bug introduced 2020-01-19 02:04 UTC by Report Bug Copy Issue Report Accessing `session` on the interface `Psr\Container\ContainerInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
83
84	1	$doVerify = $request->getPost("verify", null);
85	1	$address = $request->getPost("ip", null);
86	1	$latitude = $request->getPost("latitude", null);
87	1	$longitude = $request->getPost("longitude", null);
88
89	1	$check = $this->di->get("validator");
90
91	1	$weather = new Curl();
92
93
94	1	if ($doVerify && $address) {
95	1	$result = $check->checkIpv($address);
96
97	1	$geotag = $check->geoTag($address);
98
99
100	1	$fetchWeather = $weather->weather($geotag->latitude, $geotag->longitude);
101	1	$fetchPastWeather = $weather->pastWeather($geotag->latitude, $geotag->longitude);
102
103	1	$data = $fetchWeather->daily;
104
105	1	$pastData = $fetchPastWeather;
106
107	1	$session->set("res", $result);
108	1	$session->set("ip", $address);
109	1	$session->set("weatherWeek", $data);
110	1	$session->set("weatherPast", $pastData);
111	1	$session->set("latitude", $geotag->latitude);
112	1	$session->set("longitude", $geotag->longitude);
113	1	$session->set("apikey", $weather->getApiKey());
114		}
115
116	1	if ($doVerify && $latitude) {
117	1	$verifyCoord = $check->verifyGeo($latitude, $longitude);
118
119	1	if ($verifyCoord) {
120	1	$fetchWeather = $weather->weather($latitude, $longitude);
121	1	$fetchPastWeather = $weather->pastWeather($latitude, $longitude);
122
123	1	$data = $fetchWeather->daily;
124	1	$pastData = $fetchPastWeather;
125
126	1	$valid = "The coordinates $latitude, $longitude are valid.";
127
128	1	$session->set("geo", $valid);
129	1	$session->set("weatherWeek", $data);
130	1	$session->set("weatherPast", $pastData);
131	1	$session->set("latitude", $latitude);
132	1	$session->set("longitude", $longitude);
133	1	$session->set("apikey", $weather->getApiKey());
134		} else {
135		$session->set("geo", "The coordinates are invalid. Try again.");
136		}
137		}
138	1	return $response->redirect("weather");
139		}
140		}
141

Deel18 / weather-module

WeatherController::indexActionPost() B last analyzed 2020-01-22 19:19 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

WeatherController::indexActionPost() B
last analyzed 2020-01-22 19:19 UTC