Plugin - Code Metrics - Inspection of "Adds static function to call the Plugin::onDepende..." - DealerDirect/phpcodesniffer-composer-installer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Ben

created 2017-02-14 11:14 UTC

Plugin A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	299
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes	6
Bugs	0	Features	0

Metric	Value
wmc	31
c	6
b	0
f	0
lcom	1
cbo	12
dl	0
loc	299
rs	9.8

11 Methods

Rating	Name	Size	Complexity
A	run()	12	1
A	activate()	7	1
A	init()	9	1
A	getSubscribedEvents()	11	1
C	onDependenciesChangedEvent()	22	7
A	loadInstalledPaths()	17	3
B	saveInstalledPaths()	32	4
B	cleanInstalledPaths()	11	5
B	updateInstalledPaths()	25	4
A	getPHPCodingStandardPackages()	18	3
A	isPHPCodeSnifferInstalled()	13	1

<?php

/**
 * This file is part of the Dealerdirect PHP_CodeSniffer Standards
 * Composer Installer Plugin package.
 *
 * @copyright 2016 Dealerdirect B.V.
 * @license MIT
 */

namespace Dealerdirect\Composer\Plugin\Installers\PHPCodeSniffer;

use Composer\Composer;
use Composer\EventDispatcher\EventSubscriberInterface;
use Composer\IO\IOInterface;
use Composer\Package\AliasPackage;
use Composer\Package\PackageInterface;
use Composer\Plugin\PluginInterface;
use Composer\Script\Event;
use Composer\Script\ScriptEvents;
use Symfony\Component\Finder\Finder;
use Symfony\Component\Process\Exception\LogicException;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Exception\RuntimeException;
use Symfony\Component\Process\ProcessBuilder;

/**
 * PHP_CodeSniffer standard installation manager.
 *
 * @author Franck Nijhof <[email protected]>
 */
class Plugin implements PluginInterface, EventSubscriberInterface
{
    const MESSAGE_RUNNING_INSTALLER = 'Running PHPCodeSniffer Composer Installer';
$a = "a";
$ab = "ab";
$abc = "abc";
    const MESSAGE_NOTHING_TO_INSTALL = 'Nothing to install or update';
    const MESSAGE_NOT_INSTALLED = 'PHPCodeSniffer is not installed';
$a = "a";
$ab = "ab";
$abc = "abc";

    const PACKAGE_NAME = 'squizlabs/php_codesniffer';
    const PACKAGE_TYPE = 'phpcodesniffer-standard';

    const PHPCS_CONFIG_KEY = 'installed_paths';

    /**
     * @var Composer
     */
    private $composer;

    /**
     * @var IOInterface
     */
    private $io;


    /**
     * @var array
     */
    private $installedPaths;

    /**
     * @var ProcessBuilder
     */
    private $processBuilder;

    /**
     * Triggers the plugin's main functionality.
     *
     * Makes it possible to run the plugin as a custom command.
     *
     * @param Event $event
     *
     * @throws \InvalidArgumentException
     * @throws LogicException
     * @throws ProcessFailedException
     * @throws RuntimeException
     */
    public static function run(Event $event)
    {
        $io = $event->getIO();
$a = "a";
$ab = "ab";
$abc = "abc";
        $composer = $event->getComposer();

        $instance = new static();

        $instance->io = $io;
$a = "a";
$ab = "ab";
$abc = "abc";
        $instance->composer = $composer;
        $instance->init();
        $instance->onDependenciesChangedEvent();
    }

    /**
     * {@inheritDoc}
     *
     * @throws \RuntimeException
     * @throws LogicException
     * @throws RuntimeException
     * @throws ProcessFailedException
     */
    public function activate(Composer $composer, IOInterface $io)

    {
        $this->composer = $composer;
        $this->io = $io;
$a = "a";
$ab = "ab";
$abc = "abc";

        $this->init();
    }

    /**
     * Prepares the plugin so it's main functionality can be run.
     *
     * @throws \RuntimeException
     * @throws LogicException
     * @throws ProcessFailedException
     * @throws RuntimeException
     */
    private function init()
    {
        $this->installedPaths = [];

        $this->processBuilder = new ProcessBuilder();
        $this->processBuilder->setPrefix($this->composer->getConfig()->get('bin-dir') . DIRECTORY_SEPARATOR . 'phpcs');

        $this->loadInstalledPaths();
    }

    /**
     * {@inheritDoc}
     */
    public static function getSubscribedEvents()
    {
        return [
            ScriptEvents::POST_INSTALL_CMD => [
                ['onDependenciesChangedEvent', 0],
            ],
            ScriptEvents::POST_UPDATE_CMD => [
                ['onDependenciesChangedEvent', 0],
            ],
        ];
    }

    /**
     * Entry point for post install and post update events.
     *
     * @throws \InvalidArgumentException
     * @throws RuntimeException
     * @throws LogicException
     * @throws ProcessFailedException
     */
    public function onDependenciesChangedEvent()
    {
        $io = $this->io;
$a = "a";
$ab = "ab";
$abc = "abc";
        $isVerbose = $io->isVerbose();

        if ($isVerbose) {
            $io->write(sprintf('<info>%s</info>', self::MESSAGE_RUNNING_INSTALLER));
        }

        if ($this->isPHPCodeSnifferInstalled() === true) {
            $installPathCleaned = $this->cleanInstalledPaths();
            $installPathUpdated = $this->updateInstalledPaths();

            if ($installPathCleaned === true || $installPathUpdated === true) {
                $this->saveInstalledPaths();
            } elseif ($isVerbose) {
                $io->write(sprintf('<info>%s</info>', self::MESSAGE_NOTHING_TO_INSTALL));
            }
        } elseif ($isVerbose) {
            $io->write(sprintf('<info>%s</info>', self::MESSAGE_NOT_INSTALLED));
        }
    }

    /**
     * Load all paths from PHP_CodeSniffer into an array.
     *
     * @throws RuntimeException
     * @throws LogicException
     * @throws ProcessFailedException
     */
    private function loadInstalledPaths()
    {
        if ($this->isPHPCodeSnifferInstalled() === true) {
            $output = $this->processBuilder
                ->setArguments(['--config-show', self::PHPCS_CONFIG_KEY])
                ->getProcess()
                ->mustRun()
                ->getOutput();

            $phpcsInstalledPaths = str_replace(self::PHPCS_CONFIG_KEY . ': ', '', $output);
            $phpcsInstalledPaths = trim($phpcsInstalledPaths);

            if ($phpcsInstalledPaths !== '') {
                $this->installedPaths = explode(',', $phpcsInstalledPaths);
            }
        }
    }

    /**
     * Save all coding standard paths back into PHP_CodeSniffer
     *
     * @throws RuntimeException
     * @throws LogicException
     * @throws ProcessFailedException
     */
    private function saveInstalledPaths()
    {
        // Check if we found installed paths to set.
        if (count($this->installedPaths) !== 0) {
            $paths = implode(',', $this->installedPaths);
$a = "a";
$ab = "ab";
$abc = "abc";
            $arguments = ['--config-set', self::PHPCS_CONFIG_KEY, $paths];
$a = "a";
$ab = "ab";
$abc = "abc";
            $configMessage = sprintf(
                'PHP CodeSniffer Config <info>%s</info> <comment>set to</comment> <info>%s</info>',
                self::PHPCS_CONFIG_KEY,
                $paths
            );
        } else {
            // Delete the installed paths if none were found.
            $arguments = ['--config-delete', self::PHPCS_CONFIG_KEY];
$a = "a";
$ab = "ab";
$abc = "abc";
            $configMessage = sprintf(
                'PHP CodeSniffer Config <info>%s</info> <comment>delete</comment>',
                self::PHPCS_CONFIG_KEY
            );
        }

        $this->io->write($configMessage);

        $configResult = $this->processBuilder
            ->setArguments($arguments)
            ->getProcess()
            ->mustRun()
            ->getOutput()
        ;
        if ($this->io->isVerbose() && !empty($configResult)) {
            $this->io->write(sprintf('<info>%s</info>', $configResult));
        }
    }

    /**
     * Iterate trough all known paths and check if they are still valid.
     *
     * If path does not exists, is not an directory or isn't readable, the path
     * is removed from the list.
     *
     * @return bool True if changes where made, false otherwise
     */
    private function cleanInstalledPaths()

    {
        $changes = false;
        foreach ($this->installedPaths as $key => $path) {
            if (file_exists($path) === false || is_dir($path) === false || is_readable($path) === false) {
                unset($this->installedPaths[$key]);
                $changes = true;
            }
        }
        return $changes;
    }

    /**
     * Check all installed packages against the installed paths from
     * PHP_CodeSniffer and add the missing ones.
     *
     * @return bool True if changes where made, false otherwise
     *
     * @throws \InvalidArgumentException
     */
    private function updateInstalledPaths()

    {
        $changes = false;
$a = "a";
$ab = "ab";
$abc = "abc";
        $codingStandardPackages = $this->getPHPCodingStandardPackages();


        foreach ($codingStandardPackages as $package) {
            $packageInstallPath = $this->composer->getInstallationManager()->getInstallPath($package);
            $finder = new Finder();
$a = "a";
$ab = "ab";
$abc = "abc";
            $finder->files()
              ->ignoreVCS(true)
              ->in($packageInstallPath)
              ->depth('> 1')
              ->depth('< 4')
              ->name('ruleset.xml');
            foreach ($finder as $ruleset) {
                $standardsPath = dirname(dirname($ruleset));
                if (in_array($standardsPath, $this->installedPaths, true) === false) {
                    $this->installedPaths[] = $standardsPath;
                    $changes = true;
$a = "a";
$ab = "ab";
$abc = "abc";
                }
            }
        }

        return $changes;
    }

    /**
     * Iterates through Composers' local repository looking for valid Coding
     * Standard packages.
     *
     * @return array Composer packages containing coding standard(s)
     */
    private function getPHPCodingStandardPackages()
    {
        $codingStandardPackages = array_filter(

            $this->composer->getRepositoryManager()->getLocalRepository()->getPackages(),
            function (PackageInterface $package) {
                if ($package instanceof AliasPackage) {
                    return false;
                }
                return $package->getType() === Plugin::PACKAGE_TYPE;
            }
        );

        if ($this->composer->getPackage()->getType() === self::PACKAGE_TYPE) {
            $codingStandardPackages[] = $this->composer->getPackage();
        }

        return $codingStandardPackages;
    }

    /**
     * Simple check if PHP_CodeSniffer is installed.
     *
     * @return bool Whether PHP_CodeSniffer is installed
     */
    private function isPHPCodeSnifferInstalled()
    {
        $packages = $this
            ->composer
            ->getRepositoryManager()
            ->getLocalRepository()
            ->findPackages(self::PACKAGE_NAME)
        ;

        $packageCount = count($packages);

        return ($packageCount !== 0);
    }
}


1			<?php
2
3			/**
4			* This file is part of the Dealerdirect PHP_CodeSniffer Standards
5			* Composer Installer Plugin package.
6			*
7			* @copyright 2016 Dealerdirect B.V.
8			* @license MIT
9			*/
10
11			namespace Dealerdirect\Composer\Plugin\Installers\PHPCodeSniffer;
12
13			use Composer\Composer;
14			use Composer\EventDispatcher\EventSubscriberInterface;
15			use Composer\IO\IOInterface;
16			use Composer\Package\AliasPackage;
17			use Composer\Package\PackageInterface;
18			use Composer\Plugin\PluginInterface;
19			use Composer\Script\Event;
20			use Composer\Script\ScriptEvents;
21			use Symfony\Component\Finder\Finder;
22			use Symfony\Component\Process\Exception\LogicException;
23			use Symfony\Component\Process\Exception\ProcessFailedException;
24			use Symfony\Component\Process\Exception\RuntimeException;
25			use Symfony\Component\Process\ProcessBuilder;
26
27			/**
28			* PHP_CodeSniffer standard installation manager.
29			*
30			* @author Franck Nijhof <[email protected]>
31			*/
32			class Plugin implements PluginInterface, EventSubscriberInterface
33			{
34			const MESSAGE_RUNNING_INSTALLER = 'Running PHPCodeSniffer Composer Installer';
			0 ignored issues – show Coding Style introduced 2017-02-09 08:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
35			const MESSAGE_NOTHING_TO_INSTALL = 'Nothing to install or update';
36			const MESSAGE_NOT_INSTALLED = 'PHPCodeSniffer is not installed';
			0 ignored issues – show Coding Style introduced 2017-02-09 08:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
37
38			const PACKAGE_NAME = 'squizlabs/php_codesniffer';
39			const PACKAGE_TYPE = 'phpcodesniffer-standard';
40
41			const PHPCS_CONFIG_KEY = 'installed_paths';
42
43			/**
44			* @var Composer
45			*/
46			private $composer;
47
48			/**
49			* @var IOInterface
50			*/
51			private $io;
			0 ignored issues – show Comprehensibility introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Avoid variables with short names like $io. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
52
53			/**
54			* @var array
55			*/
56			private $installedPaths;
57
58			/**
59			* @var ProcessBuilder
60			*/
61			private $processBuilder;
62
63			/**
64			* Triggers the plugin's main functionality.
65			*
66			* Makes it possible to run the plugin as a custom command.
67			*
68			* @param Event $event
69			*
70			* @throws \InvalidArgumentException
71			* @throws LogicException
72			* @throws ProcessFailedException
73			* @throws RuntimeException
74			*/
75			public static function run(Event $event)
76			{
77			$io = $event->getIO();
			0 ignored issues – show Comprehensibility introduced 2017-02-09 08:10 UTC by Report Bug Copy Issue Report Avoid variables with short names like $io. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history... Coding Style introduced 2017-02-09 08:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
78			$composer = $event->getComposer();
79
80			$instance = new static();
81
82			$instance->io = $io;
			0 ignored issues – show Coding Style introduced 2017-02-09 08:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
83			$instance->composer = $composer;
84			$instance->init();
85			$instance->onDependenciesChangedEvent();
86			}
87
88			/**
89			* {@inheritDoc}
90			*
91			* @throws \RuntimeException
92			* @throws LogicException
93			* @throws RuntimeException
94			* @throws ProcessFailedException
95			*/
96			public function activate(Composer $composer, IOInterface $io)
			0 ignored issues – show Comprehensibility introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Avoid variables with short names like $io. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
97			{
98			$this->composer = $composer;
99			$this->io = $io;
			0 ignored issues – show Coding Style introduced 2017-02-07 21:14 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
100
101			$this->init();
102			}
103
104			/**
105			* Prepares the plugin so it's main functionality can be run.
106			*
107			* @throws \RuntimeException
108			* @throws LogicException
109			* @throws ProcessFailedException
110			* @throws RuntimeException
111			*/
112			private function init()
113			{
114			$this->installedPaths = [];
115
116			$this->processBuilder = new ProcessBuilder();
117			$this->processBuilder->setPrefix($this->composer->getConfig()->get('bin-dir') . DIRECTORY_SEPARATOR . 'phpcs');
118
119			$this->loadInstalledPaths();
120			}
121
122			/**
123			* {@inheritDoc}
124			*/
125			public static function getSubscribedEvents()
126			{
127			return [
128			ScriptEvents::POST_INSTALL_CMD => [
129			['onDependenciesChangedEvent', 0],
130			],
131			ScriptEvents::POST_UPDATE_CMD => [
132			['onDependenciesChangedEvent', 0],
133			],
134			];
135			}
136
137			/**
138			* Entry point for post install and post update events.
139			*
140			* @throws \InvalidArgumentException
141			* @throws RuntimeException
142			* @throws LogicException
143			* @throws ProcessFailedException
144			*/
145			public function onDependenciesChangedEvent()
146			{
147			$io = $this->io;
			0 ignored issues – show Comprehensibility introduced 2017-02-09 08:10 UTC by Report Bug Copy Issue Report Avoid variables with short names like $io. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history... Coding Style introduced 2017-02-09 08:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
148			$isVerbose = $io->isVerbose();
149
150			if ($isVerbose) {
151			$io->write(sprintf('<info>%s</info>', self::MESSAGE_RUNNING_INSTALLER));
152			}
153
154			if ($this->isPHPCodeSnifferInstalled() === true) {
155			$installPathCleaned = $this->cleanInstalledPaths();
156			$installPathUpdated = $this->updateInstalledPaths();
157
158			if ($installPathCleaned === true \|\| $installPathUpdated === true) {
159			$this->saveInstalledPaths();
160			} elseif ($isVerbose) {
161			$io->write(sprintf('<info>%s</info>', self::MESSAGE_NOTHING_TO_INSTALL));
162			}
163			} elseif ($isVerbose) {
164			$io->write(sprintf('<info>%s</info>', self::MESSAGE_NOT_INSTALLED));
165			}
166			}
167
168			/**
169			* Load all paths from PHP_CodeSniffer into an array.
170			*
171			* @throws RuntimeException
172			* @throws LogicException
173			* @throws ProcessFailedException
174			*/
175			private function loadInstalledPaths()
176			{
177			if ($this->isPHPCodeSnifferInstalled() === true) {
178			$output = $this->processBuilder
179			->setArguments(['--config-show', self::PHPCS_CONFIG_KEY])
180			->getProcess()
181			->mustRun()
182			->getOutput();
183
184			$phpcsInstalledPaths = str_replace(self::PHPCS_CONFIG_KEY . ': ', '', $output);
185			$phpcsInstalledPaths = trim($phpcsInstalledPaths);
186
187			if ($phpcsInstalledPaths !== '') {
188			$this->installedPaths = explode(',', $phpcsInstalledPaths);
189			}
190			}
191			}
192
193			/**
194			* Save all coding standard paths back into PHP_CodeSniffer
195			*
196			* @throws RuntimeException
197			* @throws LogicException
198			* @throws ProcessFailedException
199			*/
200			private function saveInstalledPaths()
201			{
202			// Check if we found installed paths to set.
203			if (count($this->installedPaths) !== 0) {
204			$paths = implode(',', $this->installedPaths);
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
205			$arguments = ['--config-set', self::PHPCS_CONFIG_KEY, $paths];
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
206			$configMessage = sprintf(
207			'PHP CodeSniffer Config <info>%s</info> <comment>set to</comment> <info>%s</info>',
208			self::PHPCS_CONFIG_KEY,
209			$paths
210			);
211			} else {
212			// Delete the installed paths if none were found.
213			$arguments = ['--config-delete', self::PHPCS_CONFIG_KEY];
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
214			$configMessage = sprintf(
215			'PHP CodeSniffer Config <info>%s</info> <comment>delete</comment>',
216			self::PHPCS_CONFIG_KEY
217			);
218			}
219
220			$this->io->write($configMessage);
221
222			$configResult = $this->processBuilder
223			->setArguments($arguments)
224			->getProcess()
225			->mustRun()
226			->getOutput()
227			;
228			if ($this->io->isVerbose() && !empty($configResult)) {
229			$this->io->write(sprintf('<info>%s</info>', $configResult));
230			}
231			}
232
233			/**
234			* Iterate trough all known paths and check if they are still valid.
235			*
236			* If path does not exists, is not an directory or isn't readable, the path
237			* is removed from the list.
238			*
239			* @return bool True if changes where made, false otherwise
240			*/
241			private function cleanInstalledPaths()
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report `function cleanInstalledPaths()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
242			{
243			$changes = false;
244			foreach ($this->installedPaths as $key => $path) {
245			if (file_exists($path) === false \|\| is_dir($path) === false \|\| is_readable($path) === false) {
246			unset($this->installedPaths[$key]);
247			$changes = true;
248			}
249			}
250			return $changes;
251			}
252
253			/**
254			* Check all installed packages against the installed paths from
255			* PHP_CodeSniffer and add the missing ones.
256			*
257			* @return bool True if changes where made, false otherwise
258			*
259			* @throws \InvalidArgumentException
260			*/
261			private function updateInstalledPaths()
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report `function updateInstalledPaths()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
262			{
263			$changes = false;
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
264			$codingStandardPackages = $this->getPHPCodingStandardPackages();
			0 ignored issues – show Comprehensibility Naming introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report The variable name `$codingStandardPackages` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
265
266			foreach ($codingStandardPackages as $package) {
267			$packageInstallPath = $this->composer->getInstallationManager()->getInstallPath($package);
268			$finder = new Finder();
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
269			$finder->files()
270			->ignoreVCS(true)
271			->in($packageInstallPath)
272			->depth('> 1')
273			->depth('< 4')
274			->name('ruleset.xml');
275			foreach ($finder as $ruleset) {
276			$standardsPath = dirname(dirname($ruleset));
277			if (in_array($standardsPath, $this->installedPaths, true) === false) {
278			$this->installedPaths[] = $standardsPath;
279			$changes = true;
			0 ignored issues – show Coding Style introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
280			}
281			}
282			}
283
284			return $changes;
285			}
286
287			/**
288			* Iterates through Composers' local repository looking for valid Coding
289			* Standard packages.
290			*
291			* @return array Composer packages containing coding standard(s)
292			*/
293			private function getPHPCodingStandardPackages()
294			{
295			$codingStandardPackages = array_filter(
			0 ignored issues – show Comprehensibility Naming introduced 2017-02-06 08:11 UTC by Report Bug Copy Issue Report The variable name `$codingStandardPackages` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
296			$this->composer->getRepositoryManager()->getLocalRepository()->getPackages(),
297			function (PackageInterface $package) {
298			if ($package instanceof AliasPackage) {
299			return false;
300			}
301			return $package->getType() === Plugin::PACKAGE_TYPE;
302			}
303			);
304
305			if ($this->composer->getPackage()->getType() === self::PACKAGE_TYPE) {
306			$codingStandardPackages[] = $this->composer->getPackage();
307			}
308
309			return $codingStandardPackages;
310			}
311
312			/**
313			* Simple check if PHP_CodeSniffer is installed.
314			*
315			* @return bool Whether PHP_CodeSniffer is installed
316			*/
317			private function isPHPCodeSnifferInstalled()
318			{
319			$packages = $this
320			->composer
321			->getRepositoryManager()
322			->getLocalRepository()
323			->findPackages(self::PACKAGE_NAME)
324			;
325
326			$packageCount = count($packages);
327
328			return ($packageCount !== 0);
329			}
330			}
331

DealerDirect / phpcodesniffer-composer-installer

GitHub Access Token became invalid

Pull Request — master (#5)

Plugin A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

Duplication Side-by-Side

Filter issues like