DeGraciaMathieu\Clike\Tests\CircuitBreakerTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	process_with_break()	0	20	1
A	process_without_break()	0	13	1
A	makeBreaker()	0	4	1
A	makeBreakerWithCustomException()	0	8	1

<?php

namespace DeGraciaMathieu\Clike\Tests;

use Exception;
use PHPUnit\Framework\TestCase;
use DeGraciaMathieu\EasyBreaker\Breaker;
use DeGraciaMathieu\EasyBreaker\CircuitBreaker;

class CircuitBreakerTest extends TestCase 
{
    /** 
     * @test
     */
    public function process_with_break()
    {
        $firstBreaker = $this->makeBreaker($message = "it's realy broken.", $exception = Exception::class);

The call to CircuitBreakerTest::makeBreaker() has too many arguments starting with $exception = \Exception::class.

        $secondBreaker = $this->makeBreakerWithCustomException($customMessage = "it's realy broken.", CustomException::class);
        $thirdBreaker = $this->makeBreaker($message = "it's realy realy broken.", $exception = Exception::class);

The call to CircuitBreakerTest::makeBreaker() has too many arguments starting with $exception = \Exception::class.

        $results = (new CircuitBreaker())
            ->addBreaker($firstBreaker)
            ->addBreaker($secondBreaker)
            ->addBreaker($thirdBreaker)
            ->closure(function(){
                throw new Exception();
            });


        $this->assertNotNull($results);        
        $this->assertEquals(2, count($results)); 
        $this->assertEquals($results[0], "it's realy broken."); 
        $this->assertEquals($results[1], "it's realy realy broken."); 
    }

    /** 
     * @test
     */
    public function process_without_break()
    {
        $firstBreaker = $this->makeBreaker($message = "it's realy broken.", $exception = Exception::class);

The call to CircuitBreakerTest::makeBreaker() has too many arguments starting with $exception = \Exception::class.

        $results = (new CircuitBreaker())
            ->addBreaker($firstBreaker)
            ->closure(function(){
                return;
            });


        $this->assertnull($results);        
    }

    /**
     * @param  strng $message
     * @return \DeGraciaMathieu\EasyBreaker\Breaker
     */
    protected function makeBreaker(string $message) :Breaker
    {
        return $this->makeBreakerWithCustomException($message, Exception::class);
    }

    /**
     * @param  string $message
     * @param  string $exception
     * @return \DeGraciaMathieu\EasyBreaker\Breaker
     */
    protected function makeBreakerWithCustomException(string $message, string $exception) :Breaker
    {
        return (new Breaker)
            ->when($exception)
            ->do(function(Exception $e) use($message) {

The parameter $e is not used and could be removed.

                return $message;
            });
    }    
}