Test - Code Metrics - Inspection of "Déplacement de la méthode parse vers le Criteria" - DeGraciaMathieu/Riddler - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 541085...2b6d09 )

by DeGracia

created 2018-03-02 21:17 UTC

Test B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	247
Duplicated Lines	34.01 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes

Metric	Value
dl	84
loc	247
c	0
b	0
f	0
wmc	16
lcom	1
cbo	16
rs	8.4614

15 Methods

Rating	Name	Duplication	Size	Complexity
A	emptyPassword()	0	8	1
A	letterPasswordOnly()	12	12	1
A	alphanumericPasswordOnly()	0	16	1
A	accentedLetterOnly()	16	16	1
A	accentedUppercaseLetterOnly()	16	16	1
A	specialCharacterOnly()	0	20	1
A	longDigitFormatOnly()	0	12	1
A	smallAlphanumericFormatOnly()	14	14	1
A	strongAlphanumericFormatOnly()	14	14	1
A	mixedStrongFormatOnly()	0	14	1
A	mixedComplexFormatOnly()	0	14	1
A	digitPasswordOnly()	12	12	1
A	strictOccurrences()	0	17	1
A	betweenOccurrences()	0	16	2
A	perfectScore()	0	13	1

How to fix Duplicated Code

<?php

use DeGraciaMathieu\Riddler\Formats;
use DeGraciaMathieu\Riddler\Criteria;
use DeGraciaMathieu\Riddler\Password;
use DeGraciaMathieu\Riddler\Occurrences;
use DeGraciaMathieu\Riddler\Dictionaries;

class Test extends \PHPUnit\Framework\TestCase
namespace YourVendor;

class YourClass { }
{
    /** @test */
    public function emptyPassword()
    {
        $pw = new Password();

        $str = $pw->generate();

        $this->assertEmpty($str);
    }

    /** @test */
    public function letterPasswordOnly()

    {
        $pw = new Password();

        $pw->addCriteria(new Dictionaries\Letter(), new Occurrences\Strict(10));

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertRegExp('/[a-z]/', $str);
    }

    /** @test */
    public function alphanumericPasswordOnly()
    {
        $pw = new Password();

        $pw->addCriteria(new Dictionaries\Letter(), new Occurrences\Strict(5));
        $pw->addCriteria(new Dictionaries\UppercaseLetter(), new Occurrences\Strict(5));
        $pw->addCriteria(new Dictionaries\Digit(), new Occurrences\Strict(5));

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertEquals(15, mb_strlen($str));

        $this->assertRegExp('/[a-zA-Z0-9]/', $str);
    }

    /** @test */
    public function accentedLetterOnly()

    {
        $pw = new Password();

        $accentedLetter = new Dictionaries\AccentedLetter();

        $pw->addCriteria($accentedLetter, new Occurrences\Strict(5));

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertEquals(5, mb_strlen($str));

        $this->assertRegExp('/[' . implode($accentedLetter->handle()) . ']{5}/', $str);
    }

    /** @test */
    public function accentedUppercaseLetterOnly()

    {
        $pw = new Password();

        $accentedUppercaseLetter = new Dictionaries\AccentedUppercaseLetter();

        $pw->addCriteria($accentedUppercaseLetter, new Occurrences\Strict(5));

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertEquals(5, mb_strlen($str));

        $this->assertRegExp('/[' . implode($accentedUppercaseLetter->handle()) . ']{5}/', $str);
    }

    /** @test */
    public function specialCharacterOnly()
    {
        $pw = new Password();

        $specialCharacter = new Dictionaries\SpecialCharacter();

        $pw->addCriteria($specialCharacter, new Occurrences\Strict(5));

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertEquals(5, mb_strlen($str));

        $chars = array_map(function ($c) {
            return '\\' . $c;
        }, $specialCharacter->handle());

        $this->assertRegExp('/[' . implode($chars) . ']{5}/', $str);
    }

    /** @test */
    public function longDigitFormatOnly()
    {
        $pw = new Password();

        $pw->addFormat(new Formats\LongDigit());

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertRegExp('/\d{30}/', $str);
    }

    /** @test */
    public function smallAlphanumericFormatOnly()

    {
        $pw = new Password();

        $pw->addFormat(new Formats\SmallAlphanumeric());

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertEquals(15, mb_strlen($str));

        $this->assertRegExp('/[a-zA-Z0-9]/', $str);
    }

    /** @test */
    public function strongAlphanumericFormatOnly()

    {
        $pw = new Password();

        $pw->addFormat(new Formats\StrongAlphanumeric());

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertEquals(30, mb_strlen($str));

        $this->assertRegExp('/[a-zA-Z0-9]/', $str);
    }

    /** @test */
    public function mixedStrongFormatOnly()
    {
        $pw = new Password();

        $pw->addFormat(new Formats\MixedStrong());

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        // $this->assertEquals(30, mb_strlen($str));


        // $this->assertRegExp('/[a-zA-Z0-9]/', $str);

    }

    /** @test */
    public function mixedComplexFormatOnly()
    {
        $pw = new Password();

        $pw->addFormat(new Formats\MixedComplex());

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        // $this->assertEquals(30, mb_strlen($str));


        // $this->assertRegExp('/[a-zA-Z0-9]/', $str);

    }


    /** @test */
    public function digitPasswordOnly()

    {
        $pw = new Password();

        $pw->addCriteria(new Dictionaries\Digit(), new Occurrences\Strict(10));

        $str = $pw->generate();

        $this->assertNotEmpty($str);

        $this->assertRegExp('/\d{10}/', $str);
    }

    /** @test */
    public function strictOccurrences()
    {
        $dictionary = new Dictionaries\Letter();

        $occurrence = new Occurrences\Strict(5);

        $criteria = new Criteria($dictionary, $occurrence);

        $result = $criteria->build();

        $this->assertTrue(is_array($result));
        $this->assertEquals(5, count($result));
        $this->assertContains($result[0], $dictionary->handle());
        $this->assertContains($result[1], $dictionary->handle());
        $this->assertContains($result[2], $dictionary->handle());
        $this->assertContains($result[3], $dictionary->handle());
    }

    /** @test */
    public function betweenOccurrences()
    {
        $dictionary = new Dictionaries\Letter();

        $occurrence = new Occurrences\Between(3, 5);

        $criteria = new Criteria($dictionary, $occurrence);

        $result = $criteria->build();

        $this->assertTrue(is_array($result));
        $this->assertTrue(count($result) >= 3 && count($result) <= 5);
        $this->assertContains($result[0], $dictionary->handle());
        $this->assertContains($result[1], $dictionary->handle());
        $this->assertContains($result[2], $dictionary->handle());
    }

    /** @test */
    public function perfectScore()
    {
        $string = '1a4bcT@Y';

        $password = new Password();

        $password->addCriteria(new Dictionaries\Digit(), new Occurrences\Strict(2));
        $password->addCriteria(new Dictionaries\Letter(), new Occurrences\Strict(3));
        $password->addCriteria(new Dictionaries\UppercaseLetter(), new Occurrences\Strict(2));
        $password->addCriteria(new Dictionaries\SpecialCharacter(), new Occurrences\Strict(1));

        $this->assertEquals($password->score($string), 100);
    }
}


1		<?php
2
3		use DeGraciaMathieu\Riddler\Formats;
4		use DeGraciaMathieu\Riddler\Criteria;
5		use DeGraciaMathieu\Riddler\Password;
6		use DeGraciaMathieu\Riddler\Occurrences;
7		use DeGraciaMathieu\Riddler\Dictionaries;
8
9		class Test extends \PHPUnit\Framework\TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2018-01-09 09:50 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10		{
11		/** @test */
12		public function emptyPassword()
13		{
14		$pw = new Password();
15
16		$str = $pw->generate();
17
18		$this->assertEmpty($str);
19		}
20
21		/** @test */
22	View Code Duplication	public function letterPasswordOnly()
		1 ignored issue – show Duplication introduced 2018-01-10 20:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$pw = new Password();
25
26		$pw->addCriteria(new Dictionaries\Letter(), new Occurrences\Strict(10));
27
28		$str = $pw->generate();
29
30		$this->assertNotEmpty($str);
31
32		$this->assertRegExp('/[a-z]/', $str);
33		}
34
35		/** @test */
36		public function alphanumericPasswordOnly()
37		{
38		$pw = new Password();
39
40		$pw->addCriteria(new Dictionaries\Letter(), new Occurrences\Strict(5));
41		$pw->addCriteria(new Dictionaries\UppercaseLetter(), new Occurrences\Strict(5));
42		$pw->addCriteria(new Dictionaries\Digit(), new Occurrences\Strict(5));
43
44		$str = $pw->generate();
45
46		$this->assertNotEmpty($str);
47
48		$this->assertEquals(15, mb_strlen($str));
49
50		$this->assertRegExp('/[a-zA-Z0-9]/', $str);
51		}
52
53		/** @test */
54	View Code Duplication	public function accentedLetterOnly()
		1 ignored issue – show Duplication introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$pw = new Password();
57
58		$accentedLetter = new Dictionaries\AccentedLetter();
59
60		$pw->addCriteria($accentedLetter, new Occurrences\Strict(5));
61
62		$str = $pw->generate();
63
64		$this->assertNotEmpty($str);
65
66		$this->assertEquals(5, mb_strlen($str));
67
68		$this->assertRegExp('/[' . implode($accentedLetter->handle()) . ']{5}/', $str);
69		}
70
71		/** @test */
72	View Code Duplication	public function accentedUppercaseLetterOnly()
		1 ignored issue – show Duplication introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		{
74		$pw = new Password();
75
76		$accentedUppercaseLetter = new Dictionaries\AccentedUppercaseLetter();
77
78		$pw->addCriteria($accentedUppercaseLetter, new Occurrences\Strict(5));
79
80		$str = $pw->generate();
81
82		$this->assertNotEmpty($str);
83
84		$this->assertEquals(5, mb_strlen($str));
85
86		$this->assertRegExp('/[' . implode($accentedUppercaseLetter->handle()) . ']{5}/', $str);
87		}
88
89		/** @test */
90		public function specialCharacterOnly()
91		{
92		$pw = new Password();
93
94		$specialCharacter = new Dictionaries\SpecialCharacter();
95
96		$pw->addCriteria($specialCharacter, new Occurrences\Strict(5));
97
98		$str = $pw->generate();
99
100		$this->assertNotEmpty($str);
101
102		$this->assertEquals(5, mb_strlen($str));
103
104		$chars = array_map(function ($c) {
105		return '\\' . $c;
106		}, $specialCharacter->handle());
107
108		$this->assertRegExp('/[' . implode($chars) . ']{5}/', $str);
109		}
110
111		/** @test */
112		public function longDigitFormatOnly()
113		{
114		$pw = new Password();
115
116		$pw->addFormat(new Formats\LongDigit());
117
118		$str = $pw->generate();
119
120		$this->assertNotEmpty($str);
121
122		$this->assertRegExp('/\d{30}/', $str);
123		}
124
125		/** @test */
126	View Code Duplication	public function smallAlphanumericFormatOnly()
		1 ignored issue – show Duplication introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		{
128		$pw = new Password();
129
130		$pw->addFormat(new Formats\SmallAlphanumeric());
131
132		$str = $pw->generate();
133
134		$this->assertNotEmpty($str);
135
136		$this->assertEquals(15, mb_strlen($str));
137
138		$this->assertRegExp('/[a-zA-Z0-9]/', $str);
139		}
140
141		/** @test */
142	View Code Duplication	public function strongAlphanumericFormatOnly()
		1 ignored issue – show Duplication introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
143		{
144		$pw = new Password();
145
146		$pw->addFormat(new Formats\StrongAlphanumeric());
147
148		$str = $pw->generate();
149
150		$this->assertNotEmpty($str);
151
152		$this->assertEquals(30, mb_strlen($str));
153
154		$this->assertRegExp('/[a-zA-Z0-9]/', $str);
155		}
156
157		/** @test */
158		public function mixedStrongFormatOnly()
159		{
160		$pw = new Password();
161
162		$pw->addFormat(new Formats\MixedStrong());
163
164		$str = $pw->generate();
165
166		$this->assertNotEmpty($str);
167
168		// $this->assertEquals(30, mb_strlen($str));
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
169
170		// $this->assertRegExp('/[a-zA-Z0-9]/', $str);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
171		}
172
173		/** @test */
174		public function mixedComplexFormatOnly()
175		{
176		$pw = new Password();
177
178		$pw->addFormat(new Formats\MixedComplex());
179
180		$str = $pw->generate();
181
182		$this->assertNotEmpty($str);
183
184		// $this->assertEquals(30, mb_strlen($str));
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
185
186		// $this->assertRegExp('/[a-zA-Z0-9]/', $str);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-11 12:34 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
187		}
188
189
190		/** @test */
191	View Code Duplication	public function digitPasswordOnly()
		1 ignored issue – show Duplication introduced 2018-01-10 20:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
192		{
193		$pw = new Password();
194
195		$pw->addCriteria(new Dictionaries\Digit(), new Occurrences\Strict(10));
196
197		$str = $pw->generate();
198
199		$this->assertNotEmpty($str);
200
201		$this->assertRegExp('/\d{10}/', $str);
202		}
203
204		/** @test */
205		public function strictOccurrences()
206		{
207		$dictionary = new Dictionaries\Letter();
208
209		$occurrence = new Occurrences\Strict(5);
210
211		$criteria = new Criteria($dictionary, $occurrence);
212
213		$result = $criteria->build();
214
215		$this->assertTrue(is_array($result));
216		$this->assertEquals(5, count($result));
217		$this->assertContains($result[0], $dictionary->handle());
218		$this->assertContains($result[1], $dictionary->handle());
219		$this->assertContains($result[2], $dictionary->handle());
220		$this->assertContains($result[3], $dictionary->handle());
221		}
222
223		/** @test */
224		public function betweenOccurrences()
225		{
226		$dictionary = new Dictionaries\Letter();
227
228		$occurrence = new Occurrences\Between(3, 5);
229
230		$criteria = new Criteria($dictionary, $occurrence);
231
232		$result = $criteria->build();
233
234		$this->assertTrue(is_array($result));
235		$this->assertTrue(count($result) >= 3 && count($result) <= 5);
236		$this->assertContains($result[0], $dictionary->handle());
237		$this->assertContains($result[1], $dictionary->handle());
238		$this->assertContains($result[2], $dictionary->handle());
239		}
240
241		/** @test */
242		public function perfectScore()
243		{
244		$string = '1a4bcT@Y';
245
246		$password = new Password();
247
248		$password->addCriteria(new Dictionaries\Digit(), new Occurrences\Strict(2));
249		$password->addCriteria(new Dictionaries\Letter(), new Occurrences\Strict(3));
250		$password->addCriteria(new Dictionaries\UppercaseLetter(), new Occurrences\Strict(2));
251		$password->addCriteria(new Dictionaries\SpecialCharacter(), new Occurrences\Strict(1));
252
253		$this->assertEquals($password->score($string), 100);
254		}
255		}
256

DeGraciaMathieu / Riddler

Push — master ( 541085...2b6d09 )

Test B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like