None - Code Metrics - DeGraciaMathieu/Riddler - Measure and Improve Code Quality continuously with Scrutinizer

None A
last analyzed 2020-08-24 15:31 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	28
c	0
b	0
f	0
wmc	3
lcom	0
cbo	0
ccs	6
cts	6
cp	1
rs	10

3 Methods

Rating	Name	Size	Complexity
A	size()	4	1
A	validate()	4	1
A	getName()	4	1

<?php

namespace DeGraciaMathieu\Riddler\Occurrences;

use DeGraciaMathieu\Riddler\Contracts\Occurrence;

class None implements Occurrence
{
    /**
     * Retourne la taille de l'occurence
     *
     * @return integer
     */
    public function size()
    {
        return 0;
    }

    /**
     * Valide la range de l'occurence
     *
     * @param integer $value
     * @return integer
     */
    public function validate($value)
    {
        return (int) $value === 0;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getName()
    {
        return 'none';
    }
}


1		<?php
2
3		namespace DeGraciaMathieu\Riddler\Occurrences;
4
5		use DeGraciaMathieu\Riddler\Contracts\Occurrence;
6
7		class None implements Occurrence
8		{
9		/**
10		* Retourne la taille de l'occurence
11		*
12		* @return integer
13		*/
14	1	public function size()
15		{
16	1	return 0;
17		}
18
19		/**
20		* Valide la range de l'occurence
21		*
22		* @param integer $value
23		* @return integer
24		*/
25	2	public function validate($value)
26		{
27	2	return (int) $value === 0;
		0 ignored issues – show Bug Best Practice introduced 2018-03-28 10:50 UTC by Report Bug Copy Issue Report The return type of `return (int) $value === 0;` (`boolean`) is incompatible with the return type declared by the interface `DeGraciaMathieu\Riddler\...ts\Occurrence::validate` of type `integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
28		}
29
30	4	public function getName()
31		{
32	4	return 'none';
33		}
34		}
35

DeGraciaMathieu / Riddler

None A last analyzed 2020-08-24 15:31 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

None A
last analyzed 2020-08-24 15:31 UTC