CommandIntegration::success() - Code Metrics - Inspection of "Improve integration tests" - DeGraciaMathieu/Clike - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 029dc1...fbc89f )

by DeGracia

created 2018-07-12 21:43 UTC

CommandIntegration::success() A

↳ Parent: CommandIntegration

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	16
Ratio	100 %

Importance

Changes

Metric	Value
dl	16
loc	16
rs	9.7333
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace DeGraciaMathieu\Clike\Tests;

use Mockery;
use PHPUnit\Framework\TestCase;
use DeGraciaMathieu\Clike\Command;

class CommandIntegration extends TestCase {
    
    /** @test */
    public function success()

    {
        $command = new Command();

        $result = $command->execute(new Clear());

        $expectedArray = [
            [
                'type' => 'info',
                'content' => 'Output text...',
            ]
        ];

        $this->assertNotNull($result['timestamp']);        
        $this->assertEquals($result['lines'], $expectedArray);        
    }

    /** @test */
    public function unauthorized()
    {
        $command = new Command();

        $clear = Mockery::mock(new Clear())->makePartial();

        $clear->shouldReceive('authorized')->andReturn(false);        

        $result = $command->execute($clear);

        $expectedArray = [
            [
                'type' => 'error',
                'content' => '/clear is an unauthorized command.',
            ]
        ];

        $this->assertNotNull($result['timestamp']);
        $this->assertEquals($result['lines'], $expectedArray);  
    }         
}


1		<?php
2
3		namespace DeGraciaMathieu\Clike\Tests;
4
5		use Mockery;
6		use PHPUnit\Framework\TestCase;
7		use DeGraciaMathieu\Clike\Command;
8
9		class CommandIntegration extends TestCase {
10
11		/** @test */
12	View Code Duplication	public function success()
		0 ignored issues – show Duplication introduced 2018-07-12 21:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		$command = new Command();
15
16		$result = $command->execute(new Clear());
17
18		$expectedArray = [
19		[
20		'type' => 'info',
21		'content' => 'Output text...',
22		]
23		];
24
25		$this->assertNotNull($result['timestamp']);
26		$this->assertEquals($result['lines'], $expectedArray);
27		}
28
29		/** @test */
30		public function unauthorized()
31		{
32		$command = new Command();
33
34		$clear = Mockery::mock(new Clear())->makePartial();
35
36		$clear->shouldReceive('authorized')->andReturn(false);
37
38		$result = $command->execute($clear);
39
40		$expectedArray = [
41		[
42		'type' => 'error',
43		'content' => '/clear is an unauthorized command.',
44		]
45		];
46
47		$this->assertNotNull($result['timestamp']);
48		$this->assertEquals($result['lines'], $expectedArray);
49		}
50		}
51

DeGraciaMathieu / Clike

Push — master ( 029dc1...fbc89f )

CommandIntegration::success() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like