Terminal::retrieveCommand() - Code Metrics - Inspection of "Improve integration tests" - DeGraciaMathieu/Clike - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 029dc1...fbc89f )

by DeGracia

created 2018-07-12 21:43 UTC

Terminal::retrieveCommand() A

↳ Parent: Terminal

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	3
cts	3
cp	1
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

namespace DeGraciaMathieu\Clike;

class Terminal {

    /**
     * @param array $availableCommands
     */
    public function __construct(array $availableCommands)
    {
        $this->availableCommands = $availableCommands;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * try to launch a command class from a command line
     * @param  string $commandLine
     * @throws \DeGraciaMathieu\Clike\Exceptions\UnknowCommand
     * @return array
     */
    public function execute(string $commandLine) :array
    {
        $command = $this->retrieveCommand($commandLine);

        return (new Command)->execute($command);
    }

    /**
     * Make Command class from binding
     * @param  string $binding
     * @throws \DeGraciaMathieu\Clike\Exceptions\UnknowCommand
     * @return \DeGraciaMathieu\Clike\Contracts\Command
     */
    protected function retrieveCommand(string $binding) :Contracts\Command
    {
        $command = array_filter($this->availableCommands, function($availableCommand) use($binding) {
            return (new $availableCommand)->binding() === $binding;
        });

        if (! $command[0]) {
            throw new Exceptions\UnknowCommand();
        }

        return new $command[0];
    }
}


1		<?php
2
3		namespace DeGraciaMathieu\Clike;
4
5		class Terminal {
6
7		/**
8		* @param array $availableCommands
9		*/
10	2	public function __construct(array $availableCommands)
11		{
12	2	$this->availableCommands = $availableCommands;
		0 ignored issues – show Bug introduced 2018-07-12 21:14 UTC by Report Bug Copy Issue Report The property `availableCommands` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13	2	}
14
15		/**
16		* try to launch a command class from a command line
17		* @param string $commandLine
18		* @throws \DeGraciaMathieu\Clike\Exceptions\UnknowCommand
19		* @return array
20		*/
21	2	public function execute(string $commandLine) :array
22		{
23	2	$command = $this->retrieveCommand($commandLine);
24
25	1	return (new Command)->execute($command);
26		}
27
28		/**
29		* Make Command class from binding
30		* @param string $binding
31		* @throws \DeGraciaMathieu\Clike\Exceptions\UnknowCommand
32		* @return \DeGraciaMathieu\Clike\Contracts\Command
33		*/
34		protected function retrieveCommand(string $binding) :Contracts\Command
35		{
36	2	$command = array_filter($this->availableCommands, function($availableCommand) use($binding) {
37	2	return (new $availableCommand)->binding() === $binding;
38	2	});
39
40		if (! $command[0]) {
41		throw new Exceptions\UnknowCommand();
42		}
43
44		return new $command[0];
45		}
46		}
47

DeGraciaMathieu / Clike

Push — master ( 029dc1...fbc89f )

Terminal::retrieveCommand() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like