DavidePastore\CodiceFiscaleRest\CodiceFiscaleControllerProvider

Complexity

Total Complexity

7

Size/Duplication

Total Lines	155
Duplicated Lines	15.48 %

Coupling/Cohesion

Components	0
Dependencies	8

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	connect()	24	133	5
A	generateResponseFromErrors()	0	13	2

<?php
namespace DavidePastore\CodiceFiscaleRest;

use DavidePastore\CodiceFiscale\Calculator;
use DavidePastore\CodiceFiscale\Checker;
use DavidePastore\CodiceFiscale\Subject;
use Silex\Application;
use Silex\ControllerProviderInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\PropertyAccess\PropertyAccess;
use Symfony\Component\Validator\Constraints as Assert;


class CodiceFiscaleControllerProvider implements ControllerProviderInterface
{
    public function connect(Application $app)
    {
        $api = $app['controllers_factory'];

        //Calculate the codice fiscale by the given parameters.
        $api->get('/calculate', function (Application $app, Request $request) {
            $constraint = new Assert\Collection(array(
                'name' => $app['codice-fiscale-rest.constraints']['name'],
                'surname' => $app['codice-fiscale-rest.constraints']['surname'],
                'gender' => $app['codice-fiscale-rest.constraints']['gender'],
                'birthDate' => $app['codice-fiscale-rest.constraints']['birthDate'],
                'belfioreCode' => $app['codice-fiscale-rest.constraints']['belfioreCode'],
                'omocodiaLevel' => $app['codice-fiscale-rest.constraints']['omocodiaLevel']
            ));
            
            $data = array(
                'name' => $request->get('name', ''),
                'surname' => $request->get('surname', ''),
                'gender' => $request->get('gender', ''),
                'birthDate' => $request->get('birthDate', ''),
                'belfioreCode' => $request->get('belfioreCode', ''),
                'omocodiaLevel' => $request->get('omocodiaLevel', 0),
            );
            
            $errors = $app['validator']->validate($data, $constraint);
            $response = new \stdClass;
            
            if (count($errors) > 0) {

This code seems to be duplicated across your project.

                $response = $this->generateResponseFromErrors($errors);
            } else {
                $subject = new Subject($data);

                $calculator = new Calculator($subject, array(
                    'omocodiaLevel' => $data['omocodiaLevel']
                ));
                $codiceFiscale = $calculator->calculate();
                
                $response->status = true;
                $response->codiceFiscale = $codiceFiscale;
            }
            return new JsonResponse($response);
        })
        ->bind('apiCalculate');


        //Calculate all the codice fiscale by the given parameters.
        $api->get('/calculateAll', function (Application $app, Request $request) {
            $constraint = new Assert\Collection(array(
                'name' => $app['codice-fiscale-rest.constraints']['name'],
                'surname' => $app['codice-fiscale-rest.constraints']['surname'],
                'gender' => $app['codice-fiscale-rest.constraints']['gender'],
                'birthDate' => $app['codice-fiscale-rest.constraints']['birthDate'],
                'belfioreCode' => $app['codice-fiscale-rest.constraints']['belfioreCode']
            ));
            
            $data = array(
                'name' => $request->get('name', ''),
                'surname' => $request->get('surname', ''),
                'gender' => $request->get('gender', ''),
                'birthDate' => $request->get('birthDate', ''),
                'belfioreCode' => $request->get('belfioreCode', '')
            );
            
            $errors = $app['validator']->validate($data, $constraint);
            $response = new \stdClass;
            
            if (count($errors) > 0) {

This code seems to be duplicated across your project.

                $response = $this->generateResponseFromErrors($errors);
            } else {
                $subject = new Subject($data);

                $calculator = new Calculator($subject);
                $codiciFiscali = $calculator->calculateAllPossibilities();
                
                $response->status = true;
                $response->codiciFiscali = $codiciFiscali;
            }
            
            return new JsonResponse($response);
        })
        ->bind('apiCalculateAll');

        //Check if the given parameters are ok for the given parameters.
        $api->get('/check', function (Application $app, Request $request) {
            $constraint = new Assert\Collection(array(
                'name' => $app['codice-fiscale-rest.constraints']['name'],
                'surname' => $app['codice-fiscale-rest.constraints']['surname'],
                'gender' => $app['codice-fiscale-rest.constraints']['gender'],
                'birthDate' => $app['codice-fiscale-rest.constraints']['birthDate'],
                'belfioreCode' => $app['codice-fiscale-rest.constraints']['belfioreCode'],
                'codiceFiscale' => $app['codice-fiscale-rest.constraints']['codiceFiscale'],
                'omocodiaLevel' => $app['codice-fiscale-rest.constraints']['omocodiaLevel'],
            ));
            
            $data = array(
                'name' => $request->get('name', ''),
                'surname' => $request->get('surname', ''),
                'gender' => $request->get('gender', ''),
                'birthDate' => $request->get('birthDate', ''),
                'belfioreCode' => $request->get('belfioreCode', ''),
                'codiceFiscale' => $request->get('codiceFiscale', ''),
                'omocodiaLevel' => $request->get('omocodiaLevel', Checker::ALL_OMOCODIA_LEVELS)
            );
            
            $errors = $app['validator']->validate($data, $constraint);
            $response = new \stdClass;
            
            if (count($errors) > 0) {
                $response = $this->generateResponseFromErrors($errors);
            } else {
                $subject = new Subject($data);
                
                $checker = new Checker($subject, array(
                  'codiceFiscaleToCheck' => $data['codiceFiscale'],
                  'omocodiaLevel' => $data['omocodiaLevel']
                ));
                
                if ($checker->check()) {
                    $response->status = true;
                    $response->message = 'Valid codice fiscale';
                }
                else {
                    $response->status = false;
                    $response->message = 'Invalid codice fiscale';
                }
            }
            
            return new JsonResponse($response);
        })
        ->bind('apiCheck');
        
        return $api;
    }
    
    /**
     * Generate response from the given ConstraintViolationList.
     * @param $errors The ConstraintViolationList instance.
     * @return Returns the response from the given errors.
     */
    private function generateResponseFromErrors(\Symfony\Component\Validator\ConstraintViolationList $errors){
        $response = new \stdclass;
        $response->status = false;
        $accessor = PropertyAccess::createPropertyAccessor();
        $responseErrors = array();
        
        foreach ($errors as $error) {
            $accessor->setValue($responseErrors, $error->getPropertyPath(), $error->getMessage());
        }
        
        $response->errors = $responseErrors;
        return $response;
    }
}