FrameAddress::__construct() - Code Metrics - Inspection of "Improve and simplify int validation" - DaveRandom/LibLifxLan - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0d7a8a...2e892a )

by Chris

created 2018-01-05 13:23 UTC

FrameAddress::__construct() A

↳ Parent: FrameAddress

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	4
dl	0
loc	6
ccs	5
cts	5
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace DaveRandom\LibLifxLan\Header;

use DaveRandom\LibLifxLan\Exceptions\InvalidValueException;
use DaveRandom\Network\MacAddress;
use function DaveRandom\LibLifxLan\validate_uint8;

final class FrameAddress
{
    public const WIRE_SIZE = 16;

    private $target;
    private $ackRequired;
    private $responseRequired;
    private $sequenceNo;

    /**
     * @param MacAddress $target
     * @param bool $ackRequired
     * @param bool $responseRequired
     * @param int $sequenceNo
     * @throws InvalidValueException
     */
    public function __construct(MacAddress $target, bool $ackRequired, bool $responseRequired, int $sequenceNo)
    {
        $this->target = $target;
        $this->ackRequired = $ackRequired;
        $this->responseRequired = $responseRequired;
        $this->sequenceNo = validate_uint8('Sequence number', $sequenceNo);
    }

    public function getTarget(): MacAddress
    {
        return $this->target;
    }

    public function isAckRequired(): bool
    {
        return $this->ackRequired;
    }

    public function isResponseRequired(): bool
    {
        return $this->responseRequired;
    }

    public function getSequenceNo(): int
    {
        return $this->sequenceNo;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace DaveRandom\LibLifxLan\Header;
4
5		use DaveRandom\LibLifxLan\Exceptions\InvalidValueException;
6		use DaveRandom\Network\MacAddress;
7		use function DaveRandom\LibLifxLan\validate_uint8;
8
9		final class FrameAddress
10		{
11		public const WIRE_SIZE = 16;
12
13		private $target;
14		private $ackRequired;
15		private $responseRequired;
16		private $sequenceNo;
17
18		/**
19		* @param MacAddress $target
20		* @param bool $ackRequired
21		* @param bool $responseRequired
22		* @param int $sequenceNo
23		* @throws InvalidValueException
24		*/
25	38	public function __construct(MacAddress $target, bool $ackRequired, bool $responseRequired, int $sequenceNo)
26		{
27	38	$this->target = $target;
28	38	$this->ackRequired = $ackRequired;
29	38	$this->responseRequired = $responseRequired;
30	38	$this->sequenceNo = validate_uint8('Sequence number', $sequenceNo);
31		}
32
33	20	public function getTarget(): MacAddress
34		{
35	20	return $this->target;
36		}
37
38	19	public function isAckRequired(): bool
39		{
40	19	return $this->ackRequired;
41		}
42
43	19	public function isResponseRequired(): bool
44		{
45	19	return $this->responseRequired;
46		}
47
48	19	public function getSequenceNo(): int
49		{
50	19	return $this->sequenceNo;
51		}
52		}
53

DaveRandom / LibLifxLan

Push — master ( 0d7a8a...2e892a )

FrameAddress::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like