State::getPower() - Code Metrics - Inspection of "Use setter methods" - DaveRandom/LibLifxLan - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba407f...6dbf2d )

by Chris

created 2018-01-02 17:51 UTC

State::getPower() A

↳ Parent: State

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	0
cts	4
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace DaveRandom\LibLifxLan\DataTypes\Light;

use DaveRandom\LibLifxLan\DataTypes\Label;
use DaveRandom\LibLifxLan\Exceptions\InvalidValueException;

final class State
{
    private $color;
    private $power;
    private $label;

    private function setColor(HsbkColor $color): void
    {
        $this->color = $color;
    }

    /**
     * @param int $power
     * @throws InvalidValueException
     */
    private function setPower(int $power): void

    {
        if ($power < 0 || $power > 65535) {
            throw new InvalidValueException("Power level {$power} outside allowable range of 0 - 65535");
        }

        $this->power = $power;
    }

    private function setLabel(Label $label): void
    {
        $this->label = $label;
    }

    /**
     * @param HsbkColor $color
     * @param int $power
     * @param Label $label
     * @throws InvalidValueException
     */
    public function __construct(HsbkColor $color, int $power, Label $label)
    {
        $this->setColor($color);
        $this->setPower($power);
        $this->setLabel($label);
    }

    public function getColor(): HsbkColor
    {
        return $this->color;
    }

    public function getPower(): int
    {
        return $this->power;
    }

    public function getLabel(): Label
    {
        return $this->label;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace DaveRandom\LibLifxLan\DataTypes\Light;
4
5		use DaveRandom\LibLifxLan\DataTypes\Label;
6		use DaveRandom\LibLifxLan\Exceptions\InvalidValueException;
7
8		final class State
9		{
10		private $color;
11		private $power;
12		private $label;
13
14		private function setColor(HsbkColor $color): void
15		{
16		$this->color = $color;
17		}
18
19		/**
20		* @param int $power
21		* @throws InvalidValueException
22		*/
23	View Code Duplication	private function setPower(int $power): void
		1 ignored issue – show Duplication introduced 2018-01-02 17:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		{
25		if ($power < 0 \|\| $power > 65535) {
26		throw new InvalidValueException("Power level {$power} outside allowable range of 0 - 65535");
27		}
28
29		$this->power = $power;
30		}
31
32		private function setLabel(Label $label): void
33		{
34		$this->label = $label;
35		}
36
37		/**
38		* @param HsbkColor $color
39		* @param int $power
40		* @param Label $label
41		* @throws InvalidValueException
42		*/
43		public function __construct(HsbkColor $color, int $power, Label $label)
44		{
45		$this->setColor($color);
46		$this->setPower($power);
47		$this->setLabel($label);
48		}
49
50		public function getColor(): HsbkColor
51		{
52		return $this->color;
53		}
54
55		public function getPower(): int
56		{
57		return $this->power;
58		}
59
60		public function getLabel(): Label
61		{
62		return $this->label;
63		}
64		}
65

DaveRandom / LibLifxLan

Push — master ( ba407f...6dbf2d )

State::getPower() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like