PowerTransition::getLevel() - Code Metrics - Inspection of "Use setter methods" - DaveRandom/LibLifxLan - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba407f...6dbf2d )

by Chris

created 2018-01-02 17:51 UTC

PowerTransition::getLevel() A

↳ Parent: PowerTransition

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	0
cts	4
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace DaveRandom\LibLifxLan\DataTypes\Light;

use DaveRandom\LibLifxLan\Exceptions\InvalidValueException;
use const DaveRandom\LibLifxLan\UINT32_MAX;
use const DaveRandom\LibLifxLan\UINT32_MIN;

final class PowerTransition
{
    private $level;
    private $duration;

    /**
     * @param int $level
     * @throws InvalidValueException
     */
    private function setLevel(int $level): void

    {
        if ($level < 0 || $level > 65535) {
            throw new InvalidValueException("Power level {$level} outside allowable range of 0 - 65535");
        }

        $this->level = $level;
    }

    /**
     * @param int $duration
     * @throws InvalidValueException
     */
    private function setDuration(int $duration): void

    {
        if ($duration < UINT32_MIN || $duration > UINT32_MAX) {
            throw new InvalidValueException(
                "Transition duration {$duration} outside allowable range of " . UINT32_MIN . " - " . UINT32_MAX
            );
        }

        $this->duration = $duration;
    }

    /**
     * @param int $level
     * @param int $duration
     * @throws InvalidValueException
     */
    public function __construct(int $level, int $duration)
    {
        $this->setLevel($level);
        $this->setDuration($duration);
    }

    public function getLevel(): int
    {
        return $this->level;
    }

    public function getDuration(): int
    {
        return $this->duration;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace DaveRandom\LibLifxLan\DataTypes\Light;
4
5		use DaveRandom\LibLifxLan\Exceptions\InvalidValueException;
6		use const DaveRandom\LibLifxLan\UINT32_MAX;
7		use const DaveRandom\LibLifxLan\UINT32_MIN;
8
9		final class PowerTransition
10		{
11		private $level;
12		private $duration;
13
14		/**
15		* @param int $level
16		* @throws InvalidValueException
17		*/
18	View Code Duplication	private function setLevel(int $level): void
		1 ignored issue – show Duplication introduced 2018-01-02 17:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		if ($level < 0 \|\| $level > 65535) {
21		throw new InvalidValueException("Power level {$level} outside allowable range of 0 - 65535");
22		}
23
24		$this->level = $level;
25		}
26
27		/**
28		* @param int $duration
29		* @throws InvalidValueException
30		*/
31	View Code Duplication	private function setDuration(int $duration): void
		1 ignored issue – show Duplication introduced 2018-01-02 17:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		if ($duration < UINT32_MIN \|\| $duration > UINT32_MAX) {
34		throw new InvalidValueException(
35		"Transition duration {$duration} outside allowable range of " . UINT32_MIN . " - " . UINT32_MAX
36		);
37		}
38
39		$this->duration = $duration;
40		}
41
42		/**
43		* @param int $level
44		* @param int $duration
45		* @throws InvalidValueException
46		*/
47		public function __construct(int $level, int $duration)
48		{
49		$this->setLevel($level);
50		$this->setDuration($duration);
51		}
52
53		public function getLevel(): int
54		{
55		return $this->level;
56		}
57
58		public function getDuration(): int
59		{
60		return $this->duration;
61		}
62		}
63

DaveRandom / LibLifxLan

Push — master ( ba407f...6dbf2d )

PowerTransition::getLevel() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like