VectorNode::appendClonedChildNodes() - Code Metrics - Inspection of "Break VectorNode#__clone() into private methods" - DaveRandom/JOM - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 4a44e3...b0b1ab )

by Chris
created 2018-06-08 01:32 UTC
VectorNode::appendClonedChildNodes() A

↳ Parent: VectorNode
Complexity

Conditions	3
Paths	3
Size

Total Lines	9
Code Lines	5
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	12
Importance

Changes
Metric	Value
dl	0
loc	9
ccs	0
cts	3
cp	0
rs	9.6666
c	0
b	0
f	0
cc	3
eloc	5
nc	3
nop	1
crap	12
<?php declare(strict_types=1);

namespace DaveRandom\Jom;

use DaveRandom\Jom\Exceptions\InvalidKeyException;
use DaveRandom\Jom\Exceptions\InvalidReferenceNodeException;
use DaveRandom\Jom\Exceptions\InvalidSubjectNodeException;
use DaveRandom\Jom\Exceptions\WriteOperationForbiddenException;

abstract class VectorNode extends Node implements \Countable, \IteratorAggregate, \ArrayAccess
{
    /** @var Node|null */
    protected $firstChild;

    /** @var Node|null */
    protected $lastChild;

    /** @var Node[] */
    protected $children = [];

    /** @var int */
    protected $activeIteratorCount = 0;

    /**
     * @throws WriteOperationForbiddenException
     */
    private function checkWritable(): void
    {
        if ($this->activeIteratorCount !== 0) {
            throw new WriteOperationForbiddenException('Cannot modify a vector with an active iterator');
        }
    }

    /**
     * @throws InvalidSubjectNodeException
     */
    private function checkSubjectNodeIsOrphan(Node $node): void
    {
        if ($node->parent !== null) {
            throw new InvalidSubjectNodeException('Node already present in the document');
        }
    }

    /**
     * @throws InvalidSubjectNodeException
     */
    private function checkSubjectNodeHasSameOwner(Node $node): void
    {
        if ($node->ownerDocument !== $this->ownerDocument) {
            throw new InvalidSubjectNodeException('Node belongs to a different document');
        }

    }

    /**
     * @throws InvalidSubjectNodeException
     */
    private function checkSubjectNodeIsChild(Node $node): void
    {
        if ($node->parent !== $this) {
            throw new InvalidSubjectNodeException('Node not present in children of this node');
        }

    }

    /**
     * @throws InvalidReferenceNodeException
     */
    private function checkReferenceNodeIsChild(Node $node): void
    {
        if ($node->parent !== $this) {
            throw new InvalidReferenceNodeException('Reference node not present in children of this node');
        }

    }

    private function updateFirstChildIfChanged(?Node $newNode, ?Node $oldNode): void
    {
        if ($this->firstChild === $oldNode) {
            $this->firstChild = $newNode;
        }
    }

    private function updateLastChildIfChanged(?Node $newNode, ?Node $oldNode): void
    {
        if ($this->lastChild === $oldNode) {
            $this->lastChild = $newNode;
        }
    }

    private function setNodePreviousSibling(?Node $node, ?Node $newSiblingNode): void
    {
        if ($node !== null) {
            $node->previousSibling = $newSiblingNode;
        }
    }

    private function setNodeNextSibling(?Node $node, ?Node $newSiblingNode): void
    {
        if ($node !== null) {
            $node->nextSibling = $newSiblingNode;
        }
    }

    private function resetChildReferenceProperties(): void
    {
        $this->firstChild = null;
        $this->lastChild = null;
        $this->children = [];
        $this->activeIteratorCount = 0;
    }

    private function appendClonedChildNodes(array $nodes): void
    {
        foreach ($nodes as $key => $node) {
            try {
                $this->appendNode(clone $node, $key);
                //@codeCoverageIgnoreStart
            } catch (\Exception $e) {
                /** @noinspection PhpInternalEntityUsedInspection */
                throw unexpected($e);
            }
            //@codeCoverageIgnoreEnd
        }
    }

    /**
     * @throws InvalidKeyException
     */
    protected function resolveNode($nodeOrKey): Node
    {
        if ($nodeOrKey instanceof Node) {
            return $nodeOrKey;
        }

        if (isset($this->children[$nodeOrKey])) {
            return $this->children[$nodeOrKey];
        }

        throw new InvalidKeyException("{$nodeOrKey} does not reference a valid child node");
    }

    /**
     * @throws WriteOperationForbiddenException
     * @throws InvalidSubjectNodeException
     */
    protected function appendNode(Node $node, $key): Node
    {
        // Prevent modifying a collection with an active iterator
        $this->checkWritable();

        // Validate arguments
        $this->checkSubjectNodeHasSameOwner($node);
        $this->checkSubjectNodeIsOrphan($node);

        // Update first/last child pointers
        $this->updateFirstChildIfChanged($node, null);
        $previousSibling = $this->lastChild;
        $this->lastChild = $node;

        // Update next sibling pointer of old $lastChild (no next sibling node to update)
        $this->setNodeNextSibling($previousSibling, $node);

        // Add the child to the key map
        $this->children[$key] = $node;

        // Set references on new child
        $node->setReferences($this, $key, $previousSibling, null);

        return $node;
    }

    /**
     * @throws WriteOperationForbiddenException
     * @throws InvalidSubjectNodeException
     * @throws InvalidReferenceNodeException
     */
    protected function insertNode(Node $node, $key, ?Node $before = null): Node
    {
        // A null $before reference means push the node on to the end of the list
        if ($before === null) {
            return $this->appendNode($node, $key);
        }

        // Prevent modifying a collection with an active iterator
        $this->checkWritable();

        // Validate arguments
        $this->checkSubjectNodeHasSameOwner($node);
        $this->checkSubjectNodeIsOrphan($node);
        $this->checkReferenceNodeIsChild($before);

        // Update first child pointer (last child pointer is not affected)
        $this->updateFirstChildIfChanged($node, $before);

        // Update next sibling pointer of previous sibling of $before
        $this->setNodeNextSibling($before->previousSibling, $node);

        // Replace the child in the key map
        $this->children[$key] = $node;

        // Set references on new child
        $node->setReferences($this, $key, $before->previousSibling, $before);

        // Update references on ref child
        $before->setReferences($before->parent, $before->key, $node, $before->nextSibling);

        return $node;
    }

    /**
     * @throws WriteOperationForbiddenException
     * @throws InvalidSubjectNodeException
     * @throws InvalidReferenceNodeException
     */
    protected function replaceNode(Node $newNode, Node $oldNode): Node
    {
        // Prevent modifying a collection with an active iterator
        $this->checkWritable();

        // Validate arguments
        $this->checkSubjectNodeHasSameOwner($newNode);
        $this->checkSubjectNodeIsOrphan($newNode);
        $this->checkReferenceNodeIsChild($oldNode);

        // Update first/last child pointers
        $this->updateFirstChildIfChanged($newNode, $oldNode);
        $this->updateLastChildIfChanged($newNode, $oldNode);

        // Update sibling pointers of sibling nodes
        $this->setNodeNextSibling($oldNode->previousSibling, $newNode);
        $this->setNodePreviousSibling($oldNode->nextSibling, $newNode);

        // Replace the node in the key map
        $this->children[$oldNode->key] = $newNode;

        // Copy references from old node to new node
        $newNode->setReferences($oldNode->parent, $oldNode->key, $oldNode->previousSibling, $oldNode->nextSibling);

        // Clear references from old node
        $oldNode->setReferences(null, null, null, null);

        return $oldNode;
    }

    /**
     * @throws WriteOperationForbiddenException
     * @throws InvalidSubjectNodeException
     */
    protected function removeNode(Node $node): Node
    {
        // Prevent modifying a collection with an active iterator
        $this->checkWritable();

        // Validate arguments
        $this->checkSubjectNodeIsChild($node);

        // Update first/last child pointers
        $this->updateFirstChildIfChanged($node->nextSibling, $node);
        $this->updateLastChildIfChanged($node->previousSibling, $node);

        // Update sibling pointers of sibling nodes
        $this->setNodeNextSibling($node->previousSibling, $node->nextSibling);
        $this->setNodePreviousSibling($node->nextSibling, $node->previousSibling);

        // Remove the node from the key map
        unset($this->children[$node->key]);

        // Clear references from node
        $node->setReferences(null, null, null, null);

        return $node;
    }

    final public function __clone()
    {
        parent::__clone();

        $originalParent = $this->firstChild !== null
            ? $this->firstChild->parent
            : null;

        // Get an iterator for the original collection's child nodes
        $children = $originalParent !== null
            ? $originalParent->getIterator()
            : [];

        $this->resetChildReferenceProperties();
        $this->appendClonedChildNodes($children);
        $this->appendClonedChildNodes(/** @scrutinizer ignore-type */ $children);
    }

    final public function hasChildren(): bool
    {
        return !empty($this->children);
    }

    public function containsChild(Node $child): bool
    {
        do {
            if ($child->parent === $this) {
                return true;
            }
        } while (null !== $child = $child->parent);

        return false;
    }

    final public function getFirstChild(): ?Node
    {
        return $this->firstChild;
    }

    final public function getLastChild(): ?Node
    {
        return $this->lastChild;
    }

    final public function clear(): void
    {
        try {
            while ($this->lastChild !== null) {
                $this->removeNode($this->lastChild);
            }
        //@codeCoverageIgnoreStart
        } catch (\Exception $e) {
            /** @noinspection PhpInternalEntityUsedInspection */
            throw unexpected($e);
        }
        //@codeCoverageIgnoreEnd
    }

    final public function getIterator(): NodeListIterator
    {
        return new NodeListIterator($this->firstChild, function($state) {
            $this->activeIteratorCount += $state;
            \assert($this->activeIteratorCount >= 0, new \Error('Vector node active iterator count is negative'));
        });
    }

    final public function count(): int
    {
        return \count($this->children);
    }

    final public function jsonSerialize(): array
    {
        return \iterator_to_array($this->getIterator());
    }

    final public function offsetExists($key): bool
    {
        return isset($this->children[$key]);
    }

    /**
     * @throws WriteOperationForbiddenException
     * @throws InvalidSubjectNodeException
     */
    final public function offsetUnset($key): void
    {
        if (isset($this->children[$key])) {
            $this->removeNode($this->children[$key]);
        }
    }

    abstract public function toArray(): array;
    abstract public function offsetGet($index): Node;
    abstract public function offsetSet($index, $value): void;
}

DaveRandom / JOM

Push — master ( 4a44e3...b0b1ab )

VectorNode::appendClonedChildNodes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
