DaveLiddament / sarb

tests/Integration/TestDirectoryTrait.php

<?php

declare(strict_types=1);

namespace DaveLiddament\StaticAnalysisResultsBaseliner\Tests\Integration;

use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\ProjectRoot;

trait TestDirectoryTrait
{
    private function createTestDirectory(): void
    {
        $dateTimeFolderName = date('Ymd_His');
        $random = random_int(10000, 99999);
        $testDirectory = __DIR__."/../scratchpad/{$dateTimeFolderName}{$random}";
        $this->fileSystem->mkdir($testDirectory);
        $cwd = getcwd();
        $this->assertNotFalse($cwd);

It seems like assertNotFalse() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->projectRoot = ProjectRoot::fromProjectRoot($testDirectory, $cwd);

The property projectRoot does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    private function removeTestDirectory(): void
    {
        $this->fileSystem->remove((string) $this->projectRoot);
    }
}