Passed
Pull Request — master (#69)
by Dave
02:10
created

PhpmdJsonResultsParser::processViolation()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 24
Code Lines 15

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 1
eloc 15
nc 1
nop 3
dl 0
loc 24
rs 9.7666
c 0
b 0
f 0
1
<?php
2
3
/**
4
 * Static Analysis Results Baseliner (sarb).
5
 *
6
 * (c) Dave Liddament
7
 *
8
 * For the full copyright and licence information please view the LICENSE file distributed with this source code.
9
 */
10
11
declare(strict_types=1);
12
13
namespace DaveLiddament\StaticAnalysisResultsBaseliner\Plugins\ResultsParsers\PhpmdJsonResultsParser;
14
15
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\FileName;
16
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\LineNumber;
17
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\Location;
18
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\ProjectRoot;
19
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\Type;
20
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\File\InvalidFileFormatException;
21
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\AnalysisResult;
22
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\AnalysisResults;
23
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\Identifier;
24
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\ResultsParser;
25
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ArrayParseException;
26
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ArrayUtils;
27
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\JsonParseException;
28
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\JsonUtils;
29
30
/**
31
 * Handles PHPMD JSON output.
32
 */
33
class PhpmdJsonResultsParser implements ResultsParser
34
{
35
    /**
36
     * {@inheritdoc}
37
     */
38
    public function convertFromString(string $resultsAsString, ProjectRoot $projectRoot): AnalysisResults
39
    {
40
        try {
41
            $asArray = JsonUtils::toArray($resultsAsString);
42
        } catch (JsonParseException $e) {
43
            throw new InvalidFileFormatException('Not a valid JSON format');
44
        }
45
46
        return $this->convertFromArray($asArray, $projectRoot);
47
    }
48
49
    /**
50
     * {@inheritdoc}
51
     */
52
    public function getIdentifier(): Identifier
53
    {
54
        return new PhpmdJsonIdentifier();
55
    }
56
57
    /**
58
     * {@inheritdoc}
59
     */
60
    public function showTypeGuessingWarning(): bool
61
    {
62
        return false;
63
    }
64
65
    /**
66
     * Converts from an array.
67
     *
68
     * @phpstan-param array<mixed> $analysisResultsAsArray
69
     *
70
     * @throws InvalidFileFormatException
71
     */
72
    private function convertFromArray(array $analysisResultsAsArray, ProjectRoot $projectRoot): AnalysisResults
73
    {
74
        $analysisResults = new AnalysisResults();
75
76
        try {
77
            $filesWithProblems = ArrayUtils::getArrayValue($analysisResultsAsArray, 'files');
78
        } catch (ArrayParseException $e) {
79
            throw new InvalidFileFormatException("Missing 'files' key at root level of JSON structure");
80
        }
81
82
        try {
83
            /** @psalm-suppress MixedAssignment */
84
            foreach ($filesWithProblems as $fileWithProblems) {
85
                ArrayUtils::assertArray($fileWithProblems);
86
                $absoluteFileName = ArrayUtils::getStringValue($fileWithProblems, 'file');
87
                $relativeFileName = $projectRoot->getPathRelativeToRootDirectory($absoluteFileName);
88
                $fileName = new FileName($relativeFileName);
89
90
                $violations = ArrayUtils::getArrayValue($fileWithProblems, 'violations');
91
92
                $this->processViolationsInFile($analysisResults, $absoluteFileName, $fileName, $violations);
93
            }
94
        } catch (ArrayParseException $e) {
95
            throw new InvalidFileFormatException("Invalid file format: {$e->getMessage()}");
96
        }
97
98
        return $analysisResults;
99
    }
100
101
    /**
102
     * @phpstan-param array<mixed> $violations
103
     *
104
     * @throws InvalidFileFormatException
105
     */
106
    private function processViolationsInFile(
107
        AnalysisResults $analysisResults,
108
        string $absoulteFileName,
109
        FileName $fileName,
110
        array $violations
111
    ): void {
112
        $violationCount = 1;
113
        /** @psalm-suppress MixedAssignment */
114
        foreach ($violations as $violation) {
115
            try {
116
                ArrayUtils::assertArray($violation);
117
                $analysisResult = $this->processViolation($absoulteFileName, $fileName, $violation);
118
                $analysisResults->addAnalysisResult($analysisResult);
119
                ++$violationCount;
120
            } catch (ArrayParseException | JsonParseException $e) {
121
                throw new InvalidFileFormatException("Can not process violation {$violationCount} for file {$fileName->getFileName()}");
122
            }
123
        }
124
    }
125
126
    /**
127
     * @phpstan-param array<mixed> $violation
128
     *
129
     * @throws ArrayParseException
130
     * @throws JsonParseException
131
     */
132
    private function processViolation(string $aboluteFileName, FileName $fileName, array $violation): AnalysisResult
133
    {
134
        $typeAsString = ArrayUtils::getStringValue($violation, 'rule');
135
        $type = new Type($typeAsString);
136
137
        $message = ArrayUtils::getStringValue($violation, 'description');
138
139
        $lineAsInt = ArrayUtils::getIntValue($violation, 'beginLine');
140
141
        $location = new Location(
142
            $fileName,
143
            new LineNumber($lineAsInt)
144
        );
145
146
        $detials = [
147
            'fileName' => $aboluteFileName,
148
            'violation' => $violation,
149
        ];
150
151
        return new AnalysisResult(
152
            $location,
153
            $type,
154
            $message,
155
            JsonUtils::toString($detials)
156
        );
157
    }
158
}
159