DaveLiddament\StaticAnalysisResultsBaseliner\Plugins\OutputFormatters\JunitOutputFormatter::outputResults()

Complexity

Conditions	7
Paths	10

Size

Total Lines	81
Code Lines	63

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

<?php
    public function outputResults(AnalysisResults $analysisResults): string
    {
        if (0 === $analysisResults->getCount()) {
            return <<<XML
<?xml version="1.0" encoding="UTF-8"?>
<testsuites
        name="SARB" tests="1" failures="0">
    <testsuite errors="0" tests="1" failures="0" name="Success">
        <testcase name="Success"/>
    </testsuite>
</testsuites>

XML;
        }

        $xml = $this->getXmlString();
        $test = new SimpleXMLElement($xml);

        $testCount = (string) $analysisResults->getCount();
        $test['tests'] = $testCount;
        $test['failures'] = $testCount;

        $suitCount = 0;
        $caseCount = 0;
        $oldRel = null;
        $testsuite = null;
        foreach ($analysisResults->getAnalysisResults() as $analysisResult) {
            $details = $analysisResult->getFullDetails();
            $type = $details['type'] ?? 'error';
            $type = strtolower($type);
            $column = $details['column'] ?? '0';

            $relativeFileName = $analysisResult->getLocation()->getRelativeFileName()->getFileName();

            if ($oldRel !== $relativeFileName || null == $testsuite) {
                $testsuite = $test->addChild('testsuite');
                $testsuite->addAttribute('errors', '0');
                $testsuite->addAttribute('tests', (string) $caseCount);
                $testsuite->addAttribute('failures', (string) $caseCount);
                $testsuite->addAttribute('name', $relativeFileName);

                $oldRel = $relativeFileName;
                ++$suitCount;
                $caseCount = 0;
            }

            $lineSprint = sprintf(
                '%s at %s (%s:%s)',
                $analysisResult->getType()->getType(),
                $analysisResult->getLocation()->getAbsoluteFileName()->getFileName(),
                (string) $analysisResult->getLocation()->getLineNumber()->getLineNumber(),
                $column
            );
            $testcase = $testsuite->addChild('testcase');
            $testcase->addAttribute('name', $lineSprint);
            $testcase->addChild('failure');
            $testcase->failure->addAttribute('type', $type);
            $testcase->failure->addAttribute(
                'message',
                $analysisResult->getMessage()
            );
            ++$caseCount;
            $testsuite['tests'] = $caseCount;
            $testsuite['failures'] = $caseCount;
        }

        $dom = new DOMDocument('1.0');
        $dom->preserveWhiteSpace = false;
        $dom->formatOutput = true;
        $asXml = $test->asXML();

        if ($asXml !== false) {
            $dom->loadXML($asXml);

It seems like $asXml can also be of type true; however, parameter $source of DOMDocument::loadXML() does only seem to accept string, maybe add an additional type check?

        } else {
            throw new RuntimeException('xml could not be loaded');
        }
        $saveXml = $dom->saveXML();
        if ($saveXml !== false) {
            return $saveXml;
        }
        throw new RuntimeException('dom could not be saved');
    }