Passed
Pull Request — master (#69)
by Dave
02:36
created

PhpmdJsonResultsParser::convertFromString()   A

Complexity

Conditions 4
Paths 8

Size

Total Lines 29
Code Lines 18

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 4
eloc 18
nc 8
nop 2
dl 0
loc 29
rs 9.6666
c 0
b 0
f 0
1
<?php
2
3
/**
4
 * Static Analysis Results Baseliner (sarb).
5
 *
6
 * (c) Dave Liddament
7
 *
8
 * For the full copyright and licence information please view the LICENSE file distributed with this source code.
9
 */
10
11
declare(strict_types=1);
12
13
namespace DaveLiddament\StaticAnalysisResultsBaseliner\Plugins\ResultsParsers\PhpmdJsonResultsParser;
14
15
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\AbsoluteFileName;
16
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\LineNumber;
17
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\Location;
18
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\ProjectRoot;
19
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\Type;
20
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\AnalysisResult;
21
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\AnalysisResults;
22
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\AnalysisResultsBuilder;
23
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\Identifier;
24
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\ResultsParser\ResultsParser;
25
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ArrayParseException;
26
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ArrayUtils;
27
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\JsonUtils;
28
use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Utils\ParseAtLocationException;
29
30
/**
31
 * Handles PHPMD JSON output.
32
 */
33
class PhpmdJsonResultsParser implements ResultsParser
34
{
35
    public function convertFromString(string $resultsAsString, ProjectRoot $projectRoot): AnalysisResults
36
    {
37
        $analysisResultsAsArray = JsonUtils::toArray($resultsAsString);
38
        $analysisResultsBuilder = new AnalysisResultsBuilder();
39
40
        try {
41
            $filesWithProblems = ArrayUtils::getArrayValue($analysisResultsAsArray, 'files');
42
        } catch (ArrayParseException $e) {
43
            throw ParseAtLocationException::issueParsingWithMessage("Missing 'files' key", 'root level of JSON structure');
44
        }
45
46
        $fileNumber = 0;
47
        try {
48
            /** @psalm-suppress MixedAssignment */
49
            foreach ($filesWithProblems as $fileWithProblems) {
50
                ++$fileNumber;
51
                ArrayUtils::assertArray($fileWithProblems);
52
                $absoluteFileNameAsString = ArrayUtils::getStringValue($fileWithProblems, 'file');
53
                $absoluteFileName = new AbsoluteFileName($absoluteFileNameAsString);
54
55
                $violations = ArrayUtils::getArrayValue($fileWithProblems, 'violations');
56
57
                $this->processViolationsInFile($analysisResultsBuilder, $absoluteFileName, $projectRoot, $violations);
58
            }
59
        } catch (ArrayParseException $e) {
60
            throw ParseAtLocationException::issueParsing($e, "Invalid file {$fileNumber}");
61
        }
62
63
        return $analysisResultsBuilder->build();
64
    }
65
66
    /**
67
     * @psalm-param array<mixed> $violations
68
     *
69
     * @throws ParseAtLocationException
70
     */
71
    private function processViolationsInFile(
72
        AnalysisResultsBuilder $analysisResultsBuilder,
73
        AbsoluteFileName $absoluteFileName,
74
        ProjectRoot $projectRoot,
75
        array $violations
76
    ): void {
77
        $violationCount = 1;
78
        /** @psalm-suppress MixedAssignment */
79
        foreach ($violations as $violation) {
80
            try {
81
                ArrayUtils::assertArray($violation);
82
                $analysisResult = $this->processViolation($absoluteFileName, $projectRoot, $violation);
83
                $analysisResultsBuilder->addAnalysisResult($analysisResult);
84
                ++$violationCount;
85
            } catch (ArrayParseException $e) {
86
                throw ParseAtLocationException::issueParsing($e, "File {$absoluteFileName->getFileName()}) violation {$violationCount}");
87
            }
88
        }
89
    }
90
91
    /**
92
     * @psalm-param array<mixed> $violation
93
     *
94
     * @throws ArrayParseException
95
     */
96
    private function processViolation(
97
        AbsoluteFileName $aboluteFileName,
98
        ProjectRoot $projectRoot,
99
        array $violation
100
    ): AnalysisResult {
101
        $typeAsString = ArrayUtils::getStringValue($violation, 'rule');
102
        $type = new Type($typeAsString);
103
104
        $message = ArrayUtils::getStringValue($violation, 'description');
105
106
        $lineAsInt = ArrayUtils::getIntValue($violation, 'beginLine');
107
108
        $location = Location::fromAbsoluteFileName(
109
            $aboluteFileName,
110
            $projectRoot,
111
            new LineNumber($lineAsInt)
112
        );
113
114
        return new AnalysisResult(
115
            $location,
116
            $type,
117
            $message,
118
            JsonUtils::toString($violation)
119
        );
120
    }
121
122
    public function getIdentifier(): Identifier
123
    {
124
        return new PhpmdJsonIdentifier();
125
    }
126
127
    public function showTypeGuessingWarning(): bool
128
    {
129
        return false;
130
    }
131
}
132