DaveLiddament /
sarb
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 51 |
| Code Lines | 29 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 38 | public function testRemoveBaseLineResults(): void |
||
| 39 | { |
||
| 40 | $projectRoot = new ProjectRoot('/home/sarb', '/home/sarb'); |
||
| 41 | |||
| 42 | // Create baseline |
||
| 43 | $baselineAnalysisResultsBuilder = new BaseLineResultsBuilder(); |
||
| 44 | $baselineAnalysisResultsBuilder->add(self::FILE_1, self::LINE_10, self::TYPE_1); |
||
| 45 | $baselineAnalysisResultsBuilder->add(self::FILE_2, self::LINE_15, self::TYPE_2); |
||
| 46 | |||
| 47 | // Create file mutations |
||
| 48 | $fileMutationsBuilder = new FileMutationsBuilder(); |
||
| 49 | $fileMutationBuilder = new FileMutationBuilder($fileMutationsBuilder); |
||
| 50 | $fileMutationBuilder->setOriginalFileName(new OriginalFileName(self::FILE_1)); |
||
| 51 | $fileMutationBuilder->setNewFileName(new NewFileName(self::FILE_1)); |
||
| 52 | $fileMutationBuilder->addLineMutation(LineMutation::newLineNumber(new LineNumber(self::LINE_9))); |
||
| 53 | $fileMutationBuilder->build(); |
||
| 54 | $fileMutations = $fileMutationsBuilder->build(); |
||
| 55 | |||
| 56 | // Create latest results |
||
| 57 | $latestAnalysisResultsBuilder = new AnalysisResultsBuilder(); |
||
| 58 | // This is in the baseline (it was line 10 in baseline) |
||
| 59 | $this->addAnalysisResult($latestAnalysisResultsBuilder, $projectRoot, self::FILE_1_FULL_PATH, self::LINE_11, self::TYPE_1); |
||
| 60 | // Added since baseline |
||
| 61 | $this->addAnalysisResult($latestAnalysisResultsBuilder, $projectRoot, self::FILE_1_FULL_PATH, self::LINE_9, self::TYPE_2); |
||
| 62 | |||
| 63 | // Prune baseline results from latest results |
||
| 64 | $historyAnalyser = new DiffHistoryAnalyser($fileMutations); |
||
| 65 | $baseLineResultsRemover = new BaseLineResultsRemover(); |
||
| 66 | $prunedAnalysisResults = $baseLineResultsRemover->pruneBaseLine( |
||
| 67 | $latestAnalysisResultsBuilder->build(), |
||
| 68 | $historyAnalyser, |
||
| 69 | $baselineAnalysisResultsBuilder->build() |
||
| 70 | ); |
||
| 71 | |||
| 72 | $actualResults = $prunedAnalysisResults->getAnalysisResults(); |
||
| 73 | |||
| 74 | // Assert results as expected |
||
| 75 | // Of the original results: |
||
| 76 | // the one in FILE_1 line 10 is now at FILE_1 line 11 (so should not appear in the pruned results) |
||
| 77 | // the one in FILE_2 line 15 is not in latest results |
||
| 78 | // A new bug has been introduced at FILE_1 line 9 (this is the only one that should appera in the results) |
||
| 79 | $this->assertCount(1, $actualResults); |
||
| 80 | |||
| 81 | $actualAnalysisResult = $actualResults[0]; |
||
| 82 | $expectedFileName = new AbsoluteFileName(self::FILE_1_FULL_PATH); |
||
| 83 | $expectedLineNumber = new LineNumber(self::LINE_9); |
||
| 84 | $expectedType = new Type(self::TYPE_2); |
||
| 85 | |||
| 86 | $this->assertTrue($expectedFileName->isEqual($actualAnalysisResult->getLocation()->getAbsoluteFileName())); |
||
| 87 | $this->assertTrue($expectedLineNumber->isEqual($actualAnalysisResult->getLocation()->getLineNumber())); |
||
| 88 | $this->assertTrue($expectedType->isEqual($actualAnalysisResult->getType())); |
||
| 89 | } |
||
| 91 |
