DaveLiddament\StaticAnalysisResultsBaseliner\Framework\Command\internal\CliConfigReader

Complexity

Total Complexity

8

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getOption()	0	11	2
A	getStdin()	0	16	3
A	getOptionWithDefaultValue()	0	6	1
A	getArgument()	0	6	1
A	getBooleanOption()	0	6	1

<?php

declare(strict_types=1);

namespace DaveLiddament\StaticAnalysisResultsBaseliner\Framework\Command\internal;

use DaveLiddament\StaticAnalysisResultsBaseliner\Domain\Common\SarbException;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\StreamableInputInterface;
use Webmozart\Assert\Assert;

class CliConfigReader
{
    public static function getArgument(InputInterface $input, string $argumentName): string
    {
        $value = $input->getArgument($argumentName);
        Assert::string($value);

        return $value;

The expression return $value could return the type null|string[] which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    public static function getOption(InputInterface $input, string $optionName): ?string
    {
        $value = $input->getOption($optionName);

        if (null === $value) {
            return null;
        }

        Assert::string($value);

        return $value;
    }

    public static function getOptionWithDefaultValue(InputInterface $input, string $optionName): string
    {
        $value = self::getOption($input, $optionName);
        Assert::notNull($value);

        return $value;

The expression return $value could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * Returns STDIN as a string.
     *
     * @throws SarbException
     */
    public static function getStdin(InputInterface $input): string
    {
        // If testing this will get input added by `CommandTester::setInputs` method.
        $inputSteam = ($input instanceof StreamableInputInterface) ? $input->getStream() : null;

        // If nothing from input stream use STDIN instead.
        $inputSteam = $inputSteam ?? \STDIN;

        $input = stream_get_contents($inputSteam);

        if (false === $input) {
            // No way of easily testing this
            throw new SarbException('Can not read input stream'); // @codeCoverageIgnore
        }

        return $input;
    }

    public static function getBooleanOption(InputInterface $input, string $argument): bool
    {
        $option = $input->getOption($argument);
        Assert::boolean($option);

        return $option;
    }
}