| Conditions | 1 |
| Paths | 1 |
| Total Lines | 206 |
| Code Lines | 108 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 22 | public function dataProvider() |
||
| 23 | { |
||
| 24 | return [ |
||
| 25 | 'fileChanged' => [ |
||
| 26 | 'fileChanged.diff', |
||
| 27 | [ |
||
| 28 | [ |
||
| 29 | new OriginalFileName('src/Person.php'), |
||
| 30 | new NewFileName('src/Person.php'), |
||
| 31 | false, |
||
| 32 | false, |
||
| 33 | [ |
||
| 34 | LineMutation::newLineNumber(new LineNumber(18)), |
||
| 35 | LineMutation::newLineNumber(new LineNumber(19)), |
||
| 36 | LineMutation::newLineNumber(new LineNumber(20)), |
||
| 37 | LineMutation::newLineNumber(new LineNumber(21)), |
||
| 38 | LineMutation::newLineNumber(new LineNumber(22)), |
||
| 39 | LineMutation::originalLineNumber(new LineNumber(21)), |
||
| 40 | LineMutation::newLineNumber(new LineNumber(26)), |
||
| 41 | LineMutation::newLineNumber(new LineNumber(29)), |
||
| 42 | LineMutation::newLineNumber(new LineNumber(40)), |
||
| 43 | LineMutation::newLineNumber(new LineNumber(41)), |
||
| 44 | LineMutation::newLineNumber(new LineNumber(42)), |
||
| 45 | LineMutation::newLineNumber(new LineNumber(43)), |
||
| 46 | LineMutation::newLineNumber(new LineNumber(44)), |
||
| 47 | LineMutation::newLineNumber(new LineNumber(45)), |
||
| 48 | LineMutation::newLineNumber(new LineNumber(46)), |
||
| 49 | LineMutation::newLineNumber(new LineNumber(47)), |
||
| 50 | ], |
||
| 51 | ], |
||
| 52 | ], |
||
| 53 | ], |
||
| 54 | |||
| 55 | 'binaryFileAdded' => [ |
||
| 56 | 'binaryFileAdded.diff', |
||
| 57 | [ |
||
| 58 | // No mutations expected |
||
| 59 | ], |
||
| 60 | ], |
||
| 61 | |||
| 62 | 'binaryFileChanged' => [ |
||
| 63 | 'binaryFileChanged.diff', |
||
| 64 | [ |
||
| 65 | // No mutations expected |
||
| 66 | ], |
||
| 67 | ], |
||
| 68 | |||
| 69 | 'binaryFileDeleted' => [ |
||
| 70 | 'binaryFileDeleted.diff', |
||
| 71 | [ |
||
| 72 | // No mutations expected |
||
| 73 | ], |
||
| 74 | ], |
||
| 75 | |||
| 76 | 'binaryFileRenamed' => [ |
||
| 77 | 'binaryFileRenamed.diff', |
||
| 78 | [ |
||
| 79 | [ |
||
| 80 | new OriginalFileName('img.png'), |
||
| 81 | new NewFileName('img1.png'), |
||
| 82 | false, |
||
| 83 | false, |
||
| 84 | [], |
||
| 85 | ], |
||
| 86 | ], |
||
| 87 | ], |
||
| 88 | |||
| 89 | 'fileAdded' => [ |
||
| 90 | 'fileAdded.diff', |
||
| 91 | [ |
||
| 92 | [ |
||
| 93 | null, |
||
| 94 | new NewFileName('src/Person.php'), |
||
| 95 | true, |
||
| 96 | false, |
||
| 97 | [], |
||
| 98 | ], |
||
| 99 | ], |
||
| 100 | ], |
||
| 101 | |||
| 102 | 'fileRenamed' => [ |
||
| 103 | 'fileRenamed.diff', |
||
| 104 | [ |
||
| 105 | [ |
||
| 106 | new OriginalFileName('src/Printer.php'), |
||
| 107 | new NewFileName('src/Foo.php'), |
||
| 108 | false, |
||
| 109 | false, |
||
| 110 | [], |
||
| 111 | ], |
||
| 112 | ], |
||
| 113 | ], |
||
| 114 | |||
| 115 | 'fileDeleted' => [ |
||
| 116 | 'fileDeleted.diff', |
||
| 117 | [ |
||
| 118 | // Deleted files are not added to FileMutations as we don't care about them |
||
| 119 | ], |
||
| 120 | ], |
||
| 121 | |||
| 122 | 'fileRenamedAndChanged' => [ |
||
| 123 | 'fileRenamedAndChanged.diff', |
||
| 124 | [ |
||
| 125 | [ |
||
| 126 | new OriginalFileName('src/User.php'), |
||
| 127 | new NewFileName('src/Person.php'), |
||
| 128 | false, |
||
| 129 | false, |
||
| 130 | [ |
||
| 131 | LineMutation::originalLineNumber(new LineNumber(9)), |
||
| 132 | LineMutation::newLineNumber(new LineNumber(9)), |
||
| 133 | LineMutation::originalLineNumber(new LineNumber(23)), |
||
| 134 | LineMutation::newLineNumber(new LineNumber(23)), |
||
| 135 | ], |
||
| 136 | ], |
||
| 137 | ], |
||
| 138 | ], |
||
| 139 | |||
| 140 | 'file1RenameFile2Changed' => [ |
||
| 141 | 'file1RenameFile2Changed.diff', |
||
| 142 | [ |
||
| 143 | [ |
||
| 144 | new OriginalFileName('src/Bar.php'), |
||
| 145 | new NewFileName('src/Baz.php'), |
||
| 146 | false, |
||
| 147 | false, |
||
| 148 | [], |
||
| 149 | ], |
||
| 150 | [ |
||
| 151 | new OriginalFileName('src/User.php'), |
||
| 152 | new NewFileName('src/User.php'), |
||
| 153 | false, |
||
| 154 | false, |
||
| 155 | [ |
||
| 156 | LineMutation::originalLineNumber(new LineNumber(8)), |
||
| 157 | ], |
||
| 158 | ], |
||
| 159 | ], |
||
| 160 | ], |
||
| 161 | |||
| 162 | '2filesChanged' => [ |
||
| 163 | '2filesChanged.diff', |
||
| 164 | [ |
||
| 165 | [ |
||
| 166 | new OriginalFileName('src/Baz.php'), |
||
| 167 | new NewFileName('src/Baz.php'), |
||
| 168 | false, |
||
| 169 | false, |
||
| 170 | [ |
||
| 171 | LineMutation::originalLineNumber(new LineNumber(5)), |
||
| 172 | ], |
||
| 173 | ], |
||
| 174 | [ |
||
| 175 | new OriginalFileName('src/User.php'), |
||
| 176 | new NewFileName('src/User.php'), |
||
| 177 | false, |
||
| 178 | false, |
||
| 179 | [ |
||
| 180 | LineMutation::originalLineNumber(new LineNumber(5)), |
||
| 181 | ], |
||
| 182 | ], |
||
| 183 | ], |
||
| 184 | ], |
||
| 185 | '1lineFileChanged' => [ |
||
| 186 | '1lineFileChanged.diff', |
||
| 187 | [ |
||
| 188 | [ |
||
| 189 | new OriginalFileName('message.txt'), |
||
| 190 | new NewFileName('message.txt'), |
||
| 191 | false, |
||
| 192 | false, |
||
| 193 | [ |
||
| 194 | LineMutation::originalLineNumber(new LineNumber(1)), |
||
| 195 | LineMutation::newLineNumber(new LineNumber(1)), |
||
| 196 | ], |
||
| 197 | ], |
||
| 198 | ], |
||
| 199 | ], |
||
| 200 | '1lineTo2LinesFileChanged' => [ |
||
| 201 | '1lineTo2LinesFileChanged.diff', |
||
| 202 | [ |
||
| 203 | [ |
||
| 204 | new OriginalFileName('message.txt'), |
||
| 205 | new NewFileName('message.txt'), |
||
| 206 | false, |
||
| 207 | false, |
||
| 208 | [ |
||
| 209 | LineMutation::originalLineNumber(new LineNumber(1)), |
||
| 210 | LineMutation::newLineNumber(new LineNumber(1)), |
||
| 211 | LineMutation::newLineNumber(new LineNumber(2)), |
||
| 212 | ], |
||
| 213 | ], |
||
| 214 | ], |
||
| 215 | ], |
||
| 216 | '2lineTo1LineFileChanged' => [ |
||
| 217 | '2lineTo1LineFileChanged.diff', |
||
| 218 | [ |
||
| 219 | [ |
||
| 220 | new OriginalFileName('message.txt'), |
||
| 221 | new NewFileName('message.txt'), |
||
| 222 | false, |
||
| 223 | false, |
||
| 224 | [ |
||
| 225 | LineMutation::originalLineNumber(new LineNumber(1)), |
||
| 226 | LineMutation::originalLineNumber(new LineNumber(2)), |
||
| 227 | LineMutation::newLineNumber(new LineNumber(1)), |
||
| 228 | ], |
||
| 302 |