Datatrics /
php-api
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 4 | View Code Duplication | class Bucket extends Base |
|
|
|
|||
| 5 | { |
||
| 6 | /** |
||
| 7 | * Private constructor so only the client can create this |
||
| 8 | * @param string $apikey |
||
| 9 | * @param string $projectid |
||
| 10 | */ |
||
| 11 | public function __construct($apikey, $projectid) |
||
| 15 | |||
| 16 | /** |
||
| 17 | * Get one or multiple buckets |
||
| 18 | * @param string bucket id, leave null for list of boxes |
||
| 19 | * @param object Containing query arguments |
||
| 20 | * @return object Result of the request |
||
| 21 | */ |
||
| 22 | public function Get($bucketId = null, $args = array("limit" => 50)) |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Create new bucket |
||
| 29 | * @param object Containing all the information of a bucket |
||
| 30 | * @return object Result of the request |
||
| 31 | */ |
||
| 32 | public function Create($bucket) |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Delete a bucket object by bucket id |
||
| 39 | * @param string Id of the bucket |
||
| 40 | * @return object Result of the request |
||
| 41 | */ |
||
| 42 | public function Delete($bucketId) |
||
| 46 | |||
| 47 | /** |
||
| 48 | * List fields of a bucket |
||
| 49 | * @param string Id of the bucket |
||
| 50 | * @return object Result of the request |
||
| 51 | */ |
||
| 52 | public function Fields($bucketId) |
||
| 56 | } |
||
| 57 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.