Conditions | 4 |
Paths | 5 |
Total Lines | 95 |
Code Lines | 75 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
54 | public function validInputProvider() { |
||
55 | $gregorian = 'http://www.wikidata.org/entity/Q1985727'; |
||
56 | $julian = 'http://www.wikidata.org/entity/Q1985786'; |
||
57 | |||
58 | $argLists = array(); |
||
59 | |||
60 | $valid = array( |
||
61 | // leading zeros |
||
62 | '00001 1999' => |
||
63 | array( '+1999-01-00T00:00:00Z' ), |
||
64 | '000000001 100001999' => |
||
65 | array( '+100001999-01-00T00:00:00Z' ), |
||
66 | |||
67 | // use string month names |
||
68 | 'Jan/1999' => |
||
69 | array( '+1999-01-00T00:00:00Z' ), |
||
70 | 'January/1999' => |
||
71 | array( '+1999-01-00T00:00:00Z' ), |
||
72 | 'January/1' => |
||
73 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
74 | '1999 January' => |
||
75 | array( '+1999-01-00T00:00:00Z' ), |
||
76 | 'January 1999' => |
||
77 | array( '+1999-01-00T00:00:00Z' ), |
||
78 | 'January-1' => |
||
79 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
80 | 'JanuARY-1' => |
||
81 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
82 | 'JaN/1999' => |
||
83 | array( '+1999-01-00T00:00:00Z' ), |
||
84 | 'januARY-1' => |
||
85 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
86 | 'jan/1999' => |
||
87 | array( '+1999-01-00T00:00:00Z' ), |
||
88 | |||
89 | // use different date separators |
||
90 | '1-1999' => |
||
91 | array( '+1999-01-00T00:00:00Z' ), |
||
92 | '1/1999' => |
||
93 | array( '+1999-01-00T00:00:00Z' ), |
||
94 | '1 / 1999' => |
||
95 | array( '+1999-01-00T00:00:00Z' ), |
||
96 | '1 1999' => |
||
97 | array( '+1999-01-00T00:00:00Z' ), |
||
98 | '1,1999' => |
||
99 | array( '+1999-01-00T00:00:00Z' ), |
||
100 | '1.1999' => |
||
101 | array( '+1999-01-00T00:00:00Z' ), |
||
102 | '1. 1999' => |
||
103 | array( '+1999-01-00T00:00:00Z' ), |
||
104 | |||
105 | // presume mm/yy unless impossible month, in which case switch |
||
106 | '12/12' => |
||
107 | array( '+0012-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
108 | '12/11' => |
||
109 | array( '+0011-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
110 | '11/12' => |
||
111 | array( '+0012-11-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
112 | '13/12' => |
||
113 | array( '+0013-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
114 | '12/13' => |
||
115 | array( '+0013-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
116 | '2000 1' => |
||
117 | array( '+2000-01-00T00:00:00Z' ), |
||
118 | |||
119 | // big years |
||
120 | 'April-1000000001' => |
||
121 | array( '+1000000001-04-00T00:00:00Z' ), |
||
122 | 'April 1000000001' => |
||
123 | array( '+1000000001-04-00T00:00:00Z' ), |
||
124 | '1000000001 April' => |
||
125 | array( '+1000000001-04-00T00:00:00Z' ), |
||
126 | '1 13000' => |
||
127 | array( '+13000-01-00T00:00:00Z' ), |
||
128 | |||
129 | // parse 0 month as if no month has been entered |
||
130 | '0.1999' => |
||
131 | array( '+1999-00-00T00:00:00Z', TimeValue::PRECISION_YEAR ), |
||
132 | '1999 0' => |
||
133 | array( '+1999-00-00T00:00:00Z', TimeValue::PRECISION_YEAR ), |
||
134 | ); |
||
135 | |||
136 | foreach ( $valid as $value => $expected ) { |
||
137 | $timestamp = $expected[0]; |
||
138 | $precision = isset( $expected[1] ) ? $expected[1] : TimeValue::PRECISION_MONTH; |
||
139 | $calendarModel = isset( $expected[2] ) ? $expected[2] : $gregorian; |
||
140 | |||
141 | $argLists[] = array( |
||
142 | (string)$value, |
||
143 | new TimeValue( $timestamp, 0, 0, 0, $precision, $calendarModel ) |
||
144 | ); |
||
145 | } |
||
146 | |||
147 | return $argLists; |
||
148 | } |
||
149 | |||
182 |