YearTimeParserTest::validInputProvider() - Code Metrics - Inspection of "Drop compatibility with DataValues Interfaces <0.2..." - DataValues/Time - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#134)

by no

created 2017-08-03 18:08 UTC

YearTimeParserTest::validInputProvider() B

↳ Parent: YearTimeParserTest

Complexity

Conditions	4
Paths	5

Size

Total Lines	53
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	53
rs	8.9849
cc	4
eloc	41
nc	5
nop	0

How to fix Long Method

<?php

namespace ValueParsers\Test;

use DataValues\TimeValue;
use ValueParsers\EraParser;
use ValueParsers\ParserOptions;
use ValueParsers\YearTimeParser;

/**
 * @covers ValueParsers\YearTimeParser
 *
 * @group DataValue
 * @group DataValueExtensions
 * @group TimeParsers
 * @group ValueParsers
 *
 * @license GPL-2.0+
 * @author Addshore
 * @author Thiemo Mättig
 */
class YearTimeParserTest extends StringValueParserTest {

	/**
	 * @see ValueParserTestBase::getInstance
	 *
	 * @return YearTimeParser
	 */
	protected function getInstance() {
		return new YearTimeParser( $this->getMockEraParser() );
	}

	/**
	 * @return EraParser
	 */
	private function getMockEraParser() {
		$mock = $this->getMockBuilder( 'ValueParsers\EraParser' )
			->disableOriginalConstructor()
			->getMock();
		$mock->expects( $this->any() )
			->method( 'parse' )
			->with( $this->isType( 'string' ) )
			->will( $this->returnCallback(
				function( $value ) {
					$sign = '+';
					// Tiny parser that supports a single negative sign only
					if ( $value[0] === '-' ) {
						$sign = '-';
						$value = substr( $value, 1 );
					}
					return array( $sign, $value );
				}
			) );
		return $mock;
	}

	/**
	 * @see ValueParserTestBase::validInputProvider
	 */
	public function validInputProvider() {
		$gregorian = 'http://www.wikidata.org/entity/Q1985727';
		$julian = 'http://www.wikidata.org/entity/Q1985786';

		$argLists = array();

		$valid = array(
			// Whitespace
			"1999\n" =>
				array( '+1999-00-00T00:00:00Z' ),
			' 2000 ' =>
				array( '+2000-00-00T00:00:00Z' ),

			'2010' =>
				array( '+2010-00-00T00:00:00Z' ),
			'2000000' =>
				array( '+2000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1M ),
			'2000000000' =>
				array( '+2000000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1G ),
			'2000020000' =>
				array( '+2000020000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR10K ),
			'2000001' =>
				array( '+2000001-00-00T00:00:00Z' ),
			'02000001' =>
				array( '+2000001-00-00T00:00:00Z' ),
			'1' =>
				array( '+0001-00-00T00:00:00Z', TimeValue::PRECISION_YEAR, $julian ),
			'000000001' =>
				array( '+0001-00-00T00:00:00Z', TimeValue::PRECISION_YEAR, $julian ),
			'-1000000' =>
				array( '-1000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1M, $julian ),
			'-1 000 000' =>
				array( '-1000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1M, $julian ),
			'-19_000' =>
				array( '-19000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1K, $julian ),
			// Digit grouping in the Indian numbering system
			'-1,99,999' =>
				array( '-199999-00-00T00:00:00Z', TimeValue::PRECISION_YEAR, $julian ),
		);

		foreach ( $valid as $value => $expected ) {
			$timestamp = $expected[0];
			$precision = isset( $expected[1] ) ? $expected[1] : TimeValue::PRECISION_YEAR;
			$calendarModel = isset( $expected[2] ) ? $expected[2] : $gregorian;

			$argLists[] = array(
				(string)$value,
				new TimeValue( $timestamp, 0, 0, 0, $precision, $calendarModel )
			);
		}

		return $argLists;
	}

	public function testDigitGroupSeparatorOption() {
		$options = new ParserOptions();
		$options->setOption( YearTimeParser::OPT_DIGIT_GROUP_SEPARATOR, '.' );
		$parser = new YearTimeParser( null, $options );
		$timeValue = $parser->parse( '-19.000' );
		$this->assertSame( '-19000-00-00T00:00:00Z', $timeValue->getTime() );
	}

	/**
	 * @see StringValueParserTest::invalidInputProvider
	 */
	public function invalidInputProvider() {
		$argLists = parent::invalidInputProvider();

		$invalid = array(
			// These are just wrong
			'June June June',
			'111 111 111',
			'Jann 2014',

			// Not within the scope of this parser
			'1 July 20000',

			// We should not try to parse these, this just gets confusing
			'-100BC',
			'+100BC',
			'-100 BC',
			'+100 BC',
			'+100 BCE',
			'+100BCE',

			// Non-default and invalid thousands separators
			'-,999',
			'-999,',
			'-19.000',
			'-1/000/000',

			// Positive years are unlikely to have thousands separators, it's more likely a date
			'1 000 000',
			'19_000',
			'1,99,999',
		);

		foreach ( $invalid as $value ) {
			$argLists[] = array( $value );
		}

		return $argLists;
	}

	/**
	 * @expectedException \ValueParsers\ParseException
	 * @expectedExceptionMessage Failed to parse year
	 */
	public function testParseExceptionMessage() {
		$parser = $this->getInstance();
		$parser->parse( 'ju5t 1nval1d' );
	}

}


1			<?php
2
3			namespace ValueParsers\Test;
4
5			use DataValues\TimeValue;
6			use ValueParsers\EraParser;
7			use ValueParsers\ParserOptions;
8			use ValueParsers\YearTimeParser;
9
10			/**
11			* @covers ValueParsers\YearTimeParser
12			*
13			* @group DataValue
14			* @group DataValueExtensions
15			* @group TimeParsers
16			* @group ValueParsers
17			*
18			* @license GPL-2.0+
19			* @author Addshore
20			* @author Thiemo Mättig
21			*/
22			class YearTimeParserTest extends StringValueParserTest {
23
24			/**
25			* @see ValueParserTestBase::getInstance
26			*
27			* @return YearTimeParser
28			*/
29			protected function getInstance() {
30			return new YearTimeParser( $this->getMockEraParser() );
31			}
32
33			/**
34			* @return EraParser
35			*/
36			private function getMockEraParser() {
37			$mock = $this->getMockBuilder( 'ValueParsers\EraParser' )
38			->disableOriginalConstructor()
39			->getMock();
40			$mock->expects( $this->any() )
41			->method( 'parse' )
42			->with( $this->isType( 'string' ) )
43			->will( $this->returnCallback(
44			function( $value ) {
45			$sign = '+';
46			// Tiny parser that supports a single negative sign only
47			if ( $value[0] === '-' ) {
48			$sign = '-';
49			$value = substr( $value, 1 );
50			}
51			return array( $sign, $value );
52			}
53			) );
54			return $mock;
55			}
56
57			/**
58			* @see ValueParserTestBase::validInputProvider
59			*/
60			public function validInputProvider() {
61			$gregorian = 'http://www.wikidata.org/entity/Q1985727';
62			$julian = 'http://www.wikidata.org/entity/Q1985786';
63
64			$argLists = array();
65
66			$valid = array(
67			// Whitespace
68			"1999\n" =>
69			array( '+1999-00-00T00:00:00Z' ),
70			' 2000 ' =>
71			array( '+2000-00-00T00:00:00Z' ),
72
73			'2010' =>
74			array( '+2010-00-00T00:00:00Z' ),
75			'2000000' =>
76			array( '+2000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1M ),
77			'2000000000' =>
78			array( '+2000000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1G ),
79			'2000020000' =>
80			array( '+2000020000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR10K ),
81			'2000001' =>
82			array( '+2000001-00-00T00:00:00Z' ),
83			'02000001' =>
84			array( '+2000001-00-00T00:00:00Z' ),
85			'1' =>
86			array( '+0001-00-00T00:00:00Z', TimeValue::PRECISION_YEAR, $julian ),
87			'000000001' =>
88			array( '+0001-00-00T00:00:00Z', TimeValue::PRECISION_YEAR, $julian ),
89			'-1000000' =>
90			array( '-1000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1M, $julian ),
91			'-1 000 000' =>
92			array( '-1000000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1M, $julian ),
93			'-19_000' =>
94			array( '-19000-00-00T00:00:00Z', TimeValue::PRECISION_YEAR1K, $julian ),
95			// Digit grouping in the Indian numbering system
96			'-1,99,999' =>
97			array( '-199999-00-00T00:00:00Z', TimeValue::PRECISION_YEAR, $julian ),
98			);
99
100			foreach ( $valid as $value => $expected ) {
101			$timestamp = $expected[0];
102			$precision = isset( $expected[1] ) ? $expected[1] : TimeValue::PRECISION_YEAR;
103			$calendarModel = isset( $expected[2] ) ? $expected[2] : $gregorian;
104
105			$argLists[] = array(
106			(string)$value,
107			new TimeValue( $timestamp, 0, 0, 0, $precision, $calendarModel )
108			);
109			}
110
111			return $argLists;
112			}
113
114			public function testDigitGroupSeparatorOption() {
115			$options = new ParserOptions();
116			$options->setOption( YearTimeParser::OPT_DIGIT_GROUP_SEPARATOR, '.' );
117			$parser = new YearTimeParser( null, $options );
118			$timeValue = $parser->parse( '-19.000' );
119			$this->assertSame( '-19000-00-00T00:00:00Z', $timeValue->getTime() );
120			}
121
122			/**
123			* @see StringValueParserTest::invalidInputProvider
124			*/
125			public function invalidInputProvider() {
126			$argLists = parent::invalidInputProvider();
127
128			$invalid = array(
129			// These are just wrong
130			'June June June',
131			'111 111 111',
132			'Jann 2014',
133
134			// Not within the scope of this parser
135			'1 July 20000',
136
137			// We should not try to parse these, this just gets confusing
138			'-100BC',
139			'+100BC',
140			'-100 BC',
141			'+100 BC',
142			'+100 BCE',
143			'+100BCE',
144
145			// Non-default and invalid thousands separators
146			'-,999',
147			'-999,',
148			'-19.000',
149			'-1/000/000',
150
151			// Positive years are unlikely to have thousands separators, it's more likely a date
152			'1 000 000',
153			'19_000',
154			'1,99,999',
155			);
156
157			foreach ( $invalid as $value ) {
158			$argLists[] = array( $value );
159			}
160
161			return $argLists;
162			}
163
164			/**
165			* @expectedException \ValueParsers\ParseException
166			* @expectedExceptionMessage Failed to parse year
167			*/
168			public function testParseExceptionMessage() {
169			$parser = $this->getInstance();
170			$parser->parse( 'ju5t 1nval1d' );
171			}
172
173			}
174

DataValues / Time

Pull Request — master (#134)

YearTimeParserTest::validInputProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like