| Conditions | 4 |
| Paths | 5 |
| Total Lines | 111 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 48 | public function validInputProvider() { |
||
| 49 | $gregorian = 'http://www.wikidata.org/entity/Q1985727'; |
||
| 50 | $julian = 'http://www.wikidata.org/entity/Q1985786'; |
||
| 51 | |||
| 52 | $argLists = array(); |
||
| 53 | |||
| 54 | $valid = array( |
||
| 55 | // Whitespace |
||
| 56 | "January 2016\n" => |
||
| 57 | array( '+2016-01-00T00:00:00Z' ), |
||
| 58 | ' January 2016 ' => |
||
| 59 | array( '+2016-01-00T00:00:00Z' ), |
||
| 60 | |||
| 61 | // leading zeros |
||
| 62 | '1 00001999' => |
||
| 63 | array( '+1999-01-00T00:00:00Z' ), |
||
| 64 | '1 0000000100001999' => |
||
| 65 | array( '+100001999-01-00T00:00:00Z' ), |
||
| 66 | |||
| 67 | // Negative years |
||
| 68 | '4 -1998' => |
||
| 69 | array( '-1998-04-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 70 | 'April -1998' => |
||
| 71 | array( '-1998-04-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 72 | '-1998 4' => |
||
| 73 | array( '-1998-04-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 74 | '-1998 April' => |
||
| 75 | array( '-1998-04-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 76 | |||
| 77 | // use string month names |
||
| 78 | 'Jan/1999' => |
||
| 79 | array( '+1999-01-00T00:00:00Z' ), |
||
| 80 | 'January/1999' => |
||
| 81 | array( '+1999-01-00T00:00:00Z' ), |
||
| 82 | 'January/1' => |
||
| 83 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 84 | '1999 January' => |
||
| 85 | array( '+1999-01-00T00:00:00Z' ), |
||
| 86 | 'January 1999' => |
||
| 87 | array( '+1999-01-00T00:00:00Z' ), |
||
| 88 | 'January-1' => |
||
| 89 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 90 | 'JanuARY-1' => |
||
| 91 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 92 | 'JaN/1999' => |
||
| 93 | array( '+1999-01-00T00:00:00Z' ), |
||
| 94 | 'januARY-1' => |
||
| 95 | array( '+0001-01-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 96 | 'jan/1999' => |
||
| 97 | array( '+1999-01-00T00:00:00Z' ), |
||
| 98 | |||
| 99 | // use different date separators |
||
| 100 | '1-1999' => |
||
| 101 | array( '+1999-01-00T00:00:00Z' ), |
||
| 102 | '1/1999' => |
||
| 103 | array( '+1999-01-00T00:00:00Z' ), |
||
| 104 | '1 / 1999' => |
||
| 105 | array( '+1999-01-00T00:00:00Z' ), |
||
| 106 | '1 1999' => |
||
| 107 | array( '+1999-01-00T00:00:00Z' ), |
||
| 108 | '1,1999' => |
||
| 109 | array( '+1999-01-00T00:00:00Z' ), |
||
| 110 | '1.1999' => |
||
| 111 | array( '+1999-01-00T00:00:00Z' ), |
||
| 112 | '1. 1999' => |
||
| 113 | array( '+1999-01-00T00:00:00Z' ), |
||
| 114 | |||
| 115 | // presume mm/yy unless impossible month, in which case switch |
||
| 116 | '12/12' => |
||
| 117 | array( '+0012-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 118 | '12/11' => |
||
| 119 | array( '+0011-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 120 | '11/12' => |
||
| 121 | array( '+0012-11-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 122 | '13/12' => |
||
| 123 | array( '+0013-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 124 | '12/13' => |
||
| 125 | array( '+0013-12-00T00:00:00Z', TimeValue::PRECISION_MONTH, $julian ), |
||
| 126 | '2000 1' => |
||
| 127 | array( '+2000-01-00T00:00:00Z' ), |
||
| 128 | |||
| 129 | // big years |
||
| 130 | 'April-1000000001' => |
||
| 131 | array( '+1000000001-04-00T00:00:00Z' ), |
||
| 132 | 'April 1000000001' => |
||
| 133 | array( '+1000000001-04-00T00:00:00Z' ), |
||
| 134 | '1000000001 April' => |
||
| 135 | array( '+1000000001-04-00T00:00:00Z' ), |
||
| 136 | '1 13000' => |
||
| 137 | array( '+13000-01-00T00:00:00Z' ), |
||
| 138 | |||
| 139 | // parse 0 month as if no month has been entered |
||
| 140 | '0.1999' => |
||
| 141 | array( '+1999-00-00T00:00:00Z', TimeValue::PRECISION_YEAR ), |
||
| 142 | '1999 0' => |
||
| 143 | array( '+1999-00-00T00:00:00Z', TimeValue::PRECISION_YEAR ), |
||
| 144 | ); |
||
| 145 | |||
| 146 | foreach ( $valid as $value => $expected ) { |
||
| 147 | $timestamp = $expected[0]; |
||
| 148 | $precision = isset( $expected[1] ) ? $expected[1] : TimeValue::PRECISION_MONTH; |
||
| 149 | $calendarModel = isset( $expected[2] ) ? $expected[2] : $gregorian; |
||
| 150 | |||
| 151 | $argLists[] = array( |
||
| 152 | (string)$value, |
||
| 153 | new TimeValue( $timestamp, 0, 0, 0, $precision, $calendarModel ) |
||
| 154 | ); |
||
| 155 | } |
||
| 156 | |||
| 157 | return $argLists; |
||
| 158 | } |
||
| 159 | |||
| 210 |