Conditions | 3 |
Paths | 3 |
Total Lines | 75 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
36 | public function validInputProvider() { |
||
37 | $gregorian = 'http://www.wikidata.org/entity/Q1985727'; |
||
38 | $julian = 'http://www.wikidata.org/entity/Q1985786'; |
||
39 | |||
40 | $valid = array( |
||
41 | // Whitespace |
||
42 | "2016-01-01\n" => array( '+2016-01-01T00:00:00Z' ), |
||
43 | ' 2016-01-01 ' => array( '+2016-01-01T00:00:00Z' ), |
||
44 | |||
45 | // YMD, typically used in ISO 8601 |
||
46 | '2015-12-31' => array( '+2015-12-31T00:00:00Z' ), |
||
47 | '2015 12 31' => array( '+2015-12-31T00:00:00Z' ), |
||
48 | '2015 1 13' => array( '+2015-01-13T00:00:00Z' ), |
||
49 | |||
50 | // DMY |
||
51 | '31.12.2015' => array( '+2015-12-31T00:00:00Z' ), |
||
52 | '31. 12. 2015' => array( '+2015-12-31T00:00:00Z' ), |
||
53 | '31/12/2015' => array( '+2015-12-31T00:00:00Z' ), |
||
54 | '31 12 2015' => array( '+2015-12-31T00:00:00Z' ), |
||
55 | '31th 12th 2015' => array( '+2015-12-31T00:00:00Z' ), |
||
56 | 'day 31, month 12, year 2015' => array( '+2015-12-31T00:00:00Z' ), |
||
57 | |||
58 | // MDY, almost exclusively used in the United States |
||
59 | '12/31/2015' => array( '+2015-12-31T00:00:00Z' ), |
||
60 | '12-31-2015' => array( '+2015-12-31T00:00:00Z' ), |
||
61 | '12 31 2015' => array( '+2015-12-31T00:00:00Z' ), |
||
62 | |||
63 | // YDM, exclusively used in Kazakhstan |
||
64 | // https://en.wikipedia.org/wiki/Calendar_date#Gregorian.2C_year-day-month_.28YDM.29 |
||
65 | '2015.31.12' => array( '+2015-12-31T00:00:00Z' ), |
||
66 | '2015 13 1' => array( '+2015-01-13T00:00:00Z' ), |
||
67 | |||
68 | // Month and day are the same, does not matter if DMY or MDY |
||
69 | '01 1 2015' => array( '+2015-01-01T00:00:00Z' ), |
||
70 | '12 12 2015' => array( '+2015-12-12T00:00:00Z' ), |
||
71 | |||
72 | // Month and day are the same, does not matter if YMD or YDM |
||
73 | '2015 01 1' => array( '+2015-01-01T00:00:00Z' ), |
||
74 | '2015 12 12' => array( '+2015-12-12T00:00:00Z' ), |
||
75 | |||
76 | // Julian |
||
77 | '32-12-31' => array( '+0032-12-31T00:00:00Z', $julian ), |
||
78 | '31.12.32' => array( '+0032-12-31T00:00:00Z', $julian ), |
||
79 | '12/31/60' => array( '+0060-12-31T00:00:00Z', $julian ), |
||
80 | |||
81 | // Negative years |
||
82 | '-2015-12-31' => array( '-2015-12-31T00:00:00Z', $julian ), |
||
83 | 'year -2015-12-31' => array( '-2015-12-31T00:00:00Z', $julian ), |
||
84 | '31 12 -2015' => array( '-2015-12-31T00:00:00Z', $julian ), |
||
85 | '12/31/-2015' => array( '-2015-12-31T00:00:00Z', $julian ), |
||
86 | '2015-12-31 BC' => array( '-2015-12-31T00:00:00Z', $julian ), |
||
87 | '31 12 2015 BC' => array( '-2015-12-31T00:00:00Z', $julian ), |
||
88 | '12/31/2015 BC' => array( '-2015-12-31T00:00:00Z', $julian ), |
||
89 | |||
90 | // A negative number must be the year. |
||
91 | 'year -3-2-13' => array( '-0003-02-13T00:00:00Z', $julian ), |
||
92 | '13. 2. -3' => array( '-0003-02-13T00:00:00Z', $julian ), |
||
93 | '23:12:-59' => array( '-0059-12-23T00:00:00Z', $julian ), |
||
94 | ); |
||
95 | |||
96 | $cases = array(); |
||
97 | |||
98 | foreach ( $valid as $value => $args ) { |
||
99 | $timestamp = $args[0]; |
||
100 | $calendarModel = isset( $args[1] ) ? $args[1] : $gregorian; |
||
101 | |||
102 | $cases[] = array( |
||
103 | // Because PHP magically turns numeric keys into ints/floats |
||
104 | (string)$value, |
||
105 | new TimeValue( $timestamp, 0, 0, 0, TimeValue::PRECISION_DAY, $calendarModel ) |
||
106 | ); |
||
107 | } |
||
108 | |||
109 | return $cases; |
||
110 | } |
||
111 | |||
294 |