| Conditions | 1 |
| Paths | 1 |
| Total Lines | 124 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 105 | public function invalidConstructorArgumentsProvider() { |
||
| 106 | return array( |
||
| 107 | 'String timezone' => array( |
||
| 108 | '+00000002013-01-01T00:00:00Z', |
||
| 109 | '0', 0, 0, |
||
| 110 | TimeValue::PRECISION_SECOND, |
||
| 111 | 'http://nyan.cat/original.php' |
||
| 112 | ), |
||
| 113 | 'Float timezone' => array( |
||
| 114 | '+00000002013-01-01T00:00:00Z', |
||
| 115 | 4.2, 0, 0, |
||
| 116 | TimeValue::PRECISION_SECOND, |
||
| 117 | 'http://nyan.cat/original.php' |
||
| 118 | ), |
||
| 119 | 'Timezone out of range' => array( |
||
| 120 | '+00000002013-01-01T00:00:00Z', |
||
| 121 | -20 * 3600, 0, 0, |
||
| 122 | TimeValue::PRECISION_SECOND, |
||
| 123 | 'http://nyan.cat/original.php' |
||
| 124 | ), |
||
| 125 | 'Precision out of range' => array( |
||
| 126 | '+00000002013-01-01T00:00:00Z', |
||
| 127 | 0, 0, 0, |
||
| 128 | 15, |
||
| 129 | 'http://nyan.cat/original.php' |
||
| 130 | ), |
||
| 131 | 'Integer timestamp' => array( |
||
| 132 | 42, |
||
| 133 | 0, 0, 0, |
||
| 134 | TimeValue::PRECISION_SECOND, |
||
| 135 | 'http://nyan.cat/original.php' |
||
| 136 | ), |
||
| 137 | 'Float before' => array( |
||
| 138 | '+00000002013-01-01T00:00:00Z', |
||
| 139 | 0, 4.2, 0, |
||
| 140 | TimeValue::PRECISION_SECOND, |
||
| 141 | 'http://nyan.cat/original.php' |
||
| 142 | ), |
||
| 143 | 'Negative after' => array( |
||
| 144 | '+00000002013-01-01T00:00:00Z', |
||
| 145 | 0, 0, -1, |
||
| 146 | TimeValue::PRECISION_SECOND, |
||
| 147 | 'http://nyan.cat/original.php' |
||
| 148 | ), |
||
| 149 | 'Non-ISO timestamp' => array( |
||
| 150 | 'bla', |
||
| 151 | 0, 0, 0, |
||
| 152 | TimeValue::PRECISION_SECOND, |
||
| 153 | 'http://nyan.cat/original.php' |
||
| 154 | ), |
||
| 155 | 'Invalid separators' => array( |
||
| 156 | '+00000002013/01/01 00:00:00', |
||
| 157 | 0, 0, 0, |
||
| 158 | TimeValue::PRECISION_SECOND, |
||
| 159 | 'http://nyan.cat/original.php' |
||
| 160 | ), |
||
| 161 | 'No month' => array( |
||
| 162 | '+2015-00-01T00:00:00Z', |
||
| 163 | 0, 0, 0, |
||
| 164 | TimeValue::PRECISION_DAY, |
||
| 165 | 'http://nyan.cat/original.php' |
||
| 166 | ), |
||
| 167 | 'No day but hour' => array( |
||
| 168 | '+2015-01-00T01:00:00Z', |
||
| 169 | 0, 0, 0, |
||
| 170 | TimeValue::PRECISION_DAY, |
||
| 171 | 'http://nyan.cat/original.php' |
||
| 172 | ), |
||
| 173 | 'No day but minute' => array( |
||
| 174 | '+2015-01-00T00:01:00Z', |
||
| 175 | 0, 0, 0, |
||
| 176 | TimeValue::PRECISION_DAY, |
||
| 177 | 'http://nyan.cat/original.php' |
||
| 178 | ), |
||
| 179 | 'No day but second' => array( |
||
| 180 | '+2015-01-00T00:00:01Z', |
||
| 181 | 0, 0, 0, |
||
| 182 | TimeValue::PRECISION_DAY, |
||
| 183 | 'http://nyan.cat/original.php' |
||
| 184 | ), |
||
| 185 | 'Month out of range' => array( |
||
| 186 | '+00000002013-13-01T00:00:00Z', |
||
| 187 | 0, 0, 0, |
||
| 188 | TimeValue::PRECISION_SECOND, |
||
| 189 | 'http://nyan.cat/original.php' |
||
| 190 | ), |
||
| 191 | 'Day out of range' => array( |
||
| 192 | '+00000002013-01-32T00:00:00Z', |
||
| 193 | 0, 0, 0, |
||
| 194 | TimeValue::PRECISION_SECOND, |
||
| 195 | 'http://nyan.cat/original.php' |
||
| 196 | ), |
||
| 197 | 'Hour out of range' => array( |
||
| 198 | '+00000002013-01-01T24:00:00Z', |
||
| 199 | 0, 0, 0, |
||
| 200 | TimeValue::PRECISION_SECOND, |
||
| 201 | 'http://nyan.cat/original.php' |
||
| 202 | ), |
||
| 203 | 'Minute out of range' => array( |
||
| 204 | '+00000002013-01-01T00:60:00Z', |
||
| 205 | 0, 0, 0, |
||
| 206 | TimeValue::PRECISION_SECOND, |
||
| 207 | 'http://nyan.cat/original.php' |
||
| 208 | ), |
||
| 209 | 'Second out of range' => array( |
||
| 210 | '+00000002013-01-01T00:00:62Z', |
||
| 211 | 0, 0, 0, |
||
| 212 | TimeValue::PRECISION_SECOND, |
||
| 213 | 'http://nyan.cat/original.php' |
||
| 214 | ), |
||
| 215 | 'Invalid timezone' => array( |
||
| 216 | '+00000002013-01-01T00:00:00+60', |
||
| 217 | 0, 0, 0, |
||
| 218 | TimeValue::PRECISION_SECOND, |
||
| 219 | 'http://nyan.cat/original.php' |
||
| 220 | ), |
||
| 221 | 'Year to long' => array( |
||
| 222 | '+00000000000000001-01-01T00:00:00Z', |
||
| 223 | 0, 0, 0, |
||
| 224 | TimeValue::PRECISION_DAY, |
||
| 225 | 'http://nyan.cat/original.php' |
||
| 226 | ), |
||
| 227 | ); |
||
| 228 | } |
||
| 229 | |||
| 305 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.