Complex classes like QuantityValue often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use QuantityValue, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
19 | class QuantityValue extends DataValueObject { |
||
20 | |||
21 | /** |
||
22 | * The quantity's amount |
||
23 | * |
||
24 | * @var DecimalValue |
||
25 | */ |
||
26 | private $amount; |
||
27 | |||
28 | /** |
||
29 | * The quantity's unit identifier (use "1" for unitless quantities). |
||
30 | * |
||
31 | * @var string |
||
32 | */ |
||
33 | private $unit; |
||
34 | |||
35 | /** |
||
36 | * The quantity's upper bound |
||
37 | * |
||
38 | * @var DecimalValue|null |
||
39 | */ |
||
40 | private $upperBound; |
||
41 | |||
42 | /** |
||
43 | * The quantity's lower bound |
||
44 | * |
||
45 | * @var DecimalValue|null |
||
46 | */ |
||
47 | private $lowerBound; |
||
48 | |||
49 | /** |
||
50 | * Constructs a new QuantityValue object, representing the given value. |
||
51 | * |
||
52 | * @since 0.1 |
||
53 | * |
||
54 | * @param DecimalValue $amount |
||
55 | * @param string $unit A unit identifier. Must not be empty, use "1" for unit-less quantities. |
||
56 | * @param DecimalValue|null $upperBound The upper bound of the quantity, inclusive. |
||
57 | * @param DecimalValue|null $lowerBound The lower bound of the quantity, inclusive. |
||
58 | * |
||
59 | * @throws IllegalValueException |
||
60 | */ |
||
61 | public function __construct( |
||
92 | |||
93 | /** |
||
94 | * Returns a QuantityValue representing the given amount. |
||
95 | * If no upper or lower bound is given, the amount is assumed to be absolutely exact, |
||
96 | * that is, the amount itself will be used as the upper and lower bound. |
||
97 | * |
||
98 | * This is a convenience wrapper around the constructor that accepts native values |
||
99 | * instead of DecimalValue objects. |
||
100 | * |
||
101 | * @note: if the amount or a bound is given as a string, the string must conform |
||
102 | * to the rules defined by @see DecimalValue. |
||
103 | * |
||
104 | * @since 0.1 |
||
105 | * |
||
106 | * @param string|int|float|DecimalValue $amount |
||
107 | * @param string $unit A unit identifier. Must not be empty, use "1" for unit-less quantities. |
||
108 | * @param string|int|float|DecimalValue|null $upperBound |
||
109 | * @param string|int|float|DecimalValue|null $lowerBound |
||
110 | * |
||
111 | * @return self |
||
112 | * @throws IllegalValueException |
||
113 | */ |
||
114 | public static function newFromNumber( $amount, $unit = '1', $upperBound = null, $lowerBound = null ) { |
||
127 | |||
128 | /** |
||
129 | * @see newFromNumber |
||
130 | * |
||
131 | * @deprecated since 0.1, use newFromNumber instead |
||
132 | * |
||
133 | * @param string|int|float|DecimalValue $amount |
||
134 | * @param string $unit |
||
135 | * @param string|int|float|DecimalValue|null $upperBound |
||
136 | * @param string|int|float|DecimalValue|null $lowerBound |
||
137 | * |
||
138 | * @return self |
||
139 | */ |
||
140 | public static function newFromDecimal( $amount, $unit = '1', $upperBound = null, $lowerBound = null ) { |
||
143 | |||
144 | /** |
||
145 | * Converts $number to a DecimalValue if possible and necessary. |
||
146 | * |
||
147 | * @note: if the $number is given as a string, it must conform to the rules |
||
148 | * defined by @see DecimalValue. |
||
149 | * |
||
150 | * @param string $name The variable name to use in exception messages |
||
151 | * @param string|int|float|DecimalValue $number |
||
152 | * |
||
153 | * @throws IllegalValueException |
||
154 | * @throws InvalidArgumentException |
||
155 | * @return DecimalValue |
||
156 | */ |
||
157 | private static function asDecimalValue( $name, $number ) { |
||
172 | |||
173 | /** |
||
174 | * @see Serializable::serialize |
||
175 | * |
||
176 | * @since 0.1 |
||
177 | * |
||
178 | * @return string |
||
179 | */ |
||
180 | public function serialize() { |
||
188 | |||
189 | /** |
||
190 | * @see Serializable::unserialize |
||
191 | * |
||
192 | * @since 0.1 |
||
193 | * |
||
194 | * @param string $data |
||
195 | */ |
||
196 | public function unserialize( $data ) { |
||
200 | |||
201 | /** |
||
202 | * @see DataValue::getType |
||
203 | * |
||
204 | * @since 0.1 |
||
205 | * |
||
206 | * @return string |
||
207 | */ |
||
208 | public static function getType() { |
||
211 | |||
212 | /** |
||
213 | * @see DataValue::getSortKey |
||
214 | * |
||
215 | * @since 0.1 |
||
216 | * |
||
217 | * @return float |
||
218 | */ |
||
219 | public function getSortKey() { |
||
222 | |||
223 | /** |
||
224 | * Returns the quantity object. |
||
225 | * @see DataValue::getValue |
||
226 | * |
||
227 | * @since 0.1 |
||
228 | * |
||
229 | * @return self |
||
230 | */ |
||
231 | public function getValue() { |
||
234 | |||
235 | /** |
||
236 | * Returns the amount represented by this quantity. |
||
237 | * |
||
238 | * @since 0.1 |
||
239 | * |
||
240 | * @return DecimalValue |
||
241 | */ |
||
242 | public function getAmount() { |
||
245 | |||
246 | /** |
||
247 | * Returns this quantity's upper bound. |
||
248 | * |
||
249 | * @since 0.1 |
||
250 | * |
||
251 | * @return DecimalValue|null |
||
252 | */ |
||
253 | public function getUpperBound() { |
||
256 | |||
257 | /** |
||
258 | * Returns this quantity's lower bound. |
||
259 | * |
||
260 | * @since 0.1 |
||
261 | * |
||
262 | * @return DecimalValue|null |
||
263 | */ |
||
264 | public function getLowerBound() { |
||
267 | |||
268 | /** |
||
269 | * Returns the size of the uncertainty interval. |
||
270 | * This can roughly be interpreted as "amount +/- uncertainty/2". |
||
271 | * |
||
272 | * The exact interpretation of the uncertainty interval is left to the concrete application or |
||
273 | * data point. For example, the uncertainty interval may be defined to be that part of a |
||
274 | * normal distribution that is required to cover the 95th percentile. |
||
275 | * |
||
276 | * @since 0.1 |
||
277 | * |
||
278 | * @return float|null |
||
279 | */ |
||
280 | public function getUncertainty() { |
||
285 | |||
286 | /** |
||
287 | * Returns a DecimalValue representing the symmetrical offset to be applied |
||
288 | * to the raw amount for a rough representation of the uncertainty interval, |
||
289 | * as in "amount +/- offset". |
||
290 | * |
||
291 | * The offset is calculated as max( amount - lowerBound, upperBound - amount ). |
||
292 | * |
||
293 | * @since 0.1 |
||
294 | * |
||
295 | * @return DecimalValue|null |
||
296 | */ |
||
297 | public function getUncertaintyMargin() { |
||
310 | |||
311 | /** |
||
312 | * Returns the order of magnitude of the uncertainty as the exponent of |
||
313 | * last significant digit in the amount-string. The value returned by this |
||
314 | * is suitable for use with @see DecimalMath::roundToExponent(). |
||
315 | * |
||
316 | * @example: if two digits after the decimal point are significant, this |
||
317 | * returns -2. |
||
318 | * |
||
319 | * @example: if the last two digits before the decimal point are insignificant, |
||
320 | * this returns 2. |
||
321 | * |
||
322 | * Note that this calculation assumes a symmetric uncertainty interval, |
||
323 | * and can be misleading. |
||
324 | * |
||
325 | * @since 0.1 |
||
326 | * |
||
327 | * @return int|null |
||
328 | */ |
||
329 | public function getOrderOfUncertainty() { |
||
355 | |||
356 | /** |
||
357 | * Returns the number of significant figures in the amount-string, |
||
358 | * counting the decimal point, but not counting the leading sign. |
||
359 | * |
||
360 | * Note that this calculation assumes a symmetric uncertainty interval, and can be misleading |
||
361 | * |
||
362 | * @since 0.1 |
||
363 | * |
||
364 | * @return int|null |
||
365 | */ |
||
366 | public function getSignificantFigures() { |
||
381 | |||
382 | /** |
||
383 | * Returns the unit held by this quantity. |
||
384 | * Unit-less quantities should use "1" as their unit. |
||
385 | * |
||
386 | * @since 0.1 |
||
387 | * |
||
388 | * @return string |
||
389 | */ |
||
390 | public function getUnit() { |
||
393 | |||
394 | /** |
||
395 | * Returns a transformed value derived from this QuantityValue by applying |
||
396 | * the given transformation to the amount and the upper and lower bounds. |
||
397 | * The resulting amount and bounds are rounded to the significant number of |
||
398 | * digits. Note that for exact quantities (with at least one bound equal to |
||
399 | * the amount), no rounding is applied (since they are considered to have |
||
400 | * infinite precision). |
||
401 | * |
||
402 | * The transformation is provided as a callback, which must implement a |
||
403 | * monotonously increasing, fully differentiable function mapping a DecimalValue |
||
404 | * to a DecimalValue. Typically, it will be a linear transformation applying a |
||
405 | * factor and an offset. |
||
406 | * |
||
407 | * @param string $newUnit The unit of the transformed quantity. |
||
408 | * |
||
409 | * @param callable $transformation A callback that implements the desired transformation. |
||
410 | * The transformation will be called three times, once for the amount, once |
||
411 | * for the lower bound, and once for the upper bound. It must return a DecimalValue. |
||
412 | * The first parameter passed to $transformation is the DecimalValue to transform |
||
413 | * In addition, any extra parameters passed to transform() will be passed through |
||
414 | * to the transformation callback. |
||
415 | * |
||
416 | * @param mixed ... Any extra parameters will be passed to the $transformation function. |
||
417 | * |
||
418 | * @throws InvalidArgumentException |
||
419 | * @return self |
||
420 | */ |
||
421 | public function transform( $newUnit, $transformation ) { |
||
468 | |||
469 | public function __toString() { |
||
476 | |||
477 | /** |
||
478 | * @see DataValue::getArrayValue |
||
479 | * |
||
480 | * @since 0.1 |
||
481 | * |
||
482 | * @return string[] |
||
483 | */ |
||
484 | public function getArrayValue() { |
||
499 | |||
500 | /** |
||
501 | * Constructs a new instance of the DataValue from the provided data. |
||
502 | * This can round-trip with @see getArrayValue |
||
503 | * |
||
504 | * @since 0.1 |
||
505 | * |
||
506 | * @param mixed $data |
||
507 | * |
||
508 | * @return self |
||
509 | * @throws IllegalValueException |
||
510 | */ |
||
511 | public static function newFromArray( $data ) { |
||
521 | |||
522 | /** |
||
523 | * @see Comparable::equals |
||
524 | * |
||
525 | * @since 0.1 |
||
526 | * |
||
527 | * @param mixed $target |
||
528 | * |
||
529 | * @return bool |
||
530 | */ |
||
531 | public function equals( $target ) { |
||
539 | |||
540 | } |
||
541 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: