Complex classes like LatLongFormatter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use LatLongFormatter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
30 | class LatLongFormatter extends ValueFormatterBase { |
||
31 | |||
32 | /** |
||
33 | * Output formats for use with the self::OPT_FORMAT option. |
||
34 | */ |
||
35 | const TYPE_FLOAT = 'float'; |
||
36 | const TYPE_DMS = 'dms'; |
||
37 | const TYPE_DM = 'dm'; |
||
38 | const TYPE_DD = 'dd'; |
||
39 | |||
40 | /** |
||
41 | * The symbols representing the different directions for usage in directional notation. |
||
42 | * @since 0.1 |
||
43 | */ |
||
44 | const OPT_NORTH_SYMBOL = 'north'; |
||
45 | const OPT_EAST_SYMBOL = 'east'; |
||
46 | const OPT_SOUTH_SYMBOL = 'south'; |
||
47 | const OPT_WEST_SYMBOL = 'west'; |
||
48 | |||
49 | /** |
||
50 | * The symbols representing degrees, minutes and seconds. |
||
51 | * @since 0.1 |
||
52 | */ |
||
53 | const OPT_DEGREE_SYMBOL = 'degree'; |
||
54 | const OPT_MINUTE_SYMBOL = 'minute'; |
||
55 | const OPT_SECOND_SYMBOL = 'second'; |
||
56 | |||
57 | /** |
||
58 | * Flags for use with the self::OPT_SPACING_LEVEL option. |
||
59 | */ |
||
60 | const OPT_SPACE_LATLONG = 'latlong'; |
||
61 | const OPT_SPACE_DIRECTION = 'direction'; |
||
62 | const OPT_SPACE_COORDPARTS = 'coordparts'; |
||
63 | |||
64 | /** |
||
65 | * Option specifying the output format (also referred to as output type). Must be one of the |
||
66 | * self::TYPE_… constants. |
||
67 | */ |
||
68 | const OPT_FORMAT = 'geoformat'; |
||
69 | |||
70 | /** |
||
71 | * Boolean option specifying if negative coordinates should have minus signs, e.g. "-1°, -2°" |
||
72 | * (false) or cardinal directions, e.g. "1° S, 2° W" (true). Default is false. |
||
73 | */ |
||
74 | const OPT_DIRECTIONAL = 'directional'; |
||
75 | |||
76 | /** |
||
77 | * Option for the separator character between latitude and longitude. Defaults to a comma. |
||
78 | */ |
||
79 | const OPT_SEPARATOR_SYMBOL = 'separator'; |
||
80 | |||
81 | /** |
||
82 | * Option specifying the amount and position of space characters in the output. Must be an array |
||
83 | * containing zero or more of the self::OPT_SPACE_… flags. |
||
84 | */ |
||
85 | const OPT_SPACING_LEVEL = 'spacing'; |
||
86 | |||
87 | /** |
||
88 | * Option specifying the precision in fractional degrees. Must be a number or numeric string. |
||
89 | */ |
||
90 | const OPT_PRECISION = 'precision'; |
||
91 | |||
92 | public function __construct( FormatterOptions $options = null ) { |
||
115 | 158 | ||
116 | 158 | /** |
|
117 | * @see ValueFormatter::format |
||
118 | 158 | * |
|
119 | 158 | * Calls formatLatLongValue() using OPT_PRECISION for the $precision parameter. |
|
120 | * |
||
121 | * @param LatLongValue $value |
||
122 | * |
||
123 | * @return string Plain text |
||
124 | * @throws InvalidArgumentException |
||
125 | */ |
||
126 | public function format( $value ) { |
||
135 | |||
136 | 151 | /** |
|
137 | * Formats a LatLongValue with the desired precision. |
||
138 | 151 | * |
|
139 | * @since 0.5 |
||
140 | * |
||
141 | * @param LatLongValue $value |
||
142 | * @param float|int $precision The desired precision, given as fractional degrees. |
||
143 | * |
||
144 | * @return string Plain text |
||
145 | * @throws InvalidArgumentException |
||
146 | */ |
||
147 | public function formatLatLongValue( LatLongValue $value, $precision ) { |
||
162 | |||
163 | /** |
||
164 | * @param string $spacingLevel One of the self::OPT_SPACE_… constants |
||
165 | 156 | * |
|
166 | * @return string |
||
167 | */ |
||
168 | private function getSpacing( $spacingLevel ) { |
||
174 | 157 | ||
175 | 157 | /** |
|
176 | * @param float $latitude |
||
177 | 2 | * @param float|int $precision |
|
178 | * |
||
179 | * @return string |
||
180 | */ |
||
181 | private function formatLatitude( $latitude, $precision ) { |
||
188 | 157 | ||
189 | 156 | /** |
|
190 | 156 | * @param float $longitude |
|
191 | * @param float|int $precision |
||
192 | * |
||
193 | * @return string |
||
194 | */ |
||
195 | private function formatLongitude( $longitude, $precision ) { |
||
202 | 156 | ||
203 | 156 | /** |
|
204 | 156 | * @param string $coordinate |
|
205 | * @param string $positiveSymbol |
||
206 | * @param string $negativeSymbol |
||
207 | * |
||
208 | * @return string |
||
209 | */ |
||
210 | private function makeDirectionalIfNeeded( $coordinate, $positiveSymbol, $negativeSymbol ) { |
||
217 | 4 | ||
218 | /** |
||
219 | * @param string $coordinate |
||
220 | 152 | * @param string $positiveSymbol |
|
221 | * @param string $negativeSymbol |
||
222 | * |
||
223 | * @return string |
||
224 | */ |
||
225 | private function makeDirectional( $coordinate, $positiveSymbol, $negativeSymbol ) { |
||
236 | |||
237 | 4 | /** |
|
238 | * @param float $degrees |
||
239 | 4 | * @param float|int $precision |
|
240 | * |
||
241 | * @return string |
||
242 | */ |
||
243 | private function formatCoordinate( $degrees, $precision ) { |
||
272 | 34 | ||
273 | /** |
||
274 | * Round degrees according to OPT_PRECISION |
||
275 | 1 | * |
|
276 | * @param float $degrees |
||
277 | * @param float|int $precision |
||
278 | * |
||
279 | * @return float |
||
280 | */ |
||
281 | private function roundDegrees( $degrees, $precision ) { |
||
288 | 157 | ||
289 | 157 | /** |
|
290 | * @param float $floatDegrees |
||
291 | 157 | * |
|
292 | * @return string |
||
293 | */ |
||
294 | private function getInFloatFormat( $floatDegrees ) { |
||
304 | 8 | ||
305 | /** |
||
306 | * @param float $floatDegrees |
||
307 | 38 | * @param float|int $precision |
|
308 | * |
||
309 | * @return string |
||
310 | */ |
||
311 | private function getInDecimalDegreeFormat( $floatDegrees, $precision ) { |
||
317 | 42 | ||
318 | 42 | /** |
|
319 | * @param float $floatDegrees |
||
320 | 42 | * @param float|int $precision |
|
321 | * |
||
322 | * @return string |
||
323 | */ |
||
324 | private function getInDegreeMinuteSecondFormat( $floatDegrees, $precision ) { |
||
351 | 16 | ||
352 | /** |
||
353 | * @param float $floatDegrees |
||
354 | 34 | * @param float|int $precision |
|
355 | * |
||
356 | * @return string |
||
357 | */ |
||
358 | private function getInDecimalMinuteFormat( $floatDegrees, $precision ) { |
||
380 | 24 | ||
381 | /** |
||
382 | * @param float|int $unitsPerDegree The number of target units per degree |
||
383 | 42 | * (60 for minutes, 3600 for seconds) |
|
384 | * @param float|int $degreePrecision |
||
385 | * |
||
386 | * @return int The number of digits to show after the decimal point |
||
387 | * (resp. before, if the result is negative). |
||
388 | */ |
||
389 | private function getSignificantDigits( $unitsPerDegree, $degreePrecision ) { |
||
392 | |||
393 | /** |
||
394 | 118 | * @param float $number |
|
395 | 118 | * @param int $digits The number of digits after the decimal point. |
|
396 | * |
||
397 | * @return string |
||
398 | */ |
||
399 | private function formatNumber( $number, $digits = 0 ) { |
||
403 | |||
404 | } |
||
405 |