HydratorInterfaceTestTrait::validLdapUserAttributesProvider() - Code Metrics - Inspection of "Deprecated classes & Symfony requirements" - DarwinOnLine/DoLLdapBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (022a1c)

by Darwin

created 2017-11-08 08:02 UTC

validLdapUserAttributesProvider() A

↳ Parent: HydratorInterfaceTestTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	66
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	44
nc	1
nop	0
dl	0
loc	66
rs	9.3191
c	0
b	0
f	0

How to fix Long Method

<?php

namespace DoL\LdapBundle\Tests\Hydrator;

use DoL\LdapBundle\Hydrator\HydratorInterface;
use PHPUnit_Framework_Assert as Assert;
use Symfony\Component\Security\Core\User\UserInterface;

/**
 * Common test methods for any FR3D\LdapBundle\Hydrator\HydratorInterface implementation.
 */
trait HydratorInterfaceTestTrait
{
    /**
     * @var HydratorInterface
     */
    protected $hydrator;

    public function testImplementsHydratorInterface()
    {
        Assert::assertInstanceOf(HydratorInterface::class, $this->hydrator);
    }

    /**
     * @dataProvider validLdapUserAttributesProvider
     *
     * @param array $ldapEntry
     * @param array $methodsReturn
     */
    public function testHydrate(array $ldapEntry, array $methodsReturn)
    {
        $user = $this->hydrator->hydrate($ldapEntry);

        Assert::assertInstanceOf(UserInterface::class, $user);
        foreach ($methodsReturn as $method => $returnValue) {
            Assert::assertEquals($returnValue, $user->$method(), "UserInterface::{$method}() return value mismatch");
        }
    }

    /**
     * @return array
     */
    public function validLdapUserAttributesProvider()
    {
        return [
            // Description => [ldap entry, [UserInterfaceMethod => return value]]
            'hydrate single attributes' => [
                'ldap entry' => [
                    'dn' => 'ou=group, dc=host, dc=foo',
                    'count' => 1,
                    'uid' => [
                        'count' => 1,
                        0 => 'test_username',
                    ],
                ],
                'expected methods return' => [
                    'getUserName' => 'test_username',
                ],
            ],
            'hydrate attributes collections' => [
                'ldap entry' => [
                    'dn' => 'ou=group, dc=host, dc=foo',
                    'roles' => [
                        'count' => 2,
                        0 => 'ROLE1',
                        1 => 'ROLE2',
                    ],
                ],
                'expected methods return' => [
                    'getRoles' => [
                        0 => 'ROLE1',
                        1 => 'ROLE2',
                    ],
                ],
            ],
            'hydrate single attributes without count index' => [
                'ldap entry' => [
                    'dn' => 'ou=group, dc=host, dc=foo',
                    'uid' => [
                        0 => 'test_username',
                    ],
                ],
                'expected methods return' => [
                    'getUserName' => 'test_username',
                ],
            ],
            'hydrate attributes collections without count index' => [
                'ldap entry' => [
                    'dn' => 'ou=group, dc=host, dc=foo',
                    'roles' => [
                        0 => 'ROLE1',
                        1 => 'ROLE2',
                    ],
                ],
                'expected methods return' => [
                    'getRoles' => [
                        0 => 'ROLE1',
                        1 => 'ROLE2',
                    ],
                ],
            ],
            'empty ldap entry return an empty user' => [
                'ldap entry' => [
                    'dn' => 'ou=group, dc=host, dc=foo',
                    'count' => 1,
                ],
                'expected methods return' => [
                    'getUserName' => null,
                ],
            ],
        ];
    }
}


1			<?php
2
3			namespace DoL\LdapBundle\Tests\Hydrator;
4
5			use DoL\LdapBundle\Hydrator\HydratorInterface;
6			use PHPUnit_Framework_Assert as Assert;
7			use Symfony\Component\Security\Core\User\UserInterface;
8
9			/**
10			* Common test methods for any FR3D\LdapBundle\Hydrator\HydratorInterface implementation.
11			*/
12			trait HydratorInterfaceTestTrait
13			{
14			/**
15			* @var HydratorInterface
16			*/
17			protected $hydrator;
18
19			public function testImplementsHydratorInterface()
20			{
21			Assert::assertInstanceOf(HydratorInterface::class, $this->hydrator);
22			}
23
24			/**
25			* @dataProvider validLdapUserAttributesProvider
26			*
27			* @param array $ldapEntry
28			* @param array $methodsReturn
29			*/
30			public function testHydrate(array $ldapEntry, array $methodsReturn)
31			{
32			$user = $this->hydrator->hydrate($ldapEntry);
33
34			Assert::assertInstanceOf(UserInterface::class, $user);
35			foreach ($methodsReturn as $method => $returnValue) {
36			Assert::assertEquals($returnValue, $user->$method(), "UserInterface::{$method}() return value mismatch");
37			}
38			}
39
40			/**
41			* @return array
42			*/
43			public function validLdapUserAttributesProvider()
44			{
45			return [
46			// Description => [ldap entry, [UserInterfaceMethod => return value]]
47			'hydrate single attributes' => [
48			'ldap entry' => [
49			'dn' => 'ou=group, dc=host, dc=foo',
50			'count' => 1,
51			'uid' => [
52			'count' => 1,
53			0 => 'test_username',
54			],
55			],
56			'expected methods return' => [
57			'getUserName' => 'test_username',
58			],
59			],
60			'hydrate attributes collections' => [
61			'ldap entry' => [
62			'dn' => 'ou=group, dc=host, dc=foo',
63			'roles' => [
64			'count' => 2,
65			0 => 'ROLE1',
66			1 => 'ROLE2',
67			],
68			],
69			'expected methods return' => [
70			'getRoles' => [
71			0 => 'ROLE1',
72			1 => 'ROLE2',
73			],
74			],
75			],
76			'hydrate single attributes without count index' => [
77			'ldap entry' => [
78			'dn' => 'ou=group, dc=host, dc=foo',
79			'uid' => [
80			0 => 'test_username',
81			],
82			],
83			'expected methods return' => [
84			'getUserName' => 'test_username',
85			],
86			],
87			'hydrate attributes collections without count index' => [
88			'ldap entry' => [
89			'dn' => 'ou=group, dc=host, dc=foo',
90			'roles' => [
91			0 => 'ROLE1',
92			1 => 'ROLE2',
93			],
94			],
95			'expected methods return' => [
96			'getRoles' => [
97			0 => 'ROLE1',
98			1 => 'ROLE2',
99			],
100			],
101			],
102			'empty ldap entry return an empty user' => [
103			'ldap entry' => [
104			'dn' => 'ou=group, dc=host, dc=foo',
105			'count' => 1,
106			],
107			'expected methods return' => [
108			'getUserName' => null,
109			],
110			],
111			];
112			}
113			}
114

DarwinOnLine / DoLLdapBundle

Branch — master (022a1c)

validLdapUserAttributesProvider() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like