DoL\LdapBundle\Ldap\LdapManager

Complexity

Total Complexity

23

Size/Duplication

Total Lines	142
Duplicated Lines	21.13 %

Test Coverage

Coverage

77.78%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	findUserByUsername()	13	17	5
C	findUserBy()	13	28	7
A	__construct()	0	5	1
A	setLdapAttr()	0	13	3
A	bind()	0	18	4
A	buildFilter()	0	12	3

<?php

namespace DoL\LdapBundle\Ldap;

use DoL\LdapBundle\Driver\LdapDriverInterface;
use Symfony\Component\Security\Core\User\UserInterface;
use DoL\LdapBundle\Hydrator\HydratorInterface;

/**
 * Ldap manager for multi-domains.
 *
 * @author DarwinOnLine
 * @author Maks3w
 *
 * @see https://github.com/DarwinOnLine/DoLLdapBundle
 */
class LdapManager implements LdapManagerInterface
{
    protected $driver;
    protected $paramSets = [];

    protected $params = [];
    protected $ldapAttributes = [];
    protected $ldapUsernameAttr;

    /**
     * @var HydratorInterface
     */
    protected $hydrator;

    public function __construct(LdapDriverInterface $driver, HydratorInterface $hydrator, array $paramSets)
    {
        $this->driver = $driver;
        $this->hydrator = $hydrator;
        $this->paramSets = $paramSets;
    }

    /**
     * {@inheritdoc}
     */
    public function bind(UserInterface $user, $password)
    {
        if (!empty($this->params)) {
            return $this->driver->bind($user, $password);
        } else {
            foreach ($this->paramSets as $paramSet) {
                $this->driver->init($paramSet['driver']);

                if (false !== $this->driver->bind($user, $password)) {
                    $this->params = $paramSet['user'];
                    $this->setLdapAttr();

                    return true;
                }
            }
        }

        return false;
    }

    /**
     * {@inheritdoc}
     */
    public function findUserByUsername($username)
    {
        if (!empty($this->params)) {
            return $this->findUserBy([$this->ldapUsernameAttr => $username]);
        } else {

This code seems to be duplicated across your project.

            foreach ($this->paramSets as $paramSet) {
                $this->driver->init($paramSet['driver']);
                $this->params = $paramSet['user'];
                $this->setLdapAttr();

                $user = $this->findUserBy([$this->ldapUsernameAttr => $username]);
                if (false !== $user && $user instanceof UserInterface) {
                    return $user;
                }

                $this->params = [];
                $this->setLdapAttr();
            }
        }
    }

    /**
     * {@inheritdoc}
     */
    public function findUserBy(array $criteria)
    {
        if (!empty($this->params)) {
            $filter = $this->buildFilter($criteria);
            $entries = $this->driver->search($this->params['baseDn'], $filter);
            if ($entries['count'] > 1) {
                throw new \Exception('This search can only return a single user');
            }

            if (0 == $entries['count']) {
                return null;
            }
            $user = $this->hydrator->hydrate($entries[0]);

            return $user;
        } else {

This code seems to be duplicated across your project.

            foreach ($this->paramSets as $paramSet) {
                $this->driver->init($paramSet['driver']);
                $this->params = $paramSet['user'];
                $this->setLdapAttr();

                $user = $this->findUserBy($criteria);
                if (false !== $user && $user instanceof UserInterface) {
                    return $user;
                }

                $this->params = [];
                $this->setLdapAttr();
            }
        }
    }

    /**
     * Sets temp Ldap attributes.
     */
    private function setLdapAttr()
    {
        if (isset($this->params['attributes'])) {
            $this->hydrator->setAttributeMap($this->params['attributes']);

            foreach ($this->params['attributes'] as $attr) {
                $this->ldapAttributes[] = $attr['ldap_attr'];
            }

            $this->ldapUsernameAttr = $this->ldapAttributes[0];
        } else {
            $this->ldapAttributes = [];
            $this->ldapUsernameAttr = null;
        }
    }

    /**
     * Build Ldap filter.
     *
     * @param array  $criteria
     * @param string $condition
     *
     * @return string
     */
    protected function buildFilter(array $criteria, $condition = '&')
    {
        $filters = [];
        if (isset($this->params['filter'])) {
            $filters[] = $this->params['filter'];
        }
        foreach ($criteria as $key => $value) {
            $value = ldap_escape($value, '', LDAP_ESCAPE_FILTER);
            $filters[] = sprintf('(%s=%s)', $key, $value);
        }

        return sprintf('(%s%s)', $condition, implode($filters));

The call to implode() has too few arguments starting with pieces.

$filters of type array is incompatible with the type string expected by parameter $glue of implode().

    }
}