search_module::main() - Code Metrics - Inspection of "Fix GitHub Templates" - Dark1z/memberavatarstatus - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d4eec7...bde0dd )

by Dark❶

created 2021-01-10 11:27 UTC

search_module::main() A

↳ Parent: search_module

Complexity

Conditions	3
Paths	3

Size

Total Lines	52
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	38
c	1
b	0
f	0
nc	3
nop	0
dl	0
loc	52
rs	9.312

How to fix Long Method

<?php
/**
 *
 * Member Avatar & Status [MAS]. An extension for the phpBB Forum Software package.
 *
 * @copyright (c) 2018-2020, Dark❶ [dark1]
 * @license GNU General Public License, version 2 (GPL-2.0-only)
 *
 */

namespace dark1\memberavatarstatus\acp;

use dark1\memberavatarstatus\core\memberavatarstatus;

/**
 * Member Avatar & Status ACP module.
 */
class search_module
{
	public $page_title;
	public $tpl_name;
	public $u_action;

	public function main()
	{
		global $phpbb_container, $config, $request, $template, $user, $language, $phpbb_log;
		$mas = $phpbb_container->get('dark1.memberavatarstatus');
		$ext_name_mas = 'Member Avatar & Status [MAS]';
		$ext_by_dark1 = 'Dark❶ [dark1]';

		$user->add_lang_ext('dark1/memberavatarstatus', 'lang_acp_mas');
		$this->tpl_name = 'acp_mas_search';
		$this->page_title = $language->lang('ACP_MAS_TITLE') . ' - ' . $language->lang('ACP_MAS_MODE_SEARCH');
		add_form_key('acp_mas_search');

		if ($request->is_set_post('submit'))
		{
			if (!check_form_key('acp_mas_search'))
			{
				trigger_error('FORM_INVALID', E_USER_WARNING);
			}

			// Get Setting from ACP
			$config->set('dark1_mas_sh_fp_av', $request->variable('dark1_mas_sh_fp_av', 0));
			$config->set('dark1_mas_sh_fp_ol', $request->variable('dark1_mas_sh_fp_ol', 0));
			$config->set('dark1_mas_sh_lp_av', $request->variable('dark1_mas_sh_lp_av', 0));
			$config->set('dark1_mas_sh_lp_ol', $request->variable('dark1_mas_sh_lp_ol', 0));
			$config->set('dark1_mas_sh_up_av', $request->variable('dark1_mas_sh_up_av', 0));
			$config->set('dark1_mas_sh_up_ol', $request->variable('dark1_mas_sh_up_ol', 0));

			// Check Avatar Size Before Assigning
			$config->set('dark1_mas_sh_fp_av_sz', $mas->mas_get_avatar_size($request->variable('dark1_mas_sh_fp_av_sz', memberavatarstatus::AV_DEF_SZ_SML), memberavatarstatus::AV_DEF_SZ_SML, memberavatarstatus::AV_MAX_SZ_SML));
			$config->set('dark1_mas_sh_lp_av_sz', $mas->mas_get_avatar_size($request->variable('dark1_mas_sh_lp_av_sz', memberavatarstatus::AV_DEF_SZ_SML), memberavatarstatus::AV_DEF_SZ_SML, memberavatarstatus::AV_MAX_SZ_SML));
			$config->set('dark1_mas_sh_up_av_sz', $mas->mas_get_avatar_size($request->variable('dark1_mas_sh_up_av_sz', memberavatarstatus::AV_DEF_SZ_SML), memberavatarstatus::AV_DEF_SZ_SML, memberavatarstatus::AV_MAX_SZ_SML));

			$phpbb_log->add('admin', $user->data['user_id'], $user->ip, 'ACP_MAS_LOG_SET_SAV', time(), array($language->lang('ACP_MAS_MODE_SEARCH')));
			trigger_error($language->lang('ACP_MAS_LOG_SET_SAV', $language->lang('ACP_MAS_MODE_SEARCH')) . adm_back_link($this->u_action), E_USER_NOTICE);
		}

		$template->assign_vars(array(
			'U_ACTION'			=> $this->u_action,
			'MAS_EXT_NAME'		=> $ext_name_mas,
			'MAS_EXT_DEV'		=> $ext_by_dark1,
			'MAS_COLOR_OFFLINE'	=> $config['dark1_mas_col_off'],
			'MAS_COLOR_ONLINE'	=> $config['dark1_mas_col_on'],
			'MAS_SH_FP_AVATAR'	=> $config['dark1_mas_sh_fp_av'],
			'MAS_SH_FP_AV_SIZE'	=> $config['dark1_mas_sh_fp_av_sz'],
			'MAS_SH_FP_ONLINE'	=> $config['dark1_mas_sh_fp_ol'],
			'MAS_SH_LP_AVATAR'	=> $config['dark1_mas_sh_lp_av'],
			'MAS_SH_LP_AV_SIZE'	=> $config['dark1_mas_sh_lp_av_sz'],
			'MAS_SH_LP_ONLINE'	=> $config['dark1_mas_sh_lp_ol'],
			'MAS_SH_UP_AVATAR'	=> $config['dark1_mas_sh_up_av'],
			'MAS_SH_UP_AV_SIZE'	=> $config['dark1_mas_sh_up_av_sz'],
			'MAS_SH_UP_ONLINE'	=> $config['dark1_mas_sh_up_ol'],
			'MAS_NO_AVATAR_IMG'	=> $mas->mas_get_no_avatar_img(),
		));
	}

}


1			<?php
2			/**
3			*
4			* Member Avatar & Status [MAS]. An extension for the phpBB Forum Software package.
5			*
6			* @copyright (c) 2018-2020, Dark❶ [dark1]
7			* @license GNU General Public License, version 2 (GPL-2.0-only)
8			*
9			*/
10
11			namespace dark1\memberavatarstatus\acp;
12
13			use dark1\memberavatarstatus\core\memberavatarstatus;
14
15			/**
16			* Member Avatar & Status ACP module.
17			*/
18			class search_module
19			{
20			public $page_title;
21			public $tpl_name;
22			public $u_action;
23
24			public function main()
25			{
26			global $phpbb_container, $config, $request, $template, $user, $language, $phpbb_log;
27			$mas = $phpbb_container->get('dark1.memberavatarstatus');
28			$ext_name_mas = 'Member Avatar & Status [MAS]';
29			$ext_by_dark1 = 'Dark❶ [dark1]';
30
31			$user->add_lang_ext('dark1/memberavatarstatus', 'lang_acp_mas');
32			$this->tpl_name = 'acp_mas_search';
33			$this->page_title = $language->lang('ACP_MAS_TITLE') . ' - ' . $language->lang('ACP_MAS_MODE_SEARCH');
34			add_form_key('acp_mas_search');
35
36			if ($request->is_set_post('submit'))
37			{
38			if (!check_form_key('acp_mas_search'))
39			{
40			trigger_error('FORM_INVALID', E_USER_WARNING);
41			}
42
43			// Get Setting from ACP
44			$config->set('dark1_mas_sh_fp_av', $request->variable('dark1_mas_sh_fp_av', 0));
45			$config->set('dark1_mas_sh_fp_ol', $request->variable('dark1_mas_sh_fp_ol', 0));
46			$config->set('dark1_mas_sh_lp_av', $request->variable('dark1_mas_sh_lp_av', 0));
47			$config->set('dark1_mas_sh_lp_ol', $request->variable('dark1_mas_sh_lp_ol', 0));
48			$config->set('dark1_mas_sh_up_av', $request->variable('dark1_mas_sh_up_av', 0));
49			$config->set('dark1_mas_sh_up_ol', $request->variable('dark1_mas_sh_up_ol', 0));
50
51			// Check Avatar Size Before Assigning
52			$config->set('dark1_mas_sh_fp_av_sz', $mas->mas_get_avatar_size($request->variable('dark1_mas_sh_fp_av_sz', memberavatarstatus::AV_DEF_SZ_SML), memberavatarstatus::AV_DEF_SZ_SML, memberavatarstatus::AV_MAX_SZ_SML));
53			$config->set('dark1_mas_sh_lp_av_sz', $mas->mas_get_avatar_size($request->variable('dark1_mas_sh_lp_av_sz', memberavatarstatus::AV_DEF_SZ_SML), memberavatarstatus::AV_DEF_SZ_SML, memberavatarstatus::AV_MAX_SZ_SML));
54			$config->set('dark1_mas_sh_up_av_sz', $mas->mas_get_avatar_size($request->variable('dark1_mas_sh_up_av_sz', memberavatarstatus::AV_DEF_SZ_SML), memberavatarstatus::AV_DEF_SZ_SML, memberavatarstatus::AV_MAX_SZ_SML));
55
56			$phpbb_log->add('admin', $user->data['user_id'], $user->ip, 'ACP_MAS_LOG_SET_SAV', time(), array($language->lang('ACP_MAS_MODE_SEARCH')));
57			trigger_error($language->lang('ACP_MAS_LOG_SET_SAV', $language->lang('ACP_MAS_MODE_SEARCH')) . adm_back_link($this->u_action), E_USER_NOTICE);
58			}
59
60			$template->assign_vars(array(
61			'U_ACTION' => $this->u_action,
62			'MAS_EXT_NAME' => $ext_name_mas,
63			'MAS_EXT_DEV' => $ext_by_dark1,
64			'MAS_COLOR_OFFLINE' => $config['dark1_mas_col_off'],
65			'MAS_COLOR_ONLINE' => $config['dark1_mas_col_on'],
66			'MAS_SH_FP_AVATAR' => $config['dark1_mas_sh_fp_av'],
67			'MAS_SH_FP_AV_SIZE' => $config['dark1_mas_sh_fp_av_sz'],
68			'MAS_SH_FP_ONLINE' => $config['dark1_mas_sh_fp_ol'],
69			'MAS_SH_LP_AVATAR' => $config['dark1_mas_sh_lp_av'],
70			'MAS_SH_LP_AV_SIZE' => $config['dark1_mas_sh_lp_av_sz'],
71			'MAS_SH_LP_ONLINE' => $config['dark1_mas_sh_lp_ol'],
72			'MAS_SH_UP_AVATAR' => $config['dark1_mas_sh_up_av'],
73			'MAS_SH_UP_AV_SIZE' => $config['dark1_mas_sh_up_av_sz'],
74			'MAS_SH_UP_ONLINE' => $config['dark1_mas_sh_up_ol'],
75			'MAS_NO_AVATAR_IMG' => $mas->mas_get_no_avatar_img(),
76			));
77			}
78
79			}
80

Dark1z / memberavatarstatus

Push — master ( d4eec7...bde0dd )

search_module::main() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like