Dark1z /
memberavatarstatus
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 53 |
| Code Lines | 43 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 22 | public function main() |
||
| 23 | { |
||
| 24 | global $config, $template, $user, $language, $phpbb_root_path, $phpbb_adm_relative_path, $phpEx; |
||
| 25 | $ext_name_mas = 'Member Avatar & Status [MAS]'; |
||
| 26 | $ext_by_dark1 = 'Dark❶ [dark1]'; |
||
| 27 | |||
| 28 | $user->add_lang_ext('dark1/memberavatarstatus', 'lang_acp_mas'); |
||
| 29 | $this->tpl_name = 'acp_mas_main'; |
||
| 30 | $this->page_title = $language->lang('ACP_MAS_TITLE') . ' - ' . $language->lang('ACP_MAS_MODE_MAIN'); |
||
| 31 | $main_adm_path = $phpbb_root_path . $phpbb_adm_relative_path . 'index.' . $phpEx; |
||
| 32 | |||
| 33 | $template->assign_vars(array( |
||
| 34 | 'MAS_EXT_NAME' => $ext_name_mas, |
||
| 35 | 'MAS_EXT_DEV' => $ext_by_dark1, |
||
| 36 | 'MAS_PHPBB_LK_AV' => append_sid($main_adm_path, 'i=acp_board&mode=avatar#allow_avatar'), |
||
| 37 | 'MAS_PHPBB_LK_OL' => append_sid($main_adm_path, 'i=acp_board&mode=load#load_onlinetrack'), |
||
| 38 | 'MAS_PHPBB_AVATAR' => $config['allow_avatar'], |
||
| 39 | 'MAS_PHPBB_ONLINE' => $config['load_onlinetrack'], |
||
| 40 | // General |
||
| 41 | 'MAS_AVATAR' => $config['dark1_mas_avatar'], |
||
| 42 | 'MAS_ONLINE' => $config['dark1_mas_online'], |
||
| 43 | 'MAS_COLOR_OFFLINE' => $config['dark1_mas_col_off'], |
||
| 44 | 'MAS_COLOR_ONLINE' => $config['dark1_mas_col_on'], |
||
| 45 | // MemberList |
||
| 46 | 'MAS_ML_AVATAR' => $config['dark1_mas_ml_av'], |
||
| 47 | 'MAS_ML_AV_SIZE' => $config['dark1_mas_ml_av_sz'], |
||
| 48 | 'MAS_ML_ONLINE' => $config['dark1_mas_ml_ol'], |
||
| 49 | // ViewOnline |
||
| 50 | 'MAS_VO_PG_AVATAR' => $config['dark1_mas_vo_pg_av'], |
||
| 51 | 'MAS_VO_PG_AV_SIZE' => $config['dark1_mas_vo_pg_av_sz'], |
||
| 52 | 'MAS_VO_SB_AVATAR' => $config['dark1_mas_vo_sb_av'], |
||
| 53 | 'MAS_VO_SB_AV_SIZE' => $config['dark1_mas_vo_sb_av_sz'], |
||
| 54 | // ViewForum |
||
| 55 | 'MAS_VF_FP_AVATAR' => $config['dark1_mas_vf_fp_av'], |
||
| 56 | 'MAS_VF_FP_AV_SIZE' => $config['dark1_mas_vf_fp_av_sz'], |
||
| 57 | 'MAS_VF_FP_ONLINE' => $config['dark1_mas_vf_fp_ol'], |
||
| 58 | 'MAS_VF_LP_AVATAR' => $config['dark1_mas_vf_lp_av'], |
||
| 59 | 'MAS_VF_LP_AV_SIZE' => $config['dark1_mas_vf_lp_av_sz'], |
||
| 60 | 'MAS_VF_LP_ONLINE' => $config['dark1_mas_vf_lp_ol'], |
||
| 61 | // Search |
||
| 62 | 'MAS_SH_FP_AVATAR' => $config['dark1_mas_sh_fp_av'], |
||
| 63 | 'MAS_SH_FP_AV_SIZE' => $config['dark1_mas_sh_fp_av_sz'], |
||
| 64 | 'MAS_SH_FP_ONLINE' => $config['dark1_mas_sh_fp_ol'], |
||
| 65 | 'MAS_SH_LP_AVATAR' => $config['dark1_mas_sh_lp_av'], |
||
| 66 | 'MAS_SH_LP_AV_SIZE' => $config['dark1_mas_sh_lp_av_sz'], |
||
| 67 | 'MAS_SH_LP_ONLINE' => $config['dark1_mas_sh_lp_ol'], |
||
| 68 | 'MAS_SH_UP_AVATAR' => $config['dark1_mas_sh_up_av'], |
||
| 69 | 'MAS_SH_UP_AV_SIZE' => $config['dark1_mas_sh_up_av_sz'], |
||
| 70 | 'MAS_SH_UP_ONLINE' => $config['dark1_mas_sh_up_ol'], |
||
| 71 | // Review |
||
| 72 | 'MAS_RV_AVATAR' => $config['dark1_mas_rv_av'], |
||
| 73 | 'MAS_RV_AV_SIZE' => $config['dark1_mas_rv_av_sz'], |
||
| 74 | 'MAS_RV_ONLINE' => $config['dark1_mas_rv_ol'], |
||
| 75 | )); |
||
| 79 |
