Issues (94)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Utilities/BotState.php (2 issues)

Labels
Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
/*
4
 * This file is part of the PhpBotFramework.
5
 *
6
 * PhpBotFramework is free software: you can redistribute it and/or modify
7
 * it under the terms of the GNU Lesser General Public License as
8
 * published by the Free Software Foundation, version 3.
9
 *
10
 * PhpBotFramework is distributed in the hope that it will be useful, but
11
 * WITHOUT ANY WARRANTY; without even the implied warranty of
12
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13
 * Lesser General Public License for more details.
14
 *
15
 * You should have received a copy of the GNU Lesser General Public License
16
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
17
 */
18
19
namespace PhpBotFramework\Utilities;
20
21
/**
22
 * \addtogroup Modules
23
 * @{
24
 */
25
use PhpBotFramework\Exceptions\BotException;
26
27
use PhpBotFramework\BasicBot;
28
29
/**
30
 * \class BotState
31
 * \brief Handle users status.
32
 */
33
class BotState
34
{
35
    private $bot;
36
37
    /** \brief Current status of the user. */
38
    public $status;
39
40
    /**
41
     * \addtogroup State
42
     * \brief Create a state-based bot using these methods.
43
     * \details The bot will answer in different ways based on its internal state.
44
     *
45
     * Below an example where we save user's credentials using bot states:
46
     *
47
     *     <?php
48
     *
49
     *     // Include the framework
50
     *     require './vendor/autoload.php';
51
     *
52
     *     // Define bot state
53
     *     define("SEND_USERNAME", 1);
54
     *     define("SEND_PASSWORD", 2);
55
     *
56
     *     // Create the class for the bot that will handle login
57
     *     class LoginBot extends PhpBotFramework\Bot {
58
     *
59
     *         // Add the function for processing messages
60
     *         protected function processMessage($message) {
61
     *             switch($this->getStatus()) {
62
     *                 case SEND_USERNAME:
63
     *                     $this->sendMessage("Please, send your password.");
64
     *
65
     *                     // Update the bot state
66
     *                     $this->setStatus(SEND_PASSWORD);
67
     *                     break;
68
     *
69
     *                 // Or if we are expecting a password from the user
70
     *                 case SEND_PASSWORD:
71
     *                     $this->sendMessage("The registration is complete");
72
     *                     break;
73
     *             }
74
     *         }
75
     *
76
     *     }
77
     *
78
     *     $bot = new LoginBot("token");
79
     *
80
     *     $bot->redis = new Redis();
81
     *     $bot->redis->connect('127.0.0.1');
82
     *
83
     *     // Create the answer to the <code>/start</code> command
84
     *     $start_closure = function($bot, $message) {
85
     *         $bot->sendMessage("Please, send your username.");
86
     *         $bot->setStatus(SEND_USERNAME);
87
     *     };
88
     *
89
     *     $bot->addMessageCommand("start", $start_closure);
90
     *     $bot->getUpdatesLocal();
91
     * @{
92
     */
93
94 1
    public function __construct(BasicBot &$bot)
95
    {
96 1
        $this->bot = $bot;
97 1
    }
98
99
    /**
100
     * \brief Get current user status from Redis and set it in status variable.
101
     * \details Throws an exception if the Redis connection is missing.
102
     * @param int $default_status <i>Optional</i>. The default status to return
103
     * if there is no status for the current user.
104
     * @return int The status for the current user, $default_status if missing.
105
     */
106
    public function getStatus(int $default_status = -1) : int
107
    {
108
        $chat_id = $this->bot->getChatID();
109
        $redis = $this->bot->getRedis();
0 ignored issues
show
It seems like you code against a specific sub-type and not the parent class PhpBotFramework\BasicBot as the method getRedis() does only exist in the following sub-classes of PhpBotFramework\BasicBot: DonateBot, EchoBot, PhpBotFramework\Bot, PhpBotFramework\Test\TestBot, WhoAmIBot. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
110
        if ($redis->exists($chat_id . ':status')) {
111
            $this->status = $redis->get($chat_id . ':status');
112
            return $this->status;
113
        }
114
115
        $redis->set($chat_id . ':status', $default_status);
116
        $this->status = $default_status;
117
        return $this->status;
118
    }
119
120
    /**
121
     * \brief Set the status of the bot in both Redis and $status.
122
     * \details Throws an exception if the Redis connection is missing.
123
     * @param int $status The new status of the bot.
124
     */
125
    public function setStatus(int $status)
126
    {
127
        $redis = $this->bot->getRedis();
0 ignored issues
show
It seems like you code against a specific sub-type and not the parent class PhpBotFramework\BasicBot as the method getRedis() does only exist in the following sub-classes of PhpBotFramework\BasicBot: DonateBot, EchoBot, PhpBotFramework\Bot, PhpBotFramework\Test\TestBot, WhoAmIBot. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
128
        $redis->set($this->bot->getChatID() . ':status', $status);
129
130
        $this->status = $status;
131
    }
132
133
    /** @} */
134
}
135