Issues in MultiCharacterCommand.php (master) - Issues in master - DanySpin97/PhpBotFramework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (94)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Commands/MultiCharacterCommand.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the PhpBotFramework.
 *
 * PhpBotFramework is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as
 * published by the Free Software Foundation, version 3.
 *
 * PhpBotFramework is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

namespace PhpBotFramework\Commands;

use PhpBotFramework\Exceptions\BotException;

/**
 * \addtogroup Commands
 * @{
 */

/** \class MultiCharacterCommand
 */
class MultiCharacterCommand extends BasicCommand
{
    /** @} */

    public static $type = 'message';

    public static $object_class = 'PhpBotFramework\Entities\Message';

    public static $priority = 1;

    private $command;

    private $length;

    /**
     * \brief Add a function that will be executed everytime a message contain the selected command
     * \details Use this syntax to create a command:
     *
     *     $help_command = new PhpBotFramework\Commands\MultiCharacterCommand("help",
     *         function ($bot, $message) {
     *             $bot->sendMessage("This is a help message.");
     *         }, '!', '.', '/'
     *     );
     *
     * Then you can add it to the bot's commands using <code>addCommand</code> method:
     *
     *     $bot->addCommand($help_command);
     *
     * @param string $command The command that will trigger this function (e.g. start)
     * @param callable $script The function that will be triggered by a command.
     * Must take an object(the bot) and an array(the message received).
     */
    public function __construct(string $command, callable $script, string ...$chars)
    {
        $chars_count = count($chars);
        if ( $chars_count === 0)
        {
            throw new BotException("No character given for matching the command");
        }

        if ($chars_count === 1)
        {
            // Build a regex using the only character
            $this->regex_rule = $chars[0] . $command;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        // Build regex including all characters
        // Eg: (!|.)command

        else
        {
            $this->regex_rule = '(' . $chars[0];
            foreach($chars as $char)
            {
                $this->regex_rule .= '|' . $char;
            }
            $this->regex_rule .= ')' . $command;
        }

        $this->script = $script;
    }

    /**
     * @internal
     * \brief Process a message checking if it trigger any MessageCommand.
     * @param string $message Message to process.
     * @return bool True if the message trigger any command.
     */
    public function checkCommand(array $message) : bool
    {
        // Check the regex
        if (preg_match("/{$this->regex_rule}/", $message['text'])) {
                    // Return
                    return true;
        }

        return false;
    }
}


1			<?php
2
3			/*
4			* This file is part of the PhpBotFramework.
5			*
6			* PhpBotFramework is free software: you can redistribute it and/or modify
7			* it under the terms of the GNU Lesser General Public License as
8			* published by the Free Software Foundation, version 3.
9			*
10			* PhpBotFramework is distributed in the hope that it will be useful, but
11			* WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13			* Lesser General Public License for more details.
14			*
15			* You should have received a copy of the GNU Lesser General Public License
16			* along with this program. If not, see <http://www.gnu.org/licenses/>.
17			*/
18
19			namespace PhpBotFramework\Commands;
20
21			use PhpBotFramework\Exceptions\BotException;
22
23			/**
24			* \addtogroup Commands
25			* @{
26			*/
27
28			/** \class MultiCharacterCommand
29			*/
30			class MultiCharacterCommand extends BasicCommand
31			{
32			/** @} */
33
34			public static $type = 'message';
35
36			public static $object_class = 'PhpBotFramework\Entities\Message';
37
38			public static $priority = 1;
39
40			private $command;
41
42			private $length;
43
44			/**
45			* \brief Add a function that will be executed everytime a message contain the selected command
46			* \details Use this syntax to create a command:
47			*
48			* $help_command = new PhpBotFramework\Commands\MultiCharacterCommand("help",
49			* function ($bot, $message) {
50			* $bot->sendMessage("This is a help message.");
51			* }, '!', '.', '/'
52			* );
53			*
54			* Then you can add it to the bot's commands using <code>addCommand</code> method:
55			*
56			* $bot->addCommand($help_command);
57			*
58			* @param string $command The command that will trigger this function (e.g. start)
59			* @param callable $script The function that will be triggered by a command.
60			* Must take an object(the bot) and an array(the message received).
61			*/
62			public function __construct(string $command, callable $script, string ...$chars)
63			{
64			$chars_count = count($chars);
65			if ( $chars_count === 0)
66			{
67			throw new BotException("No character given for matching the command");
68			}
69
70			if ($chars_count === 1)
71			{
72			// Build a regex using the only character
73			$this->regex_rule = $chars[0] . $command;
			0 ignored issues – show Bug introduced 2017-05-31 20:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `regex_rule` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
74			}
75			// Build regex including all characters
76			// Eg: (!\|.)command
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-31 21:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
77			else
78			{
79			$this->regex_rule = '(' . $chars[0];
80			foreach($chars as $char)
81			{
82			$this->regex_rule .= '\|' . $char;
83			}
84			$this->regex_rule .= ')' . $command;
85			}
86
87			$this->script = $script;
88			}
89
90			/**
91			* @internal
92			* \brief Process a message checking if it trigger any MessageCommand.
93			* @param string $message Message to process.
94			* @return bool True if the message trigger any command.
95			*/
96			public function checkCommand(array $message) : bool
97			{
98			// Check the regex
99			if (preg_match("/{$this->regex_rule}/", $message['text'])) {
100			// Return
101			return true;
102			}
103
104			return false;
105			}
106			}
107

DanySpin97 / PhpBotFramework

Issues (94)

Security Analysis no request data

src/Commands/MultiCharacterCommand.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like